From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DE0FCD484C for ; Wed, 13 May 2026 05:12:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0B5F10E5AA; Wed, 13 May 2026 05:12:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="RzsDWlYV"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CADE10E5AA; Wed, 13 May 2026 05:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778649168; x=1810185168; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8zzjCCYUhDEsJ2EH+oXo6v0WIXE+NZx+8W4MJ2N4oVI=; b=RzsDWlYV7xhre+GfNGvy8oX7dUg+Vnd5X0AcJoB/YxrCvuNlLhjHeQTP 54LFyL9C/o+DZyZQGRpoU+qQJcoj8RHUtK9yFcmckuJoKVbI5dCHwiNKp qVJ6X4rNUTaZVXR2JDO9KT+Ijraqkn2xkPBddAOwb8eAcSlkUD4SgH77H /t6kjwcdDg6oU5Z3NR4QTJRDEPzlR3TdgH4zE/SCSX28V2iN543YEcO/F 9bm4IR30YHUjlUT/EcD7VAYRmmM1USsu/mHPACPwMaCK86QRdhUTBOUJ3 vBiYmUM1V0QY276Yl4sXpmxYd3E2uuLugjc8WdHz8rDkVdNfj5AGCZ1D3 A==; X-CSE-ConnectionGUID: S4mdFkjmQfGHHurl/4+aVQ== X-CSE-MsgGUID: EGi/j+UOR5GAciSUBMHolw== X-IronPort-AV: E=McAfee;i="6800,10657,11784"; a="90951223" X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="90951223" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2026 22:12:48 -0700 X-CSE-ConnectionGUID: 6e2oLoWRRTmM8k0sMmcAwQ== X-CSE-MsgGUID: E8d32tGnReGKJIA3bwBioQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,232,1770624000"; d="scan'208";a="238222434" Received: from lkp-server01.sh.intel.com (HELO dca79079c3eb) ([10.239.97.150]) by orviesa007.jf.intel.com with ESMTP; 12 May 2026 22:12:45 -0700 Received: from kbuild by dca79079c3eb with local (Exim 4.98.2) (envelope-from ) id 1wN1ti-000000003TX-2cq8; Wed, 13 May 2026 05:12:42 +0000 Date: Wed, 13 May 2026 13:11:54 +0800 From: kernel test robot To: Andre Jun Hirata , kenneth.feng@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch Cc: oe-kbuild-all@lists.linux.dev, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, gabriel.dimant@usp.br, guilhermesangabriel@usp.br, Andre Jun Hirata Subject: Re: [PATCH v4] drm/amd/pm: Use guard(mutex) instead of manual lock+unlock Message-ID: <202605131349.EV901kW3-lkp@intel.com> References: <20260508172345.6680-1-andrejhirata@usp.br> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508172345.6680-1-andrejhirata@usp.br> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Andre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v7.1-rc3 next-20260508] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andre-Jun-Hirata/drm-amd-pm-Use-guard-mutex-instead-of-manual-lock-unlock/20260513-062000 base: https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next patch link: https://lore.kernel.org/r/20260508172345.6680-1-andrejhirata%40usp.br patch subject: [PATCH v4] drm/amd/pm: Use guard(mutex) instead of manual lock+unlock config: x86_64-randconfig-072-20260513 (https://download.01.org/0day-ci/archive/20260513/202605131349.EV901kW3-lkp@intel.com/config) compiler: gcc-12 (Debian 12.4.0-5) 12.4.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260513/202605131349.EV901kW3-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202605131349.EV901kW3-lkp@intel.com/ All error/warnings (new ones prefixed by >>): drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_is_mode1_reset_supported': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:247:47: error: expected ';' before '}' token 247 | return smu_mode1_reset_is_support(smu) | ^ | ; 248 | } | ~ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_smu_i2c_bus_access': >> drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:405:16: error: expected expression before '=' token 405 | return = pp_funcs->smu_i2c_bus_access(pp_handle, | ^ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_get_vce_clock_state': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:833:31: warning: unused variable 'vstate' [-Wunused-variable] 833 | struct amd_vce_state *vstate = NULL; | ^~~~~~ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_get_pp_table': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:1016:16: error: expected expression before '=' token 1016 | return = pp_funcs->get_pp_table(adev->powerplay.pp_handle, | ^ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_set_fine_grain_clk_vol': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:1031:16: error: expected expression before '=' token 1031 | return = pp_funcs->set_fine_grain_clk_vol(adev->powerplay.pp_handle, | ^ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_get_display_mode_validation_clks': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:1498:16: error: expected expression before '=' token 1498 | return = pp_funcs->get_display_mode_validation_clocks(adev->powerplay.pp_handle, | ^ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_smu_i2c_bus_access': >> drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:407:1: warning: control reaches end of non-void function [-Wreturn-type] 407 | } | ^ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_get_pp_table': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:1018:1: warning: control reaches end of non-void function [-Wreturn-type] 1018 | } | ^ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_set_fine_grain_clk_vol': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:1035:1: warning: control reaches end of non-void function [-Wreturn-type] 1035 | } | ^ drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c: In function 'amdgpu_dpm_get_display_mode_validation_clks': drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c:1500:1: warning: control reaches end of non-void function [-Wreturn-type] 1500 | } | ^ vim +405 drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_dpm.c 393 394 int amdgpu_dpm_smu_i2c_bus_access(struct amdgpu_device *adev, 395 bool acquire) 396 { 397 void *pp_handle = adev->powerplay.pp_handle; 398 const struct amd_pm_funcs *pp_funcs = 399 adev->powerplay.pp_funcs; 400 401 if (!pp_funcs || !pp_funcs->smu_i2c_bus_access) 402 return -EOPNOTSUPP; 403 404 guard(mutex)(&adev->pm.mutex); > 405 return = pp_funcs->smu_i2c_bus_access(pp_handle, 406 acquire); > 407 } 408 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki