From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C956C43638 for ; Mon, 29 Jun 2026 07:07:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9748510E6F9; Mon, 29 Jun 2026 07:07:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=yeah.net header.i=@yeah.net header.b="Epgq3UxM"; dkim-atps=neutral Received: from mail-m16.yeah.net (mail-m16.yeah.net [1.95.21.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50A8110E4D3; Sat, 27 Jun 2026 13:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=rS cztThxqMJbnsrmUCiqJo7gdmh7LmFjJRjuznF/ZKU=; b=Epgq3UxMFPfUkowsbX A9p9PBTPo9kX1vMzfnmJ1ZC9TQs3USqKlroecITzE3N4MIXhUJgFYhMHoVrj8NTc PAuTCYJhN49160VDBs747R2aBEYcYb2uefP7wdIKiN91LnZ0ScAk9WbGoNyS7Ql/ 3BJOa+ocI8BXSrS898pJ/veAc= Received: from zhang.. (unknown []) by gzsmtp3 (Coremail) with UTF8SMTPSA id M88vCgD3nzkfzT9qCdkOAw--.16958S4; Sat, 27 Jun 2026 21:16:17 +0800 (CST) From: Ziran Zhang To: Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Markus Elfring Cc: Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ziran Zhang Subject: [PATCH v3] drm/amd/display: Remove redundant NULL check before kfree() in mod_power_create() Date: Sat, 27 Jun 2026 21:13:54 +0800 Message-ID: <20260627131354.5811-1-zhangcoder@yeah.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260627100945.5826-1-zhangcoder@yeah.net> References: <20260627100945.5826-1-zhangcoder@yeah.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: M88vCgD3nzkfzT9qCdkOAw--.16958S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZF17KFy8AF47Cr4DXFy8uFg_yoW8uF4xpF 4DKw15tw48G3W8KFnFg3W8XFy8Wa1kAFW3Wr47C3Wa9a45Zr9YkF18A34YgFWDWFy7tF18 tF1UKF4UXFy3Cw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRUUUUUUUUU= X-Originating-IP: [116.149.202.60] X-CM-SenderInfo: x2kd0wpfrgv2o61htxgoqh3/1tbiIQLlpmo-zSI18AAA3f X-Mailman-Approved-At: Mon, 29 Jun 2026 07:07:55 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" kfree() safely handles NULL pointers, so there is no need to check for NULL before calling kfree(). Remove redundant NULL check. Found by Coccinelle ifnullfree script. Signed-off-by: Ziran Zhang --- Changes in v3: - Add parentheses to "kfree" in subject line for consistency. .../gpu/drm/amd/display/modules/power/power.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modules/power/power.c b/drivers/gpu/drm/amd/display/modules/power/power.c index 5659a38b3..97889867a 100644 --- a/drivers/gpu/drm/amd/display/modules/power/power.c +++ b/drivers/gpu/drm/amd/display/modules/power/power.c @@ -270,13 +270,11 @@ struct mod_power *mod_power_create(struct dc *dc, fail_bad_brightness_range: fail_alloc_backlight_array: for (inst = 0; inst < edp_num; inst++) - if (core_power->bl_prop[inst].backlight_lut) - kfree(core_power->bl_prop[inst].backlight_lut); + kfree(core_power->bl_prop[inst].backlight_lut); fail_construct: - for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) { - if (core_power->map[i].psr_context) - kfree(core_power->map[i].psr_context); - } + for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) + kfree(core_power->map[i].psr_context); + kfree(core_power->map); fail_alloc_map: @@ -295,8 +293,7 @@ void mod_power_destroy(struct mod_power *mod_power) MOD_POWER_TO_CORE(mod_power); for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) - if (core_power->map[i].psr_context) - kfree(core_power->map[i].psr_context); + kfree(core_power->map[i].psr_context); for (i = 0; i < core_power->num_entities; i++) if (core_power->map[i].stream) @@ -305,8 +302,7 @@ void mod_power_destroy(struct mod_power *mod_power) kfree(core_power->map); for (i = 0; i < MAX_NUM_EDP; i++) - if (core_power->bl_prop[i].backlight_lut) - kfree(core_power->bl_prop[i].backlight_lut); + kfree(core_power->bl_prop[i].backlight_lut); kfree(core_power); } -- 2.43.0