From: linux@treblig.org
To: alexander.deucher@amd.com, christian.koenig@amd.com,
harry.wentland@amd.com, sunpeng.li@amd.com,
amd-gfx@lists.freedesktop.org
Cc: airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 0/4] drm/amdgpu: Remove is_idle method
Date: Sat, 15 Aug 2026 19:00:29 +0100 [thread overview]
Message-ID: <20260815180033.8958-1-linux@treblig.org> (raw)
From: "Dr. David Alan Gilbert" <linux@treblig.org>
The is_idle method in amd_ip_funcs is never called, however
there are some functions assigned to it.
Remove the bindings to it, and if the functions aren't called
anywhere else remove the function as well.
Remove the kunit test hook for it.
In many cases the wait_for_idle code either calls the
function which was wired to is_idle or duplicates the
code (or curiously kind of duplicates it with changes).
Based on drm-next-7.3 0d710af8e4abdd1fa500bddbab7c0ee47fc98143.
Booted on my Ryzen with RX560.
(That is spewing some warnings of the form:
[ 9.680879] [PLANE:44:plane-0] pixel format with alpha exposed but blend mode not setup
[ 9.680881] WARNING: drivers/gpu/drm/drm_mode_config.c:872 at drm_mode_config_validate+0x3c2/0x4f0, CPU#4: (udev-worker)/538
but I don't *think* I've gone anywhere near anything to do with pixel
formats etc)
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Dr. David Alan Gilbert (4):
drm/amdgpu: Remove is_idle test case
drm/amdgpu: Remove is_idle (trivial cases)
drm/amdgpu: Remove is_idle (non trivial functions)
drm/amdgpu: Remove is_idle
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 6 -----
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 -----
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 6 -----
drivers/gpu/drm/amd/amdgpu/cik.c | 7 ------
drivers/gpu/drm/amd/amdgpu/cik_ih.c | 12 ----------
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 1 -
drivers/gpu/drm/amd/amdgpu/cz_ih.c | 12 ----------
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 6 -----
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 6 -----
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 6 -----
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 12 ----------
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 12 ----------
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 12 ----------
drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 11 ---------
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 1 -
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 7 ------
drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 7 ------
drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 7 ------
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 13 -----------
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 ------
drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 12 ----------
drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 7 ------
drivers/gpu/drm/amd/amdgpu/ih_v6_1.c | 7 ------
drivers/gpu/drm/amd/amdgpu/ih_v7_0.c | 7 ------
drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 2 --
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_2.c | 1 -
drivers/gpu/drm/amd/amdgpu/jpeg_v5_3_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 7 ------
drivers/gpu/drm/amd/amdgpu/nv.c | 6 -----
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 13 -----------
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 13 -----------
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/si.c | 6 -----
drivers/gpu/drm/amd/amdgpu/si_dma.c | 1 -
drivers/gpu/drm/amd/amdgpu/si_ih.c | 1 -
drivers/gpu/drm/amd/amdgpu/soc15.c | 6 -----
drivers/gpu/drm/amd/amdgpu/soc21.c | 6 -----
drivers/gpu/drm/amd/amdgpu/soc24.c | 6 -----
drivers/gpu/drm/amd/amdgpu/soc_v1_0.c | 6 -----
drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 12 ----------
drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 8 -------
drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 8 -------
drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 8 -------
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/vce_v1_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 --
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 16 -------------
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 23 -------------------
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 21 -----------------
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 23 -------------------
drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 23 -------------------
drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 19 ---------------
drivers/gpu/drm/amd/amdgpu/vcn_v5_0_2.c | 19 ---------------
drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 ------
drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 7 ------
drivers/gpu/drm/amd/amdgpu/vi.c | 6 -----
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 -------
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 -
.../display/amdgpu_dm/tests/amdgpu_dm_test.c | 10 --------
drivers/gpu/drm/amd/include/amd_shared.h | 2 --
drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 6 -----
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 7 ------
.../gpu/drm/amd/pm/powerplay/amd_powerplay.c | 6 -----
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 -
87 files changed, 639 deletions(-)
--
2.55.0
next reply other threads:[~2026-08-17 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 18:00 linux [this message]
2026-08-15 18:00 ` [PATCH 1/4] drm/amdgpu: Remove is_idle test case linux
2026-08-15 18:00 ` [PATCH 2/4] drm/amdgpu: Remove is_idle (trivial cases) linux
2026-08-15 18:00 ` [PATCH 3/4] drm/amdgpu: Remove is_idle (non trivial functions) linux
2026-08-15 18:00 ` [PATCH 4/4] drm/amdgpu: Remove is_idle linux
2026-08-17 15:27 ` [PATCH 0/4] drm/amdgpu: Remove is_idle method Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260815180033.8958-1-linux@treblig.org \
--to=linux@treblig.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox