AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chi Hong <Chi.Hong@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Chi Hong <Chi.Hong@amd.com>
Subject: [PATCH] drm/amd/ras: skip RAS TA firmware reload on resume for SR-IOV VFs
Date: Mon, 28 Sep 2026 14:11:44 +0800	[thread overview]
Message-ID: <20260928061148.117428-1-Chi.Hong@amd.com> (raw)

SR-IOV VFs use amdgpu_virt_ras_hw_init() which skips ras_core_hw_init(),
leaving fw_gpu_mem unallocated. ras_psp_reload_firmwares() then hits the
NULL buffer and returns -ENOMEM (-12) for every VF on resume, aborting
ip_resume_phase2 before amdgpu_fence_driver_hw_init() runs. The next
hibernate double-puts IRQ refcounts causing a WARN storm.

Skip the reload for VFs — there is nothing local to reload. The
post-reset path (amdgpu_ras_mgr_resume_after_reset) is unaffected.

Fixes: 5e5be56a5b76 ("drm/amdgpu/ras: reload RAS TA from ras mgr resume")
Signed-off-by: Chi Hong <Chi.Hong@amd.com>
---
 drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c b/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c
index a02167397ce2..5bac792554f5 100644
--- a/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c
+++ b/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c
@@ -529,6 +529,9 @@ static int amdgpu_ras_mgr_resume(struct amdgpu_ip_block *ip_block)
 	if (!ras_mgr->ras_is_ready)
 		return 0;
 
+	if (amdgpu_sriov_vf(adev))
+		return 0;
+
 	ret = ras_psp_reload_firmwares(ras_mgr->ras_core, 0);
 	if (ret)
 		RAS_DEV_ERR(adev,
-- 
2.43.0


             reply	other threads:[~2026-09-28  6:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  6:11 Chi Hong [this message]
2026-09-29  7:25 ` [PATCH] drm/amd/ras: skip RAS TA firmware reload on resume for SR-IOV VFs Hong, Chi
2026-09-30  6:32   ` Zhang, Tiantian (Celine)
2026-09-30 11:25   ` Lazar, Lijo
2026-10-08  2:00     ` Hong, Chi
2026-10-08  2:35       ` Chai, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928061148.117428-1-Chi.Hong@amd.com \
    --to=chi.hong@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox