From: YuBiao Wang <YuBiao.Wang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Alexander.Deucher@amd.com>, <Hawking.Zhang@amd.com>,
<Lijo.Lazar@amd.com>
Subject: Re: [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8
Date: Tue, 29 Sep 2026 10:53:05 +0800 [thread overview]
Message-ID: <20260929025305.3897772-1-YuBiao.Wang@amd.com> (raw)
In-Reply-To: <20260924070121.2150251-1-YuBiao.Wang@amd.com>
Ping.
On Thu, Sep 24, 2026 at 07:01:21 UTC, YuBiao Wang wrote:
> psp_init_sriov_microcode() returns -EINVAL for an MP0 version it does not
> know about, so PSP init fails on a VF before any firmware is loaded.
>
> Add the MP0 15.0.8 case. It needs neither cap nor ta microcode, only the
> autoload trigger: on a VF psp_load_non_psp_fw() starts RLC autoload once it
> has handed virt.autoload_ucode_id to PSP, and on this generation IMU comes
> from the IFWI and is skipped, which leaves MES1 DATA as the last firmware
> PSP receives.
>
> Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 66eb2f34cc0d..453aef42556d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -173,6 +173,9 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
> case IP_VERSION(13, 0, 12):
> ret = psp_init_ta_microcode(psp, ucode_prefix);
> break;
> + case IP_VERSION(15, 0, 8):
> + adev->virt.autoload_ucode_id = AMDGPU_UCODE_ID_CP_MES1_DATA;
> + break;
> default:
> return -EINVAL;
> }
next prev parent reply other threads:[~2026-09-29 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 7:01 [PATCH] drm/amdgpu: add sriov microcode init for MP0 15.0.8 YuBiao Wang
2026-09-29 2:53 ` YuBiao Wang [this message]
2026-09-29 5:27 ` Lazar, Lijo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929025305.3897772-1-YuBiao.Wang@amd.com \
--to=yubiao.wang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Lijo.Lazar@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox