From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 148A1CA600D for ; Thu, 8 Oct 2026 19:34:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7252C10EA32; Thu, 8 Oct 2026 19:34:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ERZwJz7N"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id B654B10EA32 for ; Thu, 8 Oct 2026 19:33:58 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6240941827; Thu, 8 Oct 2026 19:33:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 147A81F00893; Thu, 8 Oct 2026 19:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791488038; bh=IJJ5yNSuhj+U00DAS2C+gX8mlhxc2VewJrIizDNf7kA=; h=Date:From:To:Cc:Subject:In-Reply-To; b=ERZwJz7N+wX+TSPIf81a+BxDW1Dxx9hAtAu5MOJanUYuVnpOb6vidAmt2wvz365Zl C784VjqrHPX4XdPzEWo9ccbMmlZK8gnp1oKGEYqM37qw1jow+UVdIgBKyPbCZe+01m CGLuEqD25+SlNvnkAlreiu1grazNfH/DEXsfm2guZSDUjiH2VYlcU9UUYriBWxYDMf 9v5biTK+W/Gtc5ynAUk3sLfeqty5EEpK59LReGV4u9uNlGd7O68m1WyzyeI7yTfwVw r23cgM7Dd+3vAYmV2tD4CBua+xcomr1P3prDxmHhnw2hDkFX9aLVIPN//yGgYXcrtR dSO/H1gH9VrsQ== Date: Thu, 8 Oct 2026 14:33:56 -0500 From: Bjorn Helgaas To: Alex Deucher Cc: Lukas Wunner , linux-pci@vger.kernel.org, Mahesh J Salgaonkar , Oliver OHalloran , linuxppc-dev@lists.ozlabs.org, Christian Koenig , Vitaly Prosyak , amd-gfx@lists.freedesktop.org, Aditya Garg , Jason Perlow , Thorsten Leemhuis Subject: Re: [PATCH for-linus] PCI/AER: Skip error recovery on false alarms Message-ID: <20261008193356.GA920772@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, Oct 08, 2026 at 03:23:34PM -0400, Alex Deucher wrote: > On Thu, Oct 8, 2026 at 3:17 PM Bjorn Helgaas wrote: > > On Thu, Oct 08, 2026 at 02:26:00PM +0200, Lukas Wunner wrote: > > > Alex is seeing a probe failure of the amdgpu driver after the Root Port > > > above an AMD Navi10 GPU has been reset. The reset was performed to > > > recover from a Firmware First reported Fatal Error. > > > > > > However all status registers in the Root Port's AER Extended Capability > > > are blank, so apparently the platform firmware raised a false alarm. > > > > > > The issue is only occurring since commit eddba19b8b5f ("PCI/AER: Support > > > Advisory Non-Fatal Errors"). It looks like enabling Advisory Non-Fatal > > > Errors causes code paths to be exercised in platform firmware which > > > were never validated before. > > > > > > Skip error recovery on false alarms, i.e. if no unmasked errors were > > > actually signaled. > > > > > > Note that this will also skip recovery if both the Status and Mask > > > registers are "all ones", as would be the case for inaccessible devices. > > > However that seems justified because it would imply either a hot-unplug > > > event or a Surprise Down Error further up in the hierarchy. Interfering > > > with recovery from that seems uncalled for. > > > > > > Fixes: eddba19b8b5f ("PCI/AER: Support Advisory Non-Fatal Errors") > > > Reported-by: Alex Deucher > > > Tested-by: Alex Deucher > > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=222095 > > > Signed-off-by: Lukas Wunner > > > > Applied to pci/for-linus for v7.3, thanks! I dropped Alex's Tested-by > > since he hasn't tested this change by itself. > > FWIW, I just tested this patch by itself and it works as expected. > Feel free to add: > Tested-by: Alex Deucher > Acked-by: Alex Deucher Added, thanks very much!