From: "Paneer Selvam, Arunpravin" <arunpravin.paneerselvam@amd.com>
To: "Sunil Khatri" <sunil.khatri@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Boyuan Zhang" <boyuan.zhang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] drm/amdgpu: add the argument description for gpu_addr
Date: Wed, 13 Nov 2024 14:43:50 +0530 [thread overview]
Message-ID: <23772701-e7ff-45ad-8049-92486398ec0a@amd.com> (raw)
In-Reply-To: <20241113090705.741598-2-sunil.khatri@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
On 11/13/2024 2:37 PM, Sunil Khatri wrote:
> Add argument description for the input argument
> gpu_addr for amdgpu_seq64_alloc.
>
> Fixes the warning raised by the compiler:
> drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168:
> warning: Function parameter or struct member 'gpu_addr' not described in 'amdgpu_seq64_alloc
>
> Cc: Arunpravin Paneer Selvam<Arunpravin.PaneerSelvam@amd.com>
> Signed-off-by: Sunil Khatri<sunil.khatri@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> index 0defad71044c..898d215a8d99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> @@ -156,6 +156,7 @@ void amdgpu_seq64_unmap(struct amdgpu_device *adev, struct amdgpu_fpriv *fpriv)
> *
> * @adev: amdgpu_device pointer
> * @va: VA to access the seq in process address space
> + * @gpu_addr: GPU address to access the seq
> * @cpu_addr: CPU address to access the seq
> *
> * Alloc a 64 bit memory from seq64 pool.
[-- Attachment #2: Type: text/html, Size: 1768 bytes --]
next prev parent reply other threads:[~2024-11-13 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 9:07 [PATCH v3 1/2] drm/amdgpu: add the argument description for inst Sunil Khatri
2024-11-13 9:07 ` [PATCH v3 2/2] drm/amdgpu: add the argument description for gpu_addr Sunil Khatri
2024-11-13 9:13 ` Paneer Selvam, Arunpravin [this message]
2024-11-13 14:26 ` Boyuan Zhang
2024-11-13 14:27 ` [PATCH v3 1/2] drm/amdgpu: add the argument description for inst Boyuan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23772701-e7ff-45ad-8049-92486398ec0a@amd.com \
--to=arunpravin.paneerselvam@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=boyuan.zhang@amd.com \
--cc=christian.koenig@amd.com \
--cc=sunil.khatri@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox