AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Le Ma <le.ma@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Lijo.Lazar@amd.com, Hawking.Zhang@amd.com
Subject: Re: [PATCH 3/3] drm/amdgpu: move debug options init prior to amdgpu device init
Date: Wed, 10 Jan 2024 09:49:57 +0100	[thread overview]
Message-ID: <24b8d275-6fb4-4ebb-ab36-bbb63d1d3bf0@gmail.com> (raw)
In-Reply-To: <20240109101359.28362-3-le.ma@amd.com>

Am 09.01.24 um 11:13 schrieb Le Ma:
> To bring debug options into effect in early initialization phase
>
> Signed-off-by: Le Ma <le.ma@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com> for this one and 
#1 in the series.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 3e0e39a1b5ba..b67ffc3a9a3f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -2234,6 +2234,8 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
>   
>   	pci_set_drvdata(pdev, ddev);
>   
> +	amdgpu_init_debug_options(adev);
> +
>   	ret = amdgpu_driver_load_kms(adev, flags);
>   	if (ret)
>   		goto err_pci;
> @@ -2314,8 +2316,6 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
>   			amdgpu_get_secondary_funcs(adev);
>   	}
>   
> -	amdgpu_init_debug_options(adev);
> -
>   	return 0;
>   
>   err_pci:


      reply	other threads:[~2024-01-10  8:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 10:13 [PATCH 1/3] Revert "drm/amdgpu: add param to specify fw bo location for front-door loading" Le Ma
2024-01-09 10:13 ` [PATCH 2/3] drm/amdgpu: add debug flag to change fw bo placement for frontdoor loading Le Ma
2024-01-09 10:44   ` Lazar, Lijo
2024-01-09 10:13 ` [PATCH 3/3] drm/amdgpu: move debug options init prior to amdgpu device init Le Ma
2024-01-10  8:49   ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24b8d275-6fb4-4ebb-ab36-bbb63d1d3bf0@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Lijo.Lazar@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=le.ma@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox