From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV Date: Tue, 16 Oct 2018 14:34:37 +0200 Message-ID: <2512cfee-a603-75c4-bf10-9ae0b4b8c5c7@gmail.com> References: <20181008133521.3237-1-christian.koenig@amd.com> <20181008133521.3237-2-christian.koenig@amd.com> <20181009091708.GB8763@hr-amur2> <5ae6a2fe-80d6-858e-dcd2-2d44ab0b76ce@gmail.com> <8d7c9d2e-6d4d-34d3-d8dc-102e253610f2@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <8d7c9d2e-6d4d-34d3-d8dc-102e253610f2-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Koenig, Christian" , "Liu, Monk" , "Ma, Sigil" , "Huang, Ray" , "Min, Frank" Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW5vdGhlciBnZW50bGUgcGluZz8gUmF5LCBNb25rIGNhbiBhbnlib2R5IGdpdmUgbWUgYW4gcmIg Zm9yIHRoaXMgcGF0Y2g/CgpJdCdzIHRoZSBsYXN0IG9uZSBpbiB0aGlzIHNlcmllcyBhbmQgSSB3 YW50IHRvIGdldCBpdCBkb25lLgoKQ2hyaXN0aWFuLgoKQW0gMTIuMTAuMjAxOCB1bSAxNjoyNyBz Y2hyaWViIEtvZW5pZywgQ2hyaXN0aWFuOgo+IEdyZWF0LCBjYW4gSSBnZXQgYW4gcmIgb3IgYWNr ZWQtYnkgZm9yIHRoZSBwYXRjaCBpbiB0aGlzIGNhc2U/Cj4KPiBUaGFua3MsCj4gQ2hyaXN0aWFu Lgo+Cj4gQW0gMTAuMTAuMjAxOCB1bSAwOTo1MiBzY2hyaWViIExpdSwgTW9uazoKPj4gVGhhbmtz IFNpZ2lsCj4+Cj4+IEhpIENocmlzdGlhbgo+Pgo+PiBMb29rcyB3ZSBjYW4gZW5hYmxlL2Rpc2Fi bGUgY3R4LXN3aXRjaCBmb3IgU0RNQSBhdCB3aWxsLCBubyBkZXBlbmRlbmN5IG9yIGNvbmZsaWN0 IG9uIFNSSU9WCj4+Cj4+IC9Nb25rCj4+Cj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+ IEZyb206IE1hLCBTaWdpbAo+PiBTZW50OiBXZWRuZXNkYXksIE9jdG9iZXIgMTAsIDIwMTggMzoy NSBQTQo+PiBUbzogTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsgS29lbmlnLCBDaHJpc3Rp YW4gPENocmlzdGlhbi5Lb2VuaWdAYW1kLmNvbT47IEh1YW5nLCBSYXkgPFJheS5IdWFuZ0BhbWQu Y29tPjsgTWluLCBGcmFuayA8RnJhbmsuTWluQGFtZC5jb20+Cj4+IENjOiBhbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+PiBTdWJqZWN0OiBSRTogW1BBVENIIDIvOF0gZHJtL2FtZGdwdTog Zml4IHNkbWEgdjQgc3RhcnR1cCB1bmRlciBTUklPVgo+Pgo+PiBIaSBNb25rLAo+Pgo+PiBBVVRP X0NUWFNXX0VOQUJMRSBpcyBub3QgcmVsZXZhbnQgdG8gd29ybGRzd2l0Y2ggcHJlZW1wdGlvbi4g aXQgb25seSBhcHBsaWVzIGZvciByaW5nIGJ1ZmZlciBwcmVlbXB0aW9uLiBTRE1BIHdpbGwgZG8g d29ybGRzd2l0Y2ggd2hhdGV2ZXIgQVVUT19DVFhTV19FTkFCTEUgaXMgMSBvciAwLgo+Pgo+PiAt LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+PiBGcm9tOiBMaXUsIE1vbmsKPj4gU2VudDogV2Vk bmVzZGF5LCBPY3RvYmVyIDEwLCAyMDE4IDI6NTQgUE0KPj4gVG86IEtvZW5pZywgQ2hyaXN0aWFu IDxDaHJpc3RpYW4uS29lbmlnQGFtZC5jb20+OyBIdWFuZywgUmF5IDxSYXkuSHVhbmdAYW1kLmNv bT47IE1pbiwgRnJhbmsgPEZyYW5rLk1pbkBhbWQuY29tPjsgTWEsIFNpZ2lsIDxTaWdpbC5NYUBh bWQuY29tPgo+PiBDYzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gU3ViamVjdDog UkU6IFtQQVRDSCAyLzhdIGRybS9hbWRncHU6IGZpeCBzZG1hIHY0IHN0YXJ0dXAgdW5kZXIgU1JJ T1YKPj4KPj4gT2gsIHRoYXQgbWVhbiBJIHJlbWVtYmVyIGl0IHJldmVyc2VkIHdheSwgYWNjb3Jk aW5nIHRvIGNvZGUgbG9va3Mgd2UgbmVlZCB0byBlbmFibGUgY3R4X3N3aXRjaCB0byBzdXBwb3J0 IFdPUkxEIFNXSVRDSCBmb3IgU0RNQSBlbmdpbmUKPj4KPj4gQnV0IGJldHRlciBsZXQgU2lnaWwg Y29uZmlybSBpdCAgLi4uCj4+Cj4+IEhpIEBNYSwgU2lnaWwgY2FuIHlvdSBjb25maXJtIGl0ID8g d2hhdCdzIHRoZSByZWxhdGlvbnNoaXAgYmV0d2VlbiBjdHhfc3dpY2ggYW5kIHdvcmxkIHN3aWNo IGZvciBTRE1BIGVuZ2luZXMgPwo+Pgo+PiBDdHhfc3dpdGNoX2VuYWJsZSgpIHdpbGwgc2V0ICJT RE1BMC8xX0NOVEwncyBmaWVsZDogQVVUT19DVFhTV19FTkFCTEUiIHRvIDEsIGNhbiB5b3UgdGVs bCB1cyB3aGF0J3MgaXQgZm9yIGFuZCBob3cgaXQgZ28gd2l0aCBTUklPViB3b3JsZCBzd2l0Y2gg Pwo+Pgo+PiBUaGFua3MKPj4KPj4gL01vbmsKPj4KPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0t LS0KPj4gRnJvbTogS29lbmlnLCBDaHJpc3RpYW4KPj4gU2VudDogVHVlc2RheSwgT2N0b2JlciA5 LCAyMDE4IDk6MDMgUE0KPj4gVG86IExpdSwgTW9uayA8TW9uay5MaXVAYW1kLmNvbT47IEh1YW5n LCBSYXkgPFJheS5IdWFuZ0BhbWQuY29tPjsgTWluLCBGcmFuayA8RnJhbmsuTWluQGFtZC5jb20+ OyBNYSwgU2lnaWwgPFNpZ2lsLk1hQGFtZC5jb20+Cj4+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+PiBTdWJqZWN0OiBSZTogW1BBVENIIDIvOF0gZHJtL2FtZGdwdTogZml4IHNk bWEgdjQgc3RhcnR1cCB1bmRlciBTUklPVgo+Pgo+PiBIaSBNb25rLAo+Pgo+PiB3ZWxsIHRoYXQg ZG9lc24ndCBtYWtlIG11Y2ggc2Vuc2UgdG8gbWUgd2hhdCB5b3Ugc2F5IGhlcmUgY2F1c2UgY29u dGV4dCBzd2l0Y2hpbmcgY2VydGFpbmx5IGlzIGFscmVhZHkgZW5hYmxlZCB1bmRlciBTUklPVjoK Pj4KPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChhbWRncHVfc3Jpb3ZfdmYo YWRldikpIHsgLyogYmFyZS1tZXRhbCBzZXF1ZW5jZQo+Pj4gZG9lc24ndCBuZWVkIGJlbG93IHRv IGxpbmVzICovCj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgc2RtYV92NF8wX2N0eF9zd2l0Y2hfZW5hYmxlKGFkZXYsIHRydWUpOwo+Pj4gLcKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNkbWFfdjRfMF9lbmFibGUoYWRl diwgdHJ1ZSk7Cj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9Cj4+IFRoZSBwcm9i bGVtIGlzIHRoYXQgY29udGV4dCBzd2l0Y2hpbmcgYXMgd2VsbCBhcyB0aGUgZ2Z4IHJpbmcgaXMg ZW5hYmxlZCBmb3IgYm90aCBTRE1BMCBhbmQgU0RNQTEgd2l0aG91dCBpbml0aWFsaXppbmcgU0RN QTEuCj4+Cj4+IFRoYXQncyBtb3N0IGxpa2VseSBjYXVzaW5nIHNvbWUgdW53YW50ZWQgY29uc2Vx dWVuY2VzLgo+Pgo+PiBDaHJpc3RpYW4uCj4+Cj4+IEFtIDA5LjEwLjIwMTggdW0gMTM6NDUgc2No cmllYiBMaXUsIE1vbms6Cj4+PiBDb250ZXh0IHN3aXRjaCBpcyBmb3IgcHJlZW1wdGlvbiBhY3Jv c3MgZGlmZmVyZW50IHF1ZXVlcyAoZ2Z4LCBybGMwLzEsCj4+PiBwYWdlKSB1bmRlciBiYXJlLW1l dGFsIGVudmlyb25tZW50LCBGb3IgU1JJT1Ygd2UgZGlkbid0IG5lZWQgaXQgYW5kIHdlIGRpZG4n dCB0ZXN0IGl0IHlldCwgc28gd2UganVzdCBkaXNhYmxlIGl0IHRvIG1ha2UgbGlmZSBlYXNpZXIs IGJlc2lkZXMgc2luY2UgZWFjaCBWRiBzaGFyZSBvbmx5IDYgTVMgc2xpY2UgdGhlcmUgaXMgaW4g ZmFjdCBubyBiZW5lZml0IHRvIGVuYWJsZSBpdCBmb3IgU1JJT1YgLi4uCj4+Pgo+Pj4gKyBATWEs IFNpZ2lsIHRvIGNvbmZpcm0KPj4+Cj4+PiBIaSBTaWdpbAo+Pj4KPj4+IERvIHlvdSB0aGluayBj b250ZXh0IHN3aXRjaCBjb3VsZCBiZSBlbmFibGVkIGZvciBTUklPViBWRiA/PyBJIHdvcnJ5IHRo YXQgdGhlIGNvbnRleHQgc3dpdGNoIGhhdmUgaW50ZXJuYWwgY3J1c2ggd2l0aCBwcmVlbXB0aW9u IGZvciB3b3JsZCBzd2l0Y2ggLCB0aGFua3MgIQo+Pj4KPj4+IC9Nb25rCj4+Pgo+Pj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4+IEZyb206IENocmlzdGlhbiBLw7ZuaWcgPGNrb2VuaWcu bGVpY2h0enVtZXJrZW5AZ21haWwuY29tPgo+Pj4gU2VudDogVHVlc2RheSwgT2N0b2JlciA5LCAy MDE4IDY6NTcgUE0KPj4+IFRvOiBIdWFuZywgUmF5IDxSYXkuSHVhbmdAYW1kLmNvbT47IExpdSwg TW9uayA8TW9uay5MaXVAYW1kLmNvbT47IE1pbiwKPj4+IEZyYW5rIDxGcmFuay5NaW5AYW1kLmNv bT4KPj4+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+Pj4gU3ViamVjdDogUmU6 IFtQQVRDSCAyLzhdIGRybS9hbWRncHU6IGZpeCBzZG1hIHY0IHN0YXJ0dXAgdW5kZXIgU1JJT1YK Pj4+Cj4+PiBBbSAwOS4xMC4yMDE4IHVtIDExOjE3IHNjaHJpZWIgSHVhbmcgUnVpOgo+Pj4+IE9u IE1vbiwgT2N0IDA4LCAyMDE4IGF0IDAzOjM1OjE1UE0gKzAyMDAsIENocmlzdGlhbiBLw7ZuaWcg d3JvdGU6Cj4+Pj4+IFtTTklQXQo+Pj4+PiAtCWlmIChhZGV2LT5maXJtd2FyZS5sb2FkX3R5cGUg IT0gQU1ER1BVX0ZXX0xPQURfUFNQKSB7Cj4+Pj4+IC0JCXIgPSBzZG1hX3Y0XzBfbG9hZF9taWNy b2NvZGUoYWRldik7Cj4+Pj4+ICsJLyogc3RhcnQgdGhlIGdmeCByaW5ncyBhbmQgcmxjIGNvbXB1 dGUgcXVldWVzICovCj4+Pj4+ICsJZm9yIChpID0gMDsgaSA8IGFkZXYtPnNkbWEubnVtX2luc3Rh bmNlczsgaSsrKQo+Pj4+PiArCQlzZG1hX3Y0XzBfZ2Z4X3Jlc3VtZShhZGV2LCBpKTsKPj4+Pj4g Kwo+Pj4+PiArCWlmIChhbWRncHVfc3Jpb3ZfdmYoYWRldikpIHsKPj4+Pj4gKwkJc2RtYV92NF8w X2N0eF9zd2l0Y2hfZW5hYmxlKGFkZXYsIHRydWUpOwo+Pj4+PiArCQlzZG1hX3Y0XzBfZW5hYmxl KGFkZXYsIHRydWUpOwo+Pj4+PiArCX0gZWxzZSB7Cj4+Pj4+ICsJCXIgPSBzZG1hX3Y0XzBfcmxj X3Jlc3VtZShhZGV2KTsKPj4+Pj4gICAgICAJCWlmIChyKQo+Pj4+PiAgICAgIAkJCXJldHVybiBy Owo+Pj4+PiAgICAgIAl9Cj4+Pj4gKyBNb25rLCBGcmFuaywKPj4+Pgo+Pj4+IEkgcHJvYmFibHkg Y2Fubm90IGp1ZGdlIGhlcmUsIHVuZGVyIFNSSU9WLCBJIHNhdyB5b3UgZGlzYWJsZSBjdHgKPj4+ PiBzd2l0Y2ggYmVmb3JlLiBEbyB5b3UgaGF2ZSBhbnkgY29uY2VybiBpZiB3ZSBlbmFibGVkIGl0 IGhlcmUuCj4+PiBUaGUgcHJvYmxlbSB3YXMgdGhhdCB0aG9zZSBjYWxscyB3aGVyZSBtaXhlZCBp bnRvIHNkbWFfdjRfMF9nZnhfcmVzdW1lKCkgZm9yIHRoZSBmaXJzdCBTRE1BIGluc3RhbmNlLgo+ Pj4KPj4+IFdoYXQgd2FzIGhhcHBlbmluZyBpcyB0aGF0IFNETUEwIHdhcyBpbml0aWFsaXplZCBh bmQgd2hpbGUgZG9pbmcgc28gZW5hYmxlZCBib3RoIFNETUEwIGFuZCBTRE1BMS4gU28gU0RNQTEg d2FzIHN0YXJ0aW5nIHVwIGJlZm9yZSB0aGUgcmluZyBidWZmZXIgd2FzIGV2ZW4gc2V0Lgo+Pj4K Pj4+IFRoYXQgdGhpcyBkb2Vzbid0IGNyYXNoZWQgd2FzIHB1cmUgY29pbmNpZGVudCBhbmQgaXMg bW9zdCBsaWtlbHkgYWxzbyB0aGUgcmVhc29uIHdoeSB3ZSByYW4gaW50byBwcm9ibGVtcyB3aGVu IHJpbmcgYnVmZmVycyB3ZXJlbid0IGluaXRpYWxpemVkLgo+Pj4KPj4+IFJlZ2FyZHMsCj4+PiBD aHJpc3RpYW4uCj4+Pgo+Pj4+IE90aGVycywgbG9va3MgZ29vZCBmb3IgbWUuIENocmlzdGlhbiwg bWF5IHdlIGtub3cgd2hpY2gga2luZCBvZiBqb2JzCj4+Pj4gd2lsbCB1c2Ugc2RtYSBwYWdlIHF1 ZXVlKHJpbmcpLCB5b3Uga25vdywgd2UganVzdCBzZG1hIGdmeCBxdWV1ZShyaW5nKSBiZWZvcmU/ Cj4+Pj4KPj4+PiBUaGFua3MsCj4+Pj4gUmF5Cj4+Pj4KPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v YW1kLWdmeAo=