From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED9D4C54E94 for ; Wed, 25 Jan 2023 08:30:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A1B8810E755; Wed, 25 Jan 2023 08:30:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D7EE10E753 for ; Wed, 25 Jan 2023 08:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674635446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kr0S8akD6qUBjK/SM2fF6lu+0ihmEwSHU9fQtaMUMNo=; b=a226Pt8ipebt2JExWTP+yldLIG1Lfl899UTZS7iA+3dVwvply0S76b4deLn347wh3ffLg3 FsVELr1/d5UqE5GhUfIcrwF27va0xHyx4GLfne/lmMhnCfBSwjUAZgZ0IJtiEnv4SSSY5I cubzDy99jzk9z/pK3MHql3yjuGms5x8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-102-xfbOr0rKPUWpGCS_KgqLmA-1; Wed, 25 Jan 2023 03:30:45 -0500 X-MC-Unique: xfbOr0rKPUWpGCS_KgqLmA-1 Received: by mail-wm1-f72.google.com with SMTP id bg25-20020a05600c3c9900b003da1f6a7b2dso736276wmb.1 for ; Wed, 25 Jan 2023 00:30:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kr0S8akD6qUBjK/SM2fF6lu+0ihmEwSHU9fQtaMUMNo=; b=28BzRTEwmFC98dBWfpd5XzPkX7+yfl3UxsoaLsMd0UmPnuygqqc2KPAoXIjs2IlcHU IPqLfhmHXk6w0mr94ZX8a6zxVtKGw0Zfn9AQPH4icWNL2VjZ7MEyMkA8dpMQOCP/yCKt 1gI9MltOGqYdpj49ncabeQSyVYEpBe1TWGqvBvpDw9AIWtPBugx6JbJdMwd9Vx6eK9d2 EFpEf1Iq3KyPykTOXqbNBWHA4aMoCX+mf9c2Vw+zx55t6YluuNcIZ0L80tit9Y6D10GF 9ibksoI0T4+knogarkzNC84v9K+nKSUIxqf/N6Jb7mL5AwS4f6XynQsaln2ZBjeJpI1f /ybA== X-Gm-Message-State: AFqh2koW1Blv68yXbJHRc3hbt5SDZUcnG/P4A2pg6PyMy4aqKQB1zweo GTTMYYMtmB3m3s3JSskaloknl41XD2EvTN6WlIVUUSc7ak72DPuzGAaXlRA7imAX2uMjBny6Aod 2bIdXD+ld187JygWa9zqNzValjw== X-Received: by 2002:a05:6000:388:b0:2bc:7ec3:8b2 with SMTP id u8-20020a056000038800b002bc7ec308b2mr29736122wrf.68.1674635444580; Wed, 25 Jan 2023 00:30:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXvJXEPl3F4VP/2Wui1NMuiLkn1RDtzF7t2lLspd9Qgz+v3EiIOxwRmTCt+QhhFH4DIAkfWI6g== X-Received: by 2002:a05:6000:388:b0:2bc:7ec3:8b2 with SMTP id u8-20020a056000038800b002bc7ec308b2mr29736083wrf.68.1674635444065; Wed, 25 Jan 2023 00:30:44 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id n17-20020a5d67d1000000b002425be3c9e2sm3716862wrw.60.2023.01.25.00.30.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 00:30:43 -0800 (PST) Message-ID: <296bcff0-9d75-3d6b-e101-dddb26edadf1@redhat.com> Date: Wed, 25 Jan 2023 09:30:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 01/10] drm/client: Test for connectors before sending hotplug event To: Thomas Zimmermann , airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org References: <20230124134010.30263-1-tzimmermann@suse.de> <20230124134010.30263-2-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20230124134010.30263-2-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hello Thomas, On 1/24/23 14:40, Thomas Zimmermann wrote: > Test for connectors in the client code and remove a similar test > from the generic fbdev emulation. Do nothing if the test fails. > Not having connectors indicates a driver bug. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas but I've a question below. > drivers/gpu/drm/drm_client.c | 5 +++++ > drivers/gpu/drm/drm_fbdev_generic.c | 5 ----- > 2 files changed, 5 insertions(+), 5 deletions(-) [...] > --- a/drivers/gpu/drm/drm_fbdev_generic.c > +++ b/drivers/gpu/drm/drm_fbdev_generic.c > @@ -389,11 +389,6 @@ static int drm_fbdev_client_hotplug(struct drm_client_dev *client) > if (dev->fb_helper) > return drm_fb_helper_hotplug_event(dev->fb_helper); > > - if (!dev->mode_config.num_connector) { > - drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n"); > - return 0; > - } > - What about the following code snippet: if (!drm_drv_uses_atomic_modeset(dev)) drm_helper_disable_unused_functions(dev); that seems to be something that should be in the core client dev hotplug as well, since it isn't specific to the fbdev emulation client ? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat