From: "Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
To: Mario Kleiner <mario.kleiner.de@gmail.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com
Subject: Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-8/10/11.
Date: Mon, 4 Jan 2021 16:17:22 -0500 [thread overview]
Message-ID: <2b1f7e42-bc31-824c-387d-0b08193b6a67@amd.com> (raw)
In-Reply-To: <20201228185059.3949-3-mario.kleiner.de@gmail.com>
On 2020-12-28 1:50 p.m., Mario Kleiner wrote:
> The hw supports fp16, this is not only useful for HDR,
> but also for standard dynamic range displays, because
> it allows to get more precise color reproduction with
> about 11 - 12 bpc linear precision in the unorm range
> 0.0 - 1.0.
>
> Working fp16 scanout+display (and HDR over HDMI) was
> verified on a DCE-8 asic, so i assume that the more
> recent DCE-10/11 will work equally well, now that
> format-specific plane scaling constraints are properly
> enforced, e.g., the inability of fp16 to scale on older
> hw like DCE-8 to DCE-11.
>
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Regards,
Nicholas Kazlauskas
> ---
> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> index 8ab9d6c79808..f20ed05a5050 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> @@ -385,7 +385,7 @@ static const struct dc_plane_cap plane_cap = {
> .pixel_format_support = {
> .argb8888 = true,
> .nv12 = false,
> - .fp16 = false
> + .fp16 = true
> },
>
> .max_upscale_factor = {
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index 3f63822b8e28..af208f9bd03b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
> .pixel_format_support = {
> .argb8888 = true,
> .nv12 = false,
> - .fp16 = false
> + .fp16 = true
> },
>
> .max_upscale_factor = {
> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> index 390a0fa37239..26fe25caa281 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> @@ -402,7 +402,7 @@ static const struct dc_plane_cap plane_cap = {
> .pixel_format_support = {
> .argb8888 = true,
> .nv12 = false,
> - .fp16 = false
> + .fp16 = true
> },
>
> .max_upscale_factor = {
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-04 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 18:50 Enable fp16 display support for DCE8+, next try Mario Kleiner
2020-12-28 18:50 ` [PATCH 1/2] drm/amd/display: Check plane scaling against format specific hw plane caps Mario Kleiner
2021-01-04 21:16 ` Kazlauskas, Nicholas
2020-12-28 18:50 ` [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-8/10/11 Mario Kleiner
2021-01-04 21:17 ` Kazlauskas, Nicholas [this message]
2021-01-04 21:31 ` Alex Deucher
2021-01-04 17:16 ` Enable fp16 display support for DCE8+, next try Alex Deucher
2021-01-21 6:22 ` Mario Kleiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b1f7e42-bc31-824c-387d-0b08193b6a67@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=mario.kleiner.de@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox