From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: remove unused parameter for va update Date: Tue, 12 Jun 2018 09:02:11 +0200 Message-ID: <2ce5bafd-80f4-ca07-69a8-f105cf2c9e8f@gmail.com> References: <1528783264-3582-1-git-send-email-Jerry.Zhang@amd.com> <79f96c2f-ca73-0180-929c-33893c7be28b@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0324788653==" Return-path: In-Reply-To: <79f96c2f-ca73-0180-929c-33893c7be28b-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: zhoucm1 , Junwei Zhang , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org This is a multi-part message in MIME format. --===============0324788653== Content-Type: multipart/alternative; boundary="------------1D95457BB08D9081F7CE40BF" Content-Language: en-US This is a multi-part message in MIME format. --------------1D95457BB08D9081F7CE40BF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Am 12.06.2018 um 08:38 schrieb zhoucm1: > > > > On 2018年06月12日 14:01, Junwei Zhang wrote: >> Don't need validation list any more >> >> Signed-off-by: Junwei Zhang > Reviewed-by: Chunming Zhou Reviewed-by: Christian König > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >> index 5fb156a..eff716d 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >> @@ -510,7 +510,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data, >> * @adev: amdgpu_device pointer >> * @vm: vm to update >> * @bo_va: bo_va to update >> - * @list: validation list >> * @operation: map, unmap or clear >> * >> * Update the bo_va directly after setting its address. Errors are not >> @@ -519,7 +518,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data, >> static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev, >> struct amdgpu_vm *vm, >> struct amdgpu_bo_va *bo_va, >> - struct list_head *list, >> uint32_t operation) >> { >> int r; >> @@ -673,7 +671,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data, >> break; >> } >> if (!r && !(args->flags & AMDGPU_VM_DELAY_UPDATE) && !amdgpu_vm_debug) >> - amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va, &list, >> + amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va, >> args->operation); >> >> error_backoff: > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx --------------1D95457BB08D9081F7CE40BF Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
Am 12.06.2018 um 08:38 schrieb zhoucm1:



On 2018年06月12日 14:01, Junwei Zhang wrote:
Don't need validation list any more

Signed-off-by: Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
Reviewed-by: Chunming Zhou <david1.zhou-5C7GfCeVMHo@public.gmane.org>

Reviewed-by: Christian König <christian.koenig-5C7GfCeVMHo@public.gmane.org>


---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 5fb156a..eff716d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -510,7 +510,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
  * @adev: amdgpu_device pointer
  * @vm: vm to update
  * @bo_va: bo_va to update
- * @list: validation list
  * @operation: map, unmap or clear
  *
  * Update the bo_va directly after setting its address. Errors are not
@@ -519,7 +518,6 @@ int amdgpu_gem_metadata_ioctl(struct drm_device *dev, void *data,
 static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
 				    struct amdgpu_vm *vm,
 				    struct amdgpu_bo_va *bo_va,
-				    struct list_head *list,
 				    uint32_t operation)
 {
 	int r;
@@ -673,7 +671,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data,
 		break;
 	}
 	if (!r && !(args->flags & AMDGPU_VM_DELAY_UPDATE) && !amdgpu_vm_debug)
-		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va, &list,
+		amdgpu_gem_va_update_vm(adev, &fpriv->vm, bo_va,
 					args->operation);
 
 error_backoff:




_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

--------------1D95457BB08D9081F7CE40BF-- --===============0324788653== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============0324788653==--