amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Felix Kuehling" <felix.kuehling-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: When to kmap PT BOs?
Date: Thu, 30 Aug 2018 08:50:54 +0200	[thread overview]
Message-ID: <2e37a1ff-501e-f097-2d0f-9d1e2486593c@gmail.com> (raw)
In-Reply-To: <7a9aa339-e771-c667-4eb8-6f30c7c37c15-5C7GfCeVMHo@public.gmane.org>

Hi Felix,

ah, crap you are right.

I moved the kmap to amdgpu_vm_update_directories() because I thought 
that it would be cleaner to have that closer where it is used.

But that sounds like it doesn't work as intended. Going to revert that 
patch.

Thanks,
Christian.

Am 30.08.2018 um 00:30 schrieb Felix Kuehling:
> Hi,
>
> Currently PT BOs are kmapped in amdgpu_vm_update_directories. That
> means, to avoid kernel oopses after page table evictions, I need to call
> amdgpu_vm_update_directories before calling amdgpu_vm_bo_update.
>
> But amdgpu_vm_bo_update can also move PTs on the vm->relocated list
> during huge page handling. That means I also need to call
> amdgpu_vm_update_directories after amdgpu_vm_bo_update.
>
> I think a better solution is to move kmapping out of
> amdgpu_vm_update_directories. But I'm not sure what's the right place
> for it. Any suggestions? For a quick fix for kernel oopses after page
> table evictions in the ROCm 1.9 release I'll call
> amdgpu_vm_update_directories twice. If there are no new entries on the
> vm->relocated lists, the second call won't add much overhead anyway.
>
> Thanks,
>    Felix
>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2018-08-30  6:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 22:30 When to kmap PT BOs? Felix Kuehling
     [not found] ` <7a9aa339-e771-c667-4eb8-6f30c7c37c15-5C7GfCeVMHo@public.gmane.org>
2018-08-30  4:49   ` Zhang, Jerry (Junwei)
2018-08-30  6:50   ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e37a1ff-501e-f097-2d0f-9d1e2486593c@gmail.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=felix.kuehling-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).