From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kuehling, Felix" <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/2] drm/amdgpu: cleanup amdgpu_ih_process a bit more
Date: Thu, 31 Jan 2019 21:39:19 +0000
Message-ID: <2ea91ccb-8dc0-af1a-96cd-bc8a2f018b32@amd.com>
References: <20190124125256.9900-1-christian.koenig@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20190124125256.9900-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
Content-Language: en-US
Content-ID: <CF99C00C9CB2844481D70D30C905910A-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org>
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: =?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Yang, Philip" <Philip.Yang-5C7GfCeVMHo@public.gmane.org>

T24gMjAxOS0wMS0yNCA3OjUyIGEubS4sIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6DQo+IFJlbW92
ZSB0aGUgY2FsbGJhY2sgYW5kIGNhbGwgdGhlIGRpc3BhdGNoZXIgZGlyZWN0bHkuDQo+DQo+IFNp
Z25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4N
Cg0KVGhpcyBwYXRjaCBpcyBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhs
aW5nQGFtZC5jb20+DQoNCg0KPiAtLS0NCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h
bWRncHVfaWguYyAgfCAgNiArKy0tDQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k
Z3B1X2loLmggIHwgIDQgKy0tDQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1
X2lycS5jIHwgNDggKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQ0KPiAgIGRyaXZlcnMvZ3B1L2Ry
bS9hbWQvYW1kZ3B1L2FtZGdwdV9pcnEuaCB8ICAyICstDQo+ICAgNCBmaWxlcyBjaGFuZ2VkLCAy
MSBpbnNlcnRpb25zKCspLCAzOSBkZWxldGlvbnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9paC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h
bWRncHUvYW1kZ3B1X2loLmMNCj4gaW5kZXggZDBhNWRiNzc3YjZkLi4xYzUwYmUzYWI4YTkgMTAw
NjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9paC5jDQo+ICsr
KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9paC5jDQo+IEBAIC0xNDAsOSAr
MTQwLDcgQEAgdm9pZCBhbWRncHVfaWhfcmluZ19maW5pKHN0cnVjdCBhbWRncHVfZGV2aWNlICph
ZGV2LCBzdHJ1Y3QgYW1kZ3B1X2loX3JpbmcgKmloKQ0KPiAgICAqIEludGVycnVwdCBoYW5kZXIg
KFZJKSwgd2FsayB0aGUgSUggcmluZy4NCj4gICAgKiBSZXR1cm5zIGlycSBwcm9jZXNzIHJldHVy
biBjb2RlLg0KPiAgICAqLw0KPiAtaW50IGFtZGdwdV9paF9wcm9jZXNzKHN0cnVjdCBhbWRncHVf
ZGV2aWNlICphZGV2LCBzdHJ1Y3QgYW1kZ3B1X2loX3JpbmcgKmloLA0KPiAtCQkgICAgICB2b2lk
ICgqY2FsbGJhY2spKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LA0KPiAtCQkJCSAgICAgICBz
dHJ1Y3QgYW1kZ3B1X2loX3JpbmcgKmloKSkNCj4gK2ludCBhbWRncHVfaWhfcHJvY2VzcyhzdHJ1
Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgc3RydWN0IGFtZGdwdV9paF9yaW5nICppaCkNCj4gICB7
DQo+ICAgCXUzMiB3cHRyOw0KPiAgIA0KPiBAQCAtMTYyLDcgKzE2MCw3IEBAIGludCBhbWRncHVf
aWhfcHJvY2VzcyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgc3RydWN0IGFtZGdwdV9paF9y
aW5nICppaCwNCj4gICAJcm1iKCk7DQo+ICAgDQo+ICAgCXdoaWxlIChpaC0+cnB0ciAhPSB3cHRy
KSB7DQo+IC0JCWNhbGxiYWNrKGFkZXYsIGloKTsNCj4gKwkJYW1kZ3B1X2lycV9kaXNwYXRjaChh
ZGV2LCBpaCk7DQo+ICAgCQlpaC0+cnB0ciAmPSBpaC0+cHRyX21hc2s7DQo+ICAgCX0NCj4gICAN
Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9paC5oIGIv
ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2loLmgNCj4gaW5kZXggMWNjYjE4MzEz
ODJhLi4xMTNhMWJhMTNkNGEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k
Z3B1L2FtZGdwdV9paC5oDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw
dV9paC5oDQo+IEBAIC02OSw4ICs2OSw2IEBAIHN0cnVjdCBhbWRncHVfaWhfZnVuY3Mgew0KPiAg
IGludCBhbWRncHVfaWhfcmluZ19pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBzdHJ1
Y3QgYW1kZ3B1X2loX3JpbmcgKmloLA0KPiAgIAkJCXVuc2lnbmVkIHJpbmdfc2l6ZSwgYm9vbCB1
c2VfYnVzX2FkZHIpOw0KPiAgIHZvaWQgYW1kZ3B1X2loX3JpbmdfZmluaShzdHJ1Y3QgYW1kZ3B1
X2RldmljZSAqYWRldiwgc3RydWN0IGFtZGdwdV9paF9yaW5nICppaCk7DQo+IC1pbnQgYW1kZ3B1
X2loX3Byb2Nlc3Moc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0cnVjdCBhbWRncHVfaWhf
cmluZyAqaWgsDQo+IC0JCSAgICAgIHZvaWQgKCpjYWxsYmFjaykoc3RydWN0IGFtZGdwdV9kZXZp
Y2UgKmFkZXYsDQo+IC0JCQkJICAgICAgIHN0cnVjdCBhbWRncHVfaWhfcmluZyAqaWgpKTsNCj4g
K2ludCBhbWRncHVfaWhfcHJvY2VzcyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgc3RydWN0
IGFtZGdwdV9paF9yaW5nICppaCk7DQo+ICAgDQo+ICAgI2VuZGlmDQo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0v
YW1kL2FtZGdwdS9hbWRncHVfaXJxLmMNCj4gaW5kZXggOGJmYjNkYWI0NmY3Li5hZjRjM2IxYWYz
MjIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9pcnEu
Yw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfaXJxLmMNCj4gQEAg
LTEzMCwyOSArMTMwLDYgQEAgdm9pZCBhbWRncHVfaXJxX2Rpc2FibGVfYWxsKHN0cnVjdCBhbWRn
cHVfZGV2aWNlICphZGV2KQ0KPiAgIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZhZGV2LT5pcnEu
bG9jaywgaXJxZmxhZ3MpOw0KPiAgIH0NCj4gICANCj4gLS8qKg0KPiAtICogYW1kZ3B1X2lycV9j
YWxsYmFjayAtIGNhbGxiYWNrIGZyb20gdGhlIElIIHJpbmcNCj4gLSAqDQo+IC0gKiBAYWRldjog
YW1kZ3B1IGRldmljZSBwb2ludGVyDQo+IC0gKiBAaWg6IGFtZGdwdSBpaCByaW5nDQo+IC0gKg0K
PiAtICogQ2FsbGJhY2sgZnJvbSBJSCByaW5nIHByb2Nlc3NpbmcgdG8gaGFuZGxlIHRoZSBlbnRy
eSBhdCB0aGUgY3VycmVudCBwb3NpdGlvbg0KPiAtICogYW5kIGFkdmFuY2UgdGhlIHJlYWQgcG9p
bnRlci4NCj4gLSAqLw0KPiAtc3RhdGljIHZvaWQgYW1kZ3B1X2lycV9jYWxsYmFjayhzdHJ1Y3Qg
YW1kZ3B1X2RldmljZSAqYWRldiwNCj4gLQkJCQlzdHJ1Y3QgYW1kZ3B1X2loX3JpbmcgKmloKQ0K
PiAtew0KPiAtCXUzMiByaW5nX2luZGV4ID0gaWgtPnJwdHIgPj4gMjsNCj4gLQlzdHJ1Y3QgYW1k
Z3B1X2l2X2VudHJ5IGVudHJ5Ow0KPiAtDQo+IC0JZW50cnkuaXZfZW50cnkgPSAoY29uc3QgdWlu
dDMyX3QgKikmaWgtPnJpbmdbcmluZ19pbmRleF07DQo+IC0JYW1kZ3B1X2loX2RlY29kZV9pdihh
ZGV2LCAmZW50cnkpOw0KPiAtDQo+IC0JdHJhY2VfYW1kZ3B1X2l2KGloIC0gJmFkZXYtPmlycS5p
aCwgJmVudHJ5KTsNCj4gLQ0KPiAtCWFtZGdwdV9pcnFfZGlzcGF0Y2goYWRldiwgJmVudHJ5KTsN
Cj4gLX0NCj4gLQ0KPiAgIC8qKg0KPiAgICAqIGFtZGdwdV9pcnFfaGFuZGxlciAtIElSUSBoYW5k
bGVyDQo+ICAgICoNCj4gQEAgLTE3MCw3ICsxNDcsNyBAQCBpcnFyZXR1cm5fdCBhbWRncHVfaXJx
X2hhbmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQ0KPiAgIAlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq
YWRldiA9IGRldi0+ZGV2X3ByaXZhdGU7DQo+ICAgCWlycXJldHVybl90IHJldDsNCj4gICANCj4g
LQlyZXQgPSBhbWRncHVfaWhfcHJvY2VzcyhhZGV2LCAmYWRldi0+aXJxLmloLCBhbWRncHVfaXJx
X2NhbGxiYWNrKTsNCj4gKwlyZXQgPSBhbWRncHVfaWhfcHJvY2VzcyhhZGV2LCAmYWRldi0+aXJx
LmloKTsNCj4gICAJaWYgKHJldCA9PSBJUlFfSEFORExFRCkNCj4gICAJCXBtX3J1bnRpbWVfbWFy
a19sYXN0X2J1c3koZGV2LT5kZXYpOw0KPiAgIAlyZXR1cm4gcmV0Ow0KPiBAQCAtMTg4LDcgKzE2
NSw3IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9pcnFfaGFuZGxlX2loMShzdHJ1Y3Qgd29ya19zdHJ1
Y3QgKndvcmspDQo+ICAgCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gY29udGFpbmVyX29m
KHdvcmssIHN0cnVjdCBhbWRncHVfZGV2aWNlLA0KPiAgIAkJCQkJCSAgaXJxLmloMV93b3JrKTsN
Cj4gICANCj4gLQlhbWRncHVfaWhfcHJvY2VzcyhhZGV2LCAmYWRldi0+aXJxLmloMSwgYW1kZ3B1
X2lycV9jYWxsYmFjayk7DQo+ICsJYW1kZ3B1X2loX3Byb2Nlc3MoYWRldiwgJmFkZXYtPmlycS5p
aDEpOw0KPiAgIH0NCj4gICANCj4gICAvKioNCj4gQEAgLTIwMyw3ICsxODAsNyBAQCBzdGF0aWMg
dm9pZCBhbWRncHVfaXJxX2hhbmRsZV9paDIoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KPiAg
IAlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IGNvbnRhaW5lcl9vZih3b3JrLCBzdHJ1Y3Qg
YW1kZ3B1X2RldmljZSwNCj4gICAJCQkJCQkgIGlycS5paDJfd29yayk7DQo+ICAgDQo+IC0JYW1k
Z3B1X2loX3Byb2Nlc3MoYWRldiwgJmFkZXYtPmlycS5paDIsIGFtZGdwdV9pcnFfY2FsbGJhY2sp
Ow0KPiArCWFtZGdwdV9paF9wcm9jZXNzKGFkZXYsICZhZGV2LT5pcnEuaWgyKTsNCj4gICB9DQo+
ICAgDQo+ICAgLyoqDQo+IEBAIC0zOTQsMTQgKzM3MSwyMyBAQCBpbnQgYW1kZ3B1X2lycV9hZGRf
aWQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsDQo+ICAgICogRGlzcGF0Y2hlcyBJUlEgdG8g
SVAgYmxvY2tzLg0KPiAgICAqLw0KPiAgIHZvaWQgYW1kZ3B1X2lycV9kaXNwYXRjaChzdHJ1Y3Qg
YW1kZ3B1X2RldmljZSAqYWRldiwNCj4gLQkJCSBzdHJ1Y3QgYW1kZ3B1X2l2X2VudHJ5ICplbnRy
eSkNCj4gKwkJCSBzdHJ1Y3QgYW1kZ3B1X2loX3JpbmcgKmloKQ0KPiAgIHsNCj4gLQl1bnNpZ25l
ZCBjbGllbnRfaWQgPSBlbnRyeS0+Y2xpZW50X2lkOw0KPiAtCXVuc2lnbmVkIHNyY19pZCA9IGVu
dHJ5LT5zcmNfaWQ7DQo+ICsJdTMyIHJpbmdfaW5kZXggPSBpaC0+cnB0ciA+PiAyOw0KPiArCXN0
cnVjdCBhbWRncHVfaXZfZW50cnkgZW50cnk7DQo+ICsJdW5zaWduZWQgY2xpZW50X2lkLCBzcmNf
aWQ7DQo+ICAgCXN0cnVjdCBhbWRncHVfaXJxX3NyYyAqc3JjOw0KPiAgIAlib29sIGhhbmRsZWQg
PSBmYWxzZTsNCj4gICAJaW50IHI7DQo+ICAgDQo+ICsJZW50cnkuaXZfZW50cnkgPSAoY29uc3Qg
dWludDMyX3QgKikmaWgtPnJpbmdbcmluZ19pbmRleF07DQo+ICsJYW1kZ3B1X2loX2RlY29kZV9p
dihhZGV2LCAmZW50cnkpOw0KPiArDQo+ICsJdHJhY2VfYW1kZ3B1X2l2KGloIC0gJmFkZXYtPmly
cS5paCwgJmVudHJ5KTsNCj4gKw0KPiArCWNsaWVudF9pZCA9IGVudHJ5LmNsaWVudF9pZDsNCj4g
KwlzcmNfaWQgPSBlbnRyeS5zcmNfaWQ7DQo+ICsNCj4gICAJaWYgKGNsaWVudF9pZCA+PSBBTURH
UFVfSVJRX0NMSUVOVElEX01BWCkgew0KPiAgIAkJRFJNX0RFQlVHKCJJbnZhbGlkIGNsaWVudF9p
ZCBpbiBJVjogJWRcbiIsIGNsaWVudF9pZCk7DQo+ICAgDQo+IEBAIC00MTYsNyArNDAyLDcgQEAg
dm9pZCBhbWRncHVfaXJxX2Rpc3BhdGNoKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LA0KPiAg
IAkJCSAgY2xpZW50X2lkLCBzcmNfaWQpOw0KPiAgIA0KPiAgIAl9IGVsc2UgaWYgKChzcmMgPSBh
ZGV2LT5pcnEuY2xpZW50W2NsaWVudF9pZF0uc291cmNlc1tzcmNfaWRdKSkgew0KPiAtCQlyID0g
c3JjLT5mdW5jcy0+cHJvY2VzcyhhZGV2LCBzcmMsIGVudHJ5KTsNCj4gKwkJciA9IHNyYy0+ZnVu
Y3MtPnByb2Nlc3MoYWRldiwgc3JjLCAmZW50cnkpOw0KPiAgIAkJaWYgKHIgPCAwKQ0KPiAgIAkJ
CURSTV9FUlJPUigiZXJyb3IgcHJvY2Vzc2luZyBpbnRlcnJ1cHQgKCVkKVxuIiwgcik7DQo+ICAg
CQllbHNlIGlmIChyKQ0KPiBAQCAtNDI4LDcgKzQxNCw3IEBAIHZvaWQgYW1kZ3B1X2lycV9kaXNw
YXRjaChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwNCj4gICANCj4gICAJLyogU2VuZCBpdCB0
byBhbWRrZmQgYXMgd2VsbCBpZiBpdCBpc24ndCBhbHJlYWR5IGhhbmRsZWQgKi8NCj4gICAJaWYg
KCFoYW5kbGVkKQ0KPiAtCQlhbWRncHVfYW1ka2ZkX2ludGVycnVwdChhZGV2LCBlbnRyeS0+aXZf
ZW50cnkpOw0KPiArCQlhbWRncHVfYW1ka2ZkX2ludGVycnVwdChhZGV2LCBlbnRyeS5pdl9lbnRy
eSk7DQo+ICAgfQ0KPiAgIA0KPiAgIC8qKg0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2FtZC9hbWRncHUvYW1kZ3B1X2lycS5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k
Z3B1X2lycS5oDQo+IGluZGV4IGMyN2RlY2ZkYTQ5NC4uYzcxOGU5NGE1NWM5IDEwMDY0NA0KPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfaXJxLmgNCj4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2lycS5oDQo+IEBAIC0xMDgsNyArMTA4LDcg
QEAgaW50IGFtZGdwdV9pcnFfYWRkX2lkKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LA0KPiAg
IAkJICAgICAgdW5zaWduZWQgY2xpZW50X2lkLCB1bnNpZ25lZCBzcmNfaWQsDQo+ICAgCQkgICAg
ICBzdHJ1Y3QgYW1kZ3B1X2lycV9zcmMgKnNvdXJjZSk7DQo+ICAgdm9pZCBhbWRncHVfaXJxX2Rp
c3BhdGNoKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LA0KPiAtCQkJIHN0cnVjdCBhbWRncHVf
aXZfZW50cnkgKmVudHJ5KTsNCj4gKwkJCSBzdHJ1Y3QgYW1kZ3B1X2loX3JpbmcgKmloKTsNCj4g
ICBpbnQgYW1kZ3B1X2lycV91cGRhdGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0cnVj
dCBhbWRncHVfaXJxX3NyYyAqc3JjLA0KPiAgIAkJICAgICAgdW5zaWduZWQgdHlwZSk7DQo+ICAg
aW50IGFtZGdwdV9pcnFfZ2V0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBzdHJ1Y3QgYW1k
Z3B1X2lycV9zcmMgKnNyYywNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdm
eAo=