From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Nicolai_H=c3=a4hnle?= <nicolai.haehnle-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH v2 3/3] drm/amdgpu: Add plumbing for handling SQ EDC/ECC
 interrupts v2.
Date: Mon, 11 Jun 2018 16:46:19 +0200
Message-ID: <2ee2b022-15df-b934-31fe-26c0a602fd39@amd.com>
References: <1528409955-6956-1-git-send-email-andrey.grodzovsky@amd.com>
 <1528409955-6956-3-git-send-email-andrey.grodzovsky@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <1528409955-6956-3-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>
Content-Language: en-US
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Andrey Grodzovsky <andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: David Panariti <David.Panariti-5C7GfCeVMHo@public.gmane.org>

TG9va3MgZ29vZCB0byBtZS4gU2VyaWVzOgoKUmV2aWV3ZWQtYnk6IE5pY29sYWkgSMOkaG5sZSA8
bmljb2xhaS5oYWVobmxlQGFtZC5jb20+CgpPbiAwOC4wNi4yMDE4IDAwOjE5LCBBbmRyZXkgR3Jv
ZHpvdnNreSB3cm90ZToKPiBGcm9tOiBEYXZpZCBQYW5hcml0aSA8RGF2aWQuUGFuYXJpdGlAYW1k
LmNvbT4KPiAKPiBTUSBjYW4gZ2VuZXJhdGUgaW50ZXJydXB0cyBhbmQgaW5zdGFsbHMgdGhlIElT
UiB0bwo+IGhhbmRsZSB0aGUgU1EgaW50ZXJydXB0cy4KPiAKPiBBZGQgcGFyc2luZyBTUSBkYXRh
IGluIGludGVycnVwdCBoYW5kbGVyLgo+IAo+IHYyOgo+IFJlbW92ZSBDWiBvbmx5IGxpbWl0YXRp
b24uCj4gUmViYXNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhdmlkIFBhbmFyaXRpIDxEYXZpZC5Q
YW5hcml0aUBhbWQuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEFuZHJleSBHcm9kem92c2t5IDxhbmRy
ZXkuZ3JvZHpvdnNreUBhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn
cHUvZ2Z4X3Y4XzAuYyB8IDEwOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4g
ICAxIGZpbGUgY2hhbmdlZCwgMTA4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y4XzAuYyBiL2RyaXZl
cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OF8wLmMKPiBpbmRleCBiOTZkYzA4Li45ZTZmNGYy
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OF8wLmMKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjhfMC5jCj4gQEAgLTIwNTQsNiAr
MjA1NCwxNCBAQCBzdGF0aWMgaW50IGdmeF92OF8wX3N3X2luaXQodm9pZCAqaGFuZGxlKQo+ICAg
CWlmIChyKQo+ICAgCQlyZXR1cm4gcjsKPiAgIAo+ICsJLyogU1EgaW50ZXJydXB0cy4gKi8KPiAr
CXIgPSBhbWRncHVfaXJxX2FkZF9pZChhZGV2LCBBTURHUFVfSUhfQ0xJRU5USURfTEVHQUNZLCAy
MzksCj4gKwkJCSAgICAgICZhZGV2LT5nZnguc3FfaXJxKTsKPiArCWlmIChyKSB7Cj4gKwkJRFJN
X0VSUk9SKCJhbWRncHVfaXJxX2FkZCgpIGZvciBTUSBmYWlsZWQ6ICVkXG4iLCByKTsKPiArCQly
ZXR1cm4gcjsKPiArCX0KPiArCj4gICAJYWRldi0+Z2Z4LmdmeF9jdXJyZW50X3N0YXR1cyA9IEFN
REdQVV9HRlhfTk9STUFMX01PREU7Cj4gICAKPiAgIAlnZnhfdjhfMF9zY3JhdGNoX2luaXQoYWRl
dik7Cj4gQEAgLTUxMTksNiArNTEyNyw4IEBAIHN0YXRpYyBpbnQgZ2Z4X3Y4XzBfaHdfZmluaSh2
b2lkICpoYW5kbGUpCj4gICAKPiAgIAlhbWRncHVfaXJxX3B1dChhZGV2LCAmYWRldi0+Z2Z4LmNw
X2VjY19lcnJvcl9pcnEsIDApOwo+ICAgCj4gKwlhbWRncHVfaXJxX3B1dChhZGV2LCAmYWRldi0+
Z2Z4LnNxX2lycSwgMCk7Cj4gKwo+ICAgCS8qIGRpc2FibGUgS0NRIHRvIGF2b2lkIENQQyB0b3Vj
aCBtZW1vcnkgbm90IHZhbGlkIGFueW1vcmUgKi8KPiAgIAlmb3IgKGkgPSAwOyBpIDwgYWRldi0+
Z2Z4Lm51bV9jb21wdXRlX3JpbmdzOyBpKyspCj4gICAJCWdmeF92OF8wX2tjcV9kaXNhYmxlKCZh
ZGV2LT5nZngua2lxLnJpbmcsICZhZGV2LT5nZnguY29tcHV0ZV9yaW5nW2ldKTsKPiBAQCAtNTU1
Niw2ICs1NTY2LDE0IEBAIHN0YXRpYyBpbnQgZ2Z4X3Y4XzBfbGF0ZV9pbml0KHZvaWQgKmhhbmRs
ZSkKPiAgIAkJcmV0dXJuIHI7Cj4gICAJfQo+ICAgCj4gKwlyID0gYW1kZ3B1X2lycV9nZXQoYWRl
diwgJmFkZXYtPmdmeC5zcV9pcnEsIDApOwo+ICsJaWYgKHIpIHsKPiArCQlEUk1fRVJST1IoCj4g
KwkJCSJhbWRncHVfaXJxX2dldCgpIGZhaWxlZCB0byBnZXQgSVJRIGZvciBTUSwgcjogJWQuXG4i
LAo+ICsJCQlyKTsKPiArCQlyZXR1cm4gcjsKPiArCX0KPiArCj4gICAJYW1kZ3B1X2RldmljZV9p
cF9zZXRfcG93ZXJnYXRpbmdfc3RhdGUoYWRldiwKPiAgIAkJCQkJICAgICAgIEFNRF9JUF9CTE9D
S19UWVBFX0dGWCwKPiAgIAkJCQkJICAgICAgIEFNRF9QR19TVEFURV9HQVRFKTsKPiBAQCAtNjg0
Niw2ICs2ODY0LDMyIEBAIHN0YXRpYyBpbnQgZ2Z4X3Y4XzBfc2V0X2NwX2VjY19pbnRfc3RhdGUo
c3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiAr
c3RhdGljIGludCBnZnhfdjhfMF9zZXRfc3FfaW50X3N0YXRlKHN0cnVjdCBhbWRncHVfZGV2aWNl
ICphZGV2LAo+ICsJCQkJICAgICBzdHJ1Y3QgYW1kZ3B1X2lycV9zcmMgKnNvdXJjZSwKPiArCQkJ
CSAgICAgdW5zaWduZWQgaW50IHR5cGUsCj4gKwkJCQkgICAgIGVudW0gYW1kZ3B1X2ludGVycnVw
dF9zdGF0ZSBzdGF0ZSkKPiArewo+ICsJaW50IGVuYWJsZV9mbGFnOwo+ICsKPiArCXN3aXRjaCAo
c3RhdGUpIHsKPiArCWNhc2UgQU1ER1BVX0lSUV9TVEFURV9ESVNBQkxFOgo+ICsJCWVuYWJsZV9m
bGFnID0gMTsKPiArCQlicmVhazsKPiArCj4gKwljYXNlIEFNREdQVV9JUlFfU1RBVEVfRU5BQkxF
Ogo+ICsJCWVuYWJsZV9mbGFnID0gMDsKPiArCQlicmVhazsKPiArCj4gKwlkZWZhdWx0Ogo+ICsJ
CXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsKPiArCVdSRUczMl9GSUVMRChTUV9JTlRFUlJVUFRf
TVNHX0NUUkwsIFNUQUxMLAo+ICsJCSAgICAgZW5hYmxlX2ZsYWcpOwo+ICsKPiArCXJldHVybiAw
Owo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCBnZnhfdjhfMF9lb3BfaXJxKHN0cnVjdCBhbWRncHVf
ZGV2aWNlICphZGV2LAo+ICAgCQkJICAgIHN0cnVjdCBhbWRncHVfaXJxX3NyYyAqc291cmNlLAo+
ICAgCQkJICAgIHN0cnVjdCBhbWRncHVfaXZfZW50cnkgKmVudHJ5KQo+IEBAIC02OTAwLDcgKzY5
NDQsNjIgQEAgc3RhdGljIGludCBnZnhfdjhfMF9jcF9lY2NfZXJyb3JfaXJxKHN0cnVjdCBhbWRn
cHVfZGV2aWNlICphZGV2LAo+ICAgCQkJCSAgICAgc3RydWN0IGFtZGdwdV9pcnFfc3JjICpzb3Vy
Y2UsCj4gICAJCQkJICAgICBzdHJ1Y3QgYW1kZ3B1X2l2X2VudHJ5ICplbnRyeSkKPiAgIHsKPiAt
CURSTV9FUlJPUigiRUNDIGVycm9yIGRldGVjdGVkLiIpOwo+ICsJRFJNX0VSUk9SKCJDUCBFREMv
RUNDIGVycm9yIGRldGVjdGVkLiIpOwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBp
bnQgZ2Z4X3Y4XzBfc3FfaXJxKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICsJCQkgICBz
dHJ1Y3QgYW1kZ3B1X2lycV9zcmMgKnNvdXJjZSwKPiArCQkJICAgc3RydWN0IGFtZGdwdV9pdl9l
bnRyeSAqZW50cnkpCj4gK3sKPiArCXU4IGVuYywgc2VfaWQ7Cj4gKwljaGFyIHR5cGVbMjBdOwo+
ICsKPiArCS8qIFBhcnNlIGFsbCBmaWVsZHMgYWNjb3JkaW5nIHRvIFNRX0lOVEVSUlVQVCogcmVn
aXN0ZXJzICovCj4gKwllbmMgPSAoZW50cnktPnNyY19kYXRhWzBdID4+IDI2KSAmIDB4MzsKPiAr
CXNlX2lkID0gKGVudHJ5LT5zcmNfZGF0YVswXSA+PiAyNCkgJiAweDM7Cj4gKwo+ICsJc3dpdGNo
IChlbmMpIHsKPiArCQljYXNlIDA6Cj4gKwkJCURSTV9JTkZPKCJTUSBnZW5lcmFsIHB1cnBvc2Ug
aW50ciBkZXRlY3RlZDoiCj4gKwkJCQkJInNlX2lkICVkLCBpbW1lZF9vdmVyZmxvdyAlZCwgaG9z
dF9yZWdfb3ZlcmZsb3cgJWQsIgo+ICsJCQkJCSJob3N0X2NtZF9vdmVyZmxvdyAlZCwgY21kX3Rp
bWVzdGFtcCAlZCwiCj4gKwkJCQkJInJlZ190aW1lc3RhbXAgJWQsIHRocmVhZF90cmFjZV9idWZm
X2Z1bGwgJWQsIgo+ICsJCQkJCSJ3bHQgJWQsIHRocmVhZF90cmFjZSAlZC5cbiIsCj4gKwkJCQkJ
c2VfaWQsCj4gKwkJCQkJKGVudHJ5LT5zcmNfZGF0YVswXSA+PiA3KSAmIDB4MSwKPiArCQkJCQko
ZW50cnktPnNyY19kYXRhWzBdID4+IDYpICYgMHgxLAo+ICsJCQkJCShlbnRyeS0+c3JjX2RhdGFb
MF0gPj4gNSkgJiAweDEsCj4gKwkJCQkJKGVudHJ5LT5zcmNfZGF0YVswXSA+PiA0KSAmIDB4MSwK
PiArCQkJCQkoZW50cnktPnNyY19kYXRhWzBdID4+IDMpICYgMHgxLAo+ICsJCQkJCShlbnRyeS0+
c3JjX2RhdGFbMF0gPj4gMikgJiAweDEsCj4gKwkJCQkJKGVudHJ5LT5zcmNfZGF0YVswXSA+PiAx
KSAmIDB4MSwKPiArCQkJCQllbnRyeS0+c3JjX2RhdGFbMF0gJiAweDEKPiArCQkJCQkpOwo+ICsJ
CQlicmVhazsKPiArCQljYXNlIDE6Cj4gKwkJY2FzZSAyOgo+ICsKPiArCQkJaWYgKGVuYyA9PSAx
KQo+ICsJCQkJc3ByaW50Zih0eXBlLCAiaW5zdHJ1Y3Rpb24gaW50ciIpOwo+ICsJCQllbHNlCj4g
KwkJCQlzcHJpbnRmKHR5cGUsICJFREMvRUNDIGVycm9yIik7Cj4gKwo+ICsJCQlEUk1fSU5GTygK
PiArCQkJCSJTUSAlcyBkZXRlY3RlZDogIgo+ICsJCQkJCSJzZV9pZCAlZCwgY3VfaWQgJWQsIHNp
bWRfaWQgJWQsIHdhdmVfaWQgJWQsIHZtX2lkICVkXG4iLAo+ICsJCQkJCXR5cGUsIHNlX2lkLAo+
ICsJCQkJCShlbnRyeS0+c3JjX2RhdGFbMF0gPj4gMjApICYgMHhmLAo+ICsJCQkJCShlbnRyeS0+
c3JjX2RhdGFbMF0gPj4gMTgpICYgMHgzLAo+ICsJCQkJCShlbnRyeS0+c3JjX2RhdGFbMF0gPj4g
MTQpICYgMHhmLAo+ICsJCQkJCShlbnRyeS0+c3JjX2RhdGFbMF0gPj4gMTApICYgMHhmCj4gKwkJ
CQkJKTsKPiArCQkJYnJlYWs7Cj4gKwkJZGVmYXVsdDoKPiArCQkJRFJNX0VSUk9SKCJTUSBpbnZh
bGlkIGVuY29kaW5nIHR5cGVcbi4iKTsKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9Cj4gKwo+
ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gQEAgLTcxMDksNiArNzIwOCwxMSBAQCBzdGF0aWMg
Y29uc3Qgc3RydWN0IGFtZGdwdV9pcnFfc3JjX2Z1bmNzIGdmeF92OF8wX2NwX2VjY19lcnJvcl9p
cnFfZnVuY3MgPSB7Cj4gICAJLnByb2Nlc3MgPSBnZnhfdjhfMF9jcF9lY2NfZXJyb3JfaXJxLAo+
ICAgfTsKPiAgIAo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGFtZGdwdV9pcnFfc3JjX2Z1bmNzIGdm
eF92OF8wX3NxX2lycV9mdW5jcyA9IHsKPiArCS5zZXQgPSBnZnhfdjhfMF9zZXRfc3FfaW50X3N0
YXRlLAo+ICsJLnByb2Nlc3MgPSBnZnhfdjhfMF9zcV9pcnEsCj4gK307Cj4gKwo+ICAgc3RhdGlj
IHZvaWQgZ2Z4X3Y4XzBfc2V0X2lycV9mdW5jcyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikK
PiAgIHsKPiAgIAlhZGV2LT5nZnguZW9wX2lycS5udW1fdHlwZXMgPSBBTURHUFVfQ1BfSVJRX0xB
U1Q7Cj4gQEAgLTcxMjUsNiArNzIyOSw5IEBAIHN0YXRpYyB2b2lkIGdmeF92OF8wX3NldF9pcnFf
ZnVuY3Moc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAKPiAgIAlhZGV2LT5nZnguY3Bf
ZWNjX2Vycm9yX2lycS5udW1fdHlwZXMgPSAxOwo+ICAgCWFkZXYtPmdmeC5jcF9lY2NfZXJyb3Jf
aXJxLmZ1bmNzID0gJmdmeF92OF8wX2NwX2VjY19lcnJvcl9pcnFfZnVuY3M7Cj4gKwo+ICsJYWRl
di0+Z2Z4LnNxX2lycS5udW1fdHlwZXMgPSAxOwo+ICsJYWRldi0+Z2Z4LnNxX2lycS5mdW5jcyA9
ICZnZnhfdjhfMF9zcV9pcnFfZnVuY3M7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGdmeF92
OF8wX3NldF9ybGNfZnVuY3Moc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gCgpfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcg
bGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK