AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kuehling, Felix" <felix.kuehling@amd.com>
To: "Christian König" <christian.koenig@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: Support 52-bit PAs in ttm_place
Date: Wed, 13 May 2026 09:15:00 -0500	[thread overview]
Message-ID: <2efb0669-d0e8-4887-86ea-cf095e915689@amd.com> (raw)
In-Reply-To: <c113ce66-5712-4fc6-bbf2-45239a97f773@amd.com>

On 2026-05-13 03:08, Christian König wrote:
>
> On 5/13/26 00:31, Felix Kuehling wrote:
>> fpfn and lpfn in struct ttm_place are 32-bit page numbers. With 4KB page
>> size this can support up to 44-bit physical addressing. Grow these to
>> unsigned long to support larger physical addresses.
>>
>> Signed-off-by: Felix Kuehling <felix.kuehling@amd.com>
>> ---
>>   include/drm/ttm/ttm_placement.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/drm/ttm/ttm_placement.h b/include/drm/ttm/ttm_placement.h
>> index b510a4812609..3e88869c0f58 100644
>> --- a/include/drm/ttm/ttm_placement.h
>> +++ b/include/drm/ttm/ttm_placement.h
>> @@ -81,8 +81,8 @@
>>    * Structure indicating a possible place to put an object.
>>    */
>>   struct ttm_place {
>> -	unsigned	fpfn;
>> -	unsigned	lpfn;
>> +	unsigned long	fpfn;
>> +	unsigned long	lpfn;
> That should be uint64_t instead, long is CPU architecture dependent and we clearly don't want that in TTM.
>
> But apart from that looks reasonable to me.

Thanks. I sent out v2. What's the best branch for getting this change 
upstream? We'll need it on our NPI branch in the interim.

Regards,
   Felix


>
> Regards,
> Christian.
>
>>   	uint32_t	mem_type;
>>   	uint32_t	flags;
>>   };

  reply	other threads:[~2026-05-13 14:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 22:31 [PATCH] drm/ttm: Support 52-bit PAs in ttm_place Felix Kuehling
2026-05-13  8:08 ` Christian König
2026-05-13 14:15   ` Kuehling, Felix [this message]
2026-05-13 15:42     ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2efb0669-d0e8-4887-86ea-cf095e915689@amd.com \
    --to=felix.kuehling@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox