AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Zhu, James" <James.Zhu-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 1/3] drm/amdgpu/uvd:Add uvd enc session bo
Date: Wed, 16 Oct 2019 10:59:38 +0200	[thread overview]
Message-ID: <3198889b-9df5-dd90-0457-79a1a886ec4d@gmail.com> (raw)
In-Reply-To: <1571177279-9435-2-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org>

Am 16.10.19 um 00:08 schrieb Zhu, James:
> Add uvd enc session bo for uvd encode IB test.
>
> Signed-off-by: James Zhu <James.Zhu@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
> index 5eb6328..1e39c8a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h
> @@ -67,6 +67,10 @@ struct amdgpu_uvd {
>   	unsigned		harvest_config;
>   	/* store image width to adjust nb memory state */
>   	unsigned		decode_image_width;
> +
> +	struct amdgpu_bo *enc_session_bo;
> +	void			 *enc_session_cpu_addr;
> +	uint64_t		  enc_session_gpu_addr;

Please don't keep that allocated all the time, but rather only allocate 
it on demand during the IB test.

Regards,
Christian.

>   };
>   
>   int amdgpu_uvd_sw_init(struct amdgpu_device *adev);

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-10-16  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 22:08 [PATCH 0/3] Fixed amdgpu resume failure from suspend Zhu, James
     [not found] ` <1571177279-9435-1-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org>
2019-10-15 22:08   ` [PATCH 1/3] drm/amdgpu/uvd:Add uvd enc session bo Zhu, James
     [not found]     ` <1571177279-9435-2-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org>
2019-10-16  8:59       ` Christian König [this message]
     [not found]         ` <3198889b-9df5-dd90-0457-79a1a886ec4d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-10-16 13:01           ` James Zhu
2019-10-15 22:08   ` [PATCH 3/3] drm/amdgpu/uvd:Allocate enc session bo for uvd7.0 ring IB test Zhu, James
     [not found]     ` <1571177279-9435-4-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org>
2019-10-16  9:01       ` Christian König
2019-10-15 22:08   ` [PATCH 2/3] drm/amdgpu/uvd:Allocate enc session bo for uvd6.0 " Zhu, James
     [not found]     ` <1571177279-9435-3-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org>
2019-10-15 22:32       ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3198889b-9df5-dd90-0457-79a1a886ec4d@gmail.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=James.Zhu-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox