From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kuehling, Felix" Subject: Re: [PATCH 2/7] drm/amdgpu: rework shadow handling during PD clear Date: Wed, 20 Feb 2019 00:07:08 +0000 Message-ID: <3293bfe5-dae6-ebe2-e47e-db3d3d954c9e@amd.com> References: <20190219134103.1531-1-christian.koenig@amd.com> <20190219134103.1531-2-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190219134103.1531-2-christian.koenig-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US Content-ID: <00A59F9A2CC4364EB659A85B4A9111BC-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?utf-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Q29tbWVudHMgaW5saW5lLg0KDQpPbiAyMDE5LTAyLTE5IDg6NDAgYS5tLiwgQ2hyaXN0aWFuIEvD tm5pZyB3cm90ZToNCj4gVGhpcyB3YXkgd2Ugb25seSBkZWFsIHdpdGggdGhlIHJlYWwgQk8gaW4g aGVyZS4NCj4NCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtv ZW5pZ0BhbWQuY29tPg0KPiAtLS0NCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfdm0uYyB8IDY0ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tDQo+ICAgMSBmaWxlIGNoYW5n ZWQsIDM5IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfdm0uYw0KPiBpbmRleCAxMmQ1MWQ5NjQ5MWUuLjNjN2I5OGE3NThj OSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMN Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMNCj4gQEAgLTc4 OCwzOCArNzg4LDU4IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZtX2NsZWFyX2JvKHN0cnVjdCBhbWRn cHVfZGV2aWNlICphZGV2LA0KPiAgIA0KPiAgIAlyID0gdHRtX2JvX3ZhbGlkYXRlKCZiby0+dGJv LCAmYm8tPnBsYWNlbWVudCwgJmN0eCk7DQo+ICAgCWlmIChyKQ0KPiAtCQlnb3RvIGVycm9yOw0K PiArCQlyZXR1cm4gcjsNCj4gICANCj4gICAJciA9IGFtZGdwdV90dG1fYWxsb2NfZ2FydCgmYm8t PnRibyk7DQo+ICAgCWlmIChyKQ0KPiAgIAkJcmV0dXJuIHI7DQo+ICAgDQo+ICsJaWYgKGJvLT5z aGFkb3cpIHsNCj4gKwkJciA9IHR0bV9ib192YWxpZGF0ZSgmYm8tPnNoYWRvdy0+dGJvLCAmYm8t PnNoYWRvdy0+cGxhY2VtZW50LA0KPiArCQkJCSAgICAmY3R4KTsNCj4gKwkJaWYgKHIpDQo+ICsJ CQlyZXR1cm4gcjsNCj4gKw0KPiArCQlyID0gYW1kZ3B1X3R0bV9hbGxvY19nYXJ0KCZiby0+c2hh ZG93LT50Ym8pOw0KPiArCQlpZiAocikNCj4gKwkJCXJldHVybiByOw0KPiArDQo+ICsJfQ0KPiAr DQo+ICAgCXIgPSBhbWRncHVfam9iX2FsbG9jX3dpdGhfaWIoYWRldiwgNjQsICZqb2IpOw0KDQpJ IGd1ZXNzIHRoYXQncyBzdGlsbCBiaWcgZW5vdWdoIHRvIGZpdCA0IGluc3RlYWQgb2YgMiBTRE1B IGNvbW1hbmRzICgxMCANCmR3b3JkcyBlYWNoKS4NCg0KDQo+ICAgCWlmIChyKQ0KPiAtCQlnb3Rv IGVycm9yOw0KPiArCQlyZXR1cm4gcjsNCj4gICANCj4gLQlhZGRyID0gYW1kZ3B1X2JvX2dwdV9v ZmZzZXQoYm8pOw0KPiAtCWlmIChhdHNfZW50cmllcykgew0KPiAtCQl1aW50NjRfdCBhdHNfdmFs dWU7DQo+ICsJd2hpbGUgKDEpIHsNCj4gKwkJYWRkciA9IGFtZGdwdV9ib19ncHVfb2Zmc2V0KGJv KTsNCj4gKwkJaWYgKGF0c19lbnRyaWVzKSB7DQo+ICsJCQl1aW50NjRfdCBhdHNfdmFsdWU7DQo+ ICAgDQo+IC0JCWF0c192YWx1ZSA9IEFNREdQVV9QVEVfREVGQVVMVF9BVEM7DQo+IC0JCWlmIChs ZXZlbCAhPSBBTURHUFVfVk1fUFRCKQ0KPiAtCQkJYXRzX3ZhbHVlIHw9IEFNREdQVV9QREVfUFRF Ow0KPiArCQkJYXRzX3ZhbHVlID0gQU1ER1BVX1BURV9ERUZBVUxUX0FUQzsNCj4gKwkJCWlmIChs ZXZlbCAhPSBBTURHUFVfVk1fUFRCKQ0KPiArCQkJCWF0c192YWx1ZSB8PSBBTURHUFVfUERFX1BU RTsNCj4gICANCj4gLQkJYW1kZ3B1X3ZtX3NldF9wdGVfcGRlKGFkZXYsICZqb2ItPmlic1swXSwg YWRkciwgMCwNCj4gLQkJCQkgICAgICBhdHNfZW50cmllcywgMCwgYXRzX3ZhbHVlKTsNCj4gLQkJ YWRkciArPSBhdHNfZW50cmllcyAqIDg7DQo+IC0JfQ0KPiArCQkJYW1kZ3B1X3ZtX3NldF9wdGVf cGRlKGFkZXYsICZqb2ItPmlic1swXSwgYWRkciwgMCwNCj4gKwkJCQkJICAgICAgYXRzX2VudHJp ZXMsIDAsIGF0c192YWx1ZSk7DQo+ICsJCQlhZGRyICs9IGF0c19lbnRyaWVzICogODsNCj4gKwkJ fQ0KPiAgIA0KPiAtCWlmIChlbnRyaWVzKSB7DQo+IC0JCXVpbnQ2NF90IHZhbHVlID0gMDsNCj4g KwkJaWYgKGVudHJpZXMpIHsNCj4gKwkJCXVpbnQ2NF90IHZhbHVlID0gMDsNCj4gICANCj4gLQkJ LyogV29ya2Fyb3VuZCBmb3IgZmF1bHQgcHJpb3JpdHkgcHJvYmxlbSBvbiBHTUM5ICovDQo+IC0J CWlmIChsZXZlbCA9PSBBTURHUFVfVk1fUFRCICYmIGFkZXYtPmFzaWNfdHlwZSA+PSBDSElQX1ZF R0ExMCkNCj4gLQkJCXZhbHVlID0gQU1ER1BVX1BURV9FWEVDVVRBQkxFOw0KPiArCQkJLyogV29y a2Fyb3VuZCBmb3IgZmF1bHQgcHJpb3JpdHkgcHJvYmxlbSBvbiBHTUM5ICovDQo+ICsJCQlpZiAo bGV2ZWwgPT0gQU1ER1BVX1ZNX1BUQiAmJg0KPiArCQkJICAgIGFkZXYtPmFzaWNfdHlwZSA+PSBD SElQX1ZFR0ExMCkNCj4gKwkJCQl2YWx1ZSA9IEFNREdQVV9QVEVfRVhFQ1VUQUJMRTsNCj4gKw0K PiArCQkJYW1kZ3B1X3ZtX3NldF9wdGVfcGRlKGFkZXYsICZqb2ItPmlic1swXSwgYWRkciwgMCwN Cj4gKwkJCQkJICAgICAgZW50cmllcywgMCwgdmFsdWUpOw0KPiArCQl9DQo+ICAgDQo+IC0JCWFt ZGdwdV92bV9zZXRfcHRlX3BkZShhZGV2LCAmam9iLT5pYnNbMF0sIGFkZHIsIDAsDQo+IC0JCQkJ ICAgICAgZW50cmllcywgMCwgdmFsdWUpOw0KPiArCQlpZiAoYm8tPnNoYWRvdykNCj4gKwkJCWJv ID0gYm8tPnNoYWRvdzsNCj4gKwkJZWxzZQ0KPiArCQkJYnJlYWs7DQo+ICAgCX0NCg0KSW5zdGVh ZCBvZiBhIHdoaWxlKDEpIGVuZGxlc3MgbG9vcCwgdGhpcyBjb3VsZCBiZSB3cml0dGVuIGFzIGEg ZG8gLi4uIA0Kd2hpbGUgbG9vcCB3aXRoIGEgc2FuZSB0ZXJtaW5hdGlvbiBjb25kaXRpb24gbGlr ZSB0aGlzOg0KDQoJZG8gew0KCQkuLi4NCgkJYm8gPSBiby0+c2hhZG93Ow0KCX0gd2hpbGUgKGJv KTsNCg0KQXNzdW1pbmcgdGhhdCB5b3UgZG9uJ3QgbmVlZCAiYm8iIGFmdGVyIHRoaXMuIFlvdSBk byBiZWxvdywgYnV0IEkgdGhpbmsgDQp0aGF0J3MgYSBtaXN0YWtlIGFueXdheS4gU2VlIHRoZSBu ZXh0IGNvbW1lbnQuDQoNCj4gICANCj4gICAJYW1kZ3B1X3JpbmdfcGFkX2liKHJpbmcsICZqb2It Pmlic1swXSk7DQo+IEBAIC04MzgsMTYgKzg1OCwxMCBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9j bGVhcl9ibyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwNCj4gICAJYW1kZ3B1X2JvX2ZlbmNl KGJvLCBmZW5jZSwgdHJ1ZSk7DQoNCkhlcmUgeW91J2xsIG9ubHkgZmVuY2UgdGhlIHNoYWRvdyBC Ty4NCg0KUmVnYXJkcywNCiDCoCBGZWxpeA0KDQoNCj4gICAJZG1hX2ZlbmNlX3B1dChmZW5jZSk7 DQo+ICAgDQo+IC0JaWYgKGJvLT5zaGFkb3cpDQo+IC0JCXJldHVybiBhbWRncHVfdm1fY2xlYXJf Ym8oYWRldiwgdm0sIGJvLT5zaGFkb3csDQo+IC0JCQkJCSAgbGV2ZWwsIHB0ZV9zdXBwb3J0X2F0 cyk7DQo+IC0NCj4gICAJcmV0dXJuIDA7DQo+ICAgDQo+ICAgZXJyb3JfZnJlZToNCj4gICAJYW1k Z3B1X2pvYl9mcmVlKGpvYik7DQo+IC0NCj4gLWVycm9yOg0KPiAgIAlyZXR1cm4gcjsNCj4gICB9 DQo+ICAgDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwph bWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=