From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] gpu: drm: use struct_size() in kmalloc() Date: Tue, 21 May 2019 10:59:06 +0200 Message-ID: <36de7e05-9055-6d8b-fb2c-fa5a4e94274b@gmail.com> References: <1558082760-4915-1-git-send-email-xiaolinkui@kylinos.cn> <20190520162807.GE21222@phenom.ffwll.local> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Daniel Vetter , Alex Deucher Cc: "Zhou, David(ChunMing)" , "airlied-cv59FeDIM0c@public.gmane.org" , "Pan, Xinhui" , xiaolinkui , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Deucher, Alexander" , "Quan, Evan" , "Koenig, Christian" QW0gMjEuMDUuMTkgdW0gMDk6MjMgc2NocmllYiBEYW5pZWwgVmV0dGVyOgo+IE9uIFR1ZSwgTWF5 IDIxLCAyMDE5IGF0IDQ6MzMgQU0gQWxleCBEZXVjaGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5jb20+ IHdyb3RlOgo+PiBPbiBNb24sIE1heSAyMCwgMjAxOSBhdCA3OjE5IFBNIFBhbiwgWGluaHVpIDxY aW5odWkuUGFuQGFtZC5jb20+IHdyb3RlOgo+Pj4gRGFuaWVsLCB3aGF0IHlvdSBhcmUgdGFsa2lu ZyBhYm91dCBpcyB0b3RhbGx5IHdyb25nLgo+Pj4gMSkgQUZBSUssIG9ubHkgb25lIHplcm8tc2l6 ZSBhcnJheSBjYW4gYmUgaW4gdGhlIGVuZCBvZiBhIHN0cnVjdC4KPj4+IDIpIHR3byBzdHJ1Y3Rf c2l6ZSB3aWxsIGFkZCB1cCBzdHJ1Y3QgaXRzZWxmIHR3aWNlLiB0aGUgc3VtIGlzIHdyb25nIHRo ZW4uCj4+Pgo+Pj4gTm8gb2ZmZW5zZS4gSSBjYW4ndCBoZWxwIGZlZWxpbmcgbHVja3kgdGhhdCB5 b3UgYXJlIGluIGludGVsLgo+PiBYaW5odWksCj4+Cj4+IFBsZWFzZSBrZWVwIHRoaW5ncyBjaXZp bC4gIFRoZXJlIGlzIG5vIG5lZWQgZm9yIGNvbW1lbnRzIGxpa2UgdGhpcy4KPiBZZWFoLCB0aGlz IHdhcyBvdmVyIHRoZSBsaW5lLCB0aGFua3MgQWxleCBmb3IgYWxyZWFkeSB0YWtpbmcgY2FyZSBv Zgo+IHRoaXMuIFBsZWFzZSBub3RlIHRoYXQgZmQubyBtYWlsaW5nIGxpc3RzIG9wZXJhdGUgdW5k ZXIgYSBDb0M6Cj4KPiBodHRwczovL3d3dy5mcmVlZGVza3RvcC5vcmcvd2lraS9Db2RlT2ZDb25k dWN0LwoKU2Vjb25kZWQuIEkgYWxzbyBlbmpveSB0aGUgaHVtaWxpYXRpb24gb2Ygb3RoZXIgaW4g ZW1haWwsIGJ1dCBpdCBkb2Vzbid0IApoZWxwcyB1cyBnZXR0aW5nIGNvZGUgd3JpdHRlbiBhbmQg cHJvYmxlbXMgc29sdmVkIGluIGEgcHJvZmVzc2lvbmFsIAplbnZpcm9ubWVudC4KCj4gV3J0IHRo ZSB0ZWNobmljYWwgY29tbWVudDogSSBrbm93IHRoYXQgeW91IGNhbiBvbmx5IGRvIG9uZSB2YXJp YWJsZQo+IHNpemVkIGFycmF5LCBhbmQgaXQgbXVzdCBiZSBhdCB0aGUgZW5kLiBCdXQgeW91IGNh biBwdXQgbXVsdGlwbGUKPiBzdHJ1Y3R1cmVzIGFsbCB3aXRoaW4gdGhlIHNhbWUgYWxsb2NhdGlv bi4gV2hpY2ggaXMgd2hhdCBJIHRob3VnaHQgeW91Cj4gd2FudGVkIHRvIGRvLiBBbmQgbXkgc2tl dGNoIHdvdWxkIGFsbG93IHlvdSB0byBkbyB0aGF0IGV2ZW4gaWYgeW91Cj4gaGF2ZSBtdWx0aXBs ZSB2YXJpYWJsZSBsZW5ndGggc3RydWN0dXJlcyB5b3Ugd2FudCB0byBhbGxvY2F0ZS4gVGhlcmUn cwo+IHBsZW50eSBleGFtcGxlcyBvZiB0aGlzIChidXQgb3Blbi1jb2RlZCBvbmVzKSBpbiB0aGUg a2VybmVsLgoKQlRXOiBJcyB0aGVyZSBhY3R1YWxseSBnb29kIGRvY3VtZW50YXRpb24gaG93IHRv IGNvcnJlY3RseSBkbyB0aGUgCnZhcmlhYmxlIGxlbmd0aCBhcnJheSBhdCBlbmQgb2Ygc3RydWN0 dXJlIHRoaW5nIGluIHRoZSBrZXJuZWw/CgpJIGRvIGtub3cgdGhhdCBJJ3ZlIHNlZW4gYSBsb3Qg b2YgZGlmZmVyZW50IHZhcmlhbnRzIGxpa2UgYXJyYXlbXSAKYXJyYXlbMF0gb3IgYXJyYXlbMV0g YW5kIEkgaGF2ZSBhbHNvIHNlZW4gYSBidW5jaCBvZiBnY2MgdmVyc2lvbnMgCmZhaWxpbmcgdG8g Z2VuZXJhdGUgY29ycmVjdCBjb2RlIGZvciBzb21lIG9mIHRoZW0uCgpTbyB3ZSBzaG91bGQgcHJv YmFibHkgbmFpbCBkb3duIGhvdyB0byBkbyB0aGluZ3MgY29ycmVjdGx5LgoKPiBFeGNlcHQgaW4g cmVhbGx5IGhvdCBwYXRocyBJIHBlcnNvbmFsbHkgdGhpbmsgdGhhdCB0aGF0IGtpbmQgb2YKPiB0 cmlja2VyeSBpc24ndCB3b3J0aCBpdC4KCldlbGwgZm9yIGttYWxsb2MoKSBpdCdzIG5vdCB0aGF0 IG11Y2ggb3ZlcmhlYWQsIGJ1dCB3aXRoIHZtYWxsb2MgdGhhdCBpcyAKYSBjb21wbGV0ZWx5IGRp ZmZlcmVudCBwaWN0dXJlLgoKQ2hyaXN0aWFuLgoKPgo+IENoZWVycywgRGFuaWVsCj4KPj4gQWxl eAo+Pgo+Pj4KPj4+IOWPkeS7tuS6ujogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZnds bC5jaD4g5Luj6KGoIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPj4+IOWPkemAgeaX tumXtDogMjAxOeW5tDXmnIgyMeaXpSAwOjI4Cj4+PiDmlLbku7bkuro6IFBhbiwgWGluaHVpCj4+ PiDmioTpgIE6IERldWNoZXIsIEFsZXhhbmRlcjsgS29lbmlnLCBDaHJpc3RpYW47IFpob3UsIERh dmlkKENodW5NaW5nKTsgYWlybGllZEBsaW51eC5pZTsgZGFuaWVsQGZmd2xsLmNoOyBRdWFuLCBF dmFuOyB4aWFvbGlua3VpOyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwo+Pj4g 5Li76aKYOiBSZTogW1BBVENIXSBncHU6IGRybTogdXNlIHN0cnVjdF9zaXplKCkgaW4ga21hbGxv YygpCj4+Pgo+Pj4gW0NBVVRJT046IEV4dGVybmFsIEVtYWlsXQo+Pj4KPj4+IE9uIEZyaSwgTWF5 IDE3LCAyMDE5IGF0IDA0OjQ0OjMwUE0gKzAwMDAsIFBhbiwgWGluaHVpIHdyb3RlOgo+Pj4+IEkg YW0gZ29pbmcgdG8gcHV0IG1vcmUgbWVtYmVycyB3aGljaCBhcmUgYWxzbyBhcnJheSBhZnRlciB0 aGlzIHN0cnVjdCwKPj4+PiBub3Qgb25seSBvYmpbXS4gIExvb2tzIGxpa2UgdGhpcyBzdHJ1Y3Rf c2l6ZSBkaWQgbm90IGhlbHAgb24gbXVsdGlwbGUKPj4+PiBhcnJheSBjYXNlLiBUaGFua3MgYW55 d2F5LiAgX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4+IFlvdSBjYW4gdGhlbiBh ZGQgdGhlbSB1cCwgZS5nLiBrbWFsbG9jKHN0cnVjdF9zaXplKCkrc3RydWN0X3NpemUoKSwKPj4+ IEdGUF9LRVJORUwpLCBzbyB0aGlzIHBhdGNoIGhlcmUgc3RpbGwgbG9va3MgbGlrZSBhIGdvb2Qg aWRlYS4KPj4+Cj4+PiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KPj4+Cj4+PiBDaGVlcnMsIERhbmllbAo+Pj4KPj4+PiBGcm9tOiB4aWFvbGlua3Vp IDx4aWFvbGlua3VpQGt5bGlub3MuY24+Cj4+Pj4gU2VudDogRnJpZGF5LCBNYXkgMTcsIDIwMTkg NDo0NjowMCBQTQo+Pj4+IFRvOiBEZXVjaGVyLCBBbGV4YW5kZXI7IEtvZW5pZywgQ2hyaXN0aWFu OyBaaG91LCBEYXZpZChDaHVuTWluZyk7IGFpcmxpZWRAbGludXguaWU7IGRhbmllbEBmZndsbC5j aDsgUGFuLCBYaW5odWk7IFF1YW4sIEV2YW4KPj4+PiBDYzogYW1kLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmc7IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7IGxpbnV4LWtlcm5lbEB2 Z2VyLmtlcm5lbC5vcmc7IHhpYW9saW5rdWlAa3lsaW5vcy5jbgo+Pj4+IFN1YmplY3Q6IFtQQVRD SF0gZ3B1OiBkcm06IHVzZSBzdHJ1Y3Rfc2l6ZSgpIGluIGttYWxsb2MoKQo+Pj4+Cj4+Pj4gW0NB VVRJT046IEV4dGVybmFsIEVtYWlsXQo+Pj4+Cj4+Pj4gVXNlIHN0cnVjdF9zaXplKCkgaGVscGVy IHRvIGtlZXAgY29kZSBzaW1wbGUuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiB4aWFvbGlua3Vp IDx4aWFvbGlua3VpQGt5bGlub3MuY24+Cj4+Pj4gLS0tCj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfcmFzLmMgfCAzICstLQo+Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yYXMuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9yYXMuYwo+Pj4+IGluZGV4IDIyYmQyMWUuLjQ3MTdhNjQgMTAwNjQ0Cj4+ Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Jhcy5jCj4+Pj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Jhcy5jCj4+Pj4gQEAgLTEzNzUs OCArMTM3NSw3IEBAIGludCBhbWRncHVfcmFzX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYpCj4+Pj4gICAgICAgICAgaWYgKGNvbikKPj4+PiAgICAgICAgICAgICAgICAgIHJldHVybiAw Owo+Pj4+Cj4+Pj4gLSAgICAgICBjb24gPSBrbWFsbG9jKHNpemVvZihzdHJ1Y3QgYW1kZ3B1X3Jh cykgKwo+Pj4+IC0gICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihzdHJ1Y3QgcmFzX21hbmFn ZXIpICogQU1ER1BVX1JBU19CTE9DS19DT1VOVCwKPj4+PiArICAgICAgIGNvbiA9IGttYWxsb2Mo c3RydWN0X3NpemUoY29uLCBvYmpzLCBBTURHUFVfUkFTX0JMT0NLX0NPVU5UKSwKPj4+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgR0ZQX0tFUk5FTHxfX0dGUF9aRVJPKTsKPj4+PiAgICAgICAg ICBpZiAoIWNvbikKPj4+PiAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+Pj4+IC0t Cj4+Pj4gMi43LjQKPj4+Pgo+Pj4+Cj4+Pj4KPj4+IC0tCj4+PiBEYW5pZWwgVmV0dGVyCj4+PiBT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPj4+IGh0dHA6Ly9ibG9nLmZmd2xs LmNoCj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ Pj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngKPgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwph bWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=