From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/9] drm/amdgpu: Refine function amdgpu_csa_vaddr Date: Thu, 6 Dec 2018 13:28:02 +0100 Message-ID: <38bd4a0b-dd41-d897-9ece-48327aa3e00c@gmail.com> References: <1544098447-21648-1-git-send-email-Rex.Zhu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1544098447-21648-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Rex Zhu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMDYuMTIuMTggdW0gMTM6MTQgc2NocmllYiBSZXggWmh1Ogo+IG9uIGJhcmVtZXRhbCwgZHJp dmVyIGNyZWF0ZSBjc2EgcGVyIGN0eC4KPiBTbyBhZGQgYSBmdW5jdGlvbiBhcmd1bWVudDogY3R4 X2lkIHRvCj4gZ2V0IGNzYSBncHUgYWRkci4KPiBJbiBTcmlvdiwgZHJpdmVyIGNyZWF0ZSBjc2Eg cGVyIHByb2Nlc3MsCj4gc28gY3R4IGlkIGFsd2F5cyAxLgo+Cj4gU2lnbmVkLW9mZi1ieTogUmV4 IFpodSA8UmV4LlpodUBhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2NzYS5jIHwgNSArKystLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2NzYS5oIHwgMiArLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2ttcy5jIHwgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjhfMC5j ICAgfCA2ICsrKy0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y5XzAuYyAg IHwgNCArKy0tCj4gICA1IGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEwIGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9jc2EuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jc2EuYwo+IGluZGV4 IDBjNTkwZGQuLjQ0YjA0NmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2NzYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2NzYS5jCj4gQEAgLTI0LDExICsyNCwxMiBAQAo+ICAgCj4gICAjaW5jbHVkZSAiYW1kZ3B1Lmgi Cj4gICAKPiAtdWludDY0X3QgYW1kZ3B1X2NzYV92YWRkcihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq YWRldikKPiArdWludDY0X3QgYW1kZ3B1X2NzYV92YWRkcihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq YWRldiwgdWludDMyX3QgaWQpCj4gICB7Cj4gICAJdWludDY0X3QgYWRkciA9IGFkZXYtPnZtX21h bmFnZXIubWF4X3BmbiA8PCBBTURHUFVfR1BVX1BBR0VfU0hJRlQ7Cj4gICAKPiAtCWFkZHIgLT0g QU1ER1BVX1ZBX1JFU0VSVkVEX1NJWkU7Cj4gKwlhZGRyIC09IEFNREdQVV9WQV9SRVNFUlZFRF9T SVpFICogaWQ7Cj4gKwoKSXQgbWlnaHQgYmUgYmV0dGVyIHRvIGFkZCB0aGUgU1JJT1YgaGFuZGxp bmcgaGVyZSBpbnN0ZWFkLiBFLmcuIGxpa2UgdGhlIApmb2xsb3dpbmc6CgppZiAoYW1kZ3B1X3Ny aW92X3ZmKGFkZXYpKQogwqDCoMKgIGFkZHIgLT0gQU1ER1BVX1ZBX1JFU0VSVkVEX1NJWkU7CmVs c2UKIMKgwqDCoCBhZGRyIC09IEFNREdQVV9DU0FfU0laRSAqIGlkOwoKQXBhcnQgZnJvbSB0aGF0 IGxvb2tzIGdvb2QgdG8gbWUsIGJ1dCBtaWdodCBiZSBiZXR0ZXIgdG8gcmUtb3JkZXIgdGhlIApw YXRjaGVzLgoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPiAgIAlhZGRyID0gYW1kZ3B1X2dtY19zaWdu X2V4dGVuZChhZGRyKTsKPiAgIAo+ICAgCXJldHVybiBhZGRyOwo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3NhLmggYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfY3NhLmgKPiBpbmRleCA1MjRiNDQzLi5hYWYxZmJhIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jc2EuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jc2EuaAo+IEBAIC0yOCw3ICsyOCw3IEBACj4g ICAjZGVmaW5lIEFNREdQVV9DU0FfU0laRQkJKDEyOCAqIDEwMjQpCj4gICAKPiAgIHVpbnQzMl90 IGFtZGdwdV9nZXRfdG90YWxfY3NhX3NpemUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpOwo+ IC11aW50NjRfdCBhbWRncHVfY3NhX3ZhZGRyKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsK PiArdWludDY0X3QgYW1kZ3B1X2NzYV92YWRkcihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwg dWludDMyX3QgaWQpOwo+ICAgaW50IGFtZGdwdV9hbGxvY2F0ZV9zdGF0aWNfY3NhKHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2LCBzdHJ1Y3QgYW1kZ3B1X2JvICoqYm8sCj4gICAJCQkJdTMyIGRv bWFpbiwgdWludDMyX3Qgc2l6ZSk7Cj4gICBpbnQgYW1kZ3B1X21hcF9zdGF0aWNfY3NhKHN0cnVj dCBhbWRncHVfZGV2aWNlICphZGV2LCBzdHJ1Y3QgYW1kZ3B1X3ZtICp2bSwKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jIGIvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jCj4gaW5kZXggMDhkMDRmNi4uZjczNmJkYSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLmMKPiBAQCAtOTc3LDkgKzk3 Nyw5IEBAIGludCBhbWRncHVfZHJpdmVyX29wZW5fa21zKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2KQo+ICAgCQlnb3RvIGVycm9yX3ZtOwo+ICAgCX0K PiAgIAo+IC0JaWYgKGFtZGdwdV9zcmlvdl92ZihhZGV2KSkgewo+IC0JCXVpbnQ2NF90IGNzYV9h ZGRyID0gYW1kZ3B1X2NzYV92YWRkcihhZGV2KSAmIEFNREdQVV9HTUNfSE9MRV9NQVNLOwo+ICAg Cj4gKwlpZiAoYW1kZ3B1X3NyaW92X3ZmKGFkZXYpKSB7Cj4gKwkJdWludDY0X3QgY3NhX2FkZHIg PSBhbWRncHVfY3NhX3ZhZGRyKGFkZXYsIDEpICYgQU1ER1BVX0dNQ19IT0xFX01BU0s7Cj4gICAJ CXIgPSBhbWRncHVfbWFwX3N0YXRpY19jc2EoYWRldiwgJmZwcml2LT52bSwgYWRldi0+dmlydC5j c2Ffb2JqLAo+ICAgCQkJCQkJJmZwcml2LT5jc2FfdmEsIGNzYV9hZGRyLCBBTURHUFVfQ1NBX1NJ WkUpOwo+ICAgCQlpZiAocikKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvZ2Z4X3Y4XzAuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OF8wLmMKPiBp bmRleCBiZGFlNTYzLi5kNTI5Y2VmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2dmeF92OF8wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhf djhfMC5jCj4gQEAgLTcxOTIsMTEgKzcxOTIsMTEgQEAgc3RhdGljIHZvaWQgZ2Z4X3Y4XzBfcmlu Z19lbWl0X2NlX21ldGEoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nKQo+ICAgCX0gY2VfcGF5bG9h ZCA9IHt9Owo+ICAgCj4gICAJaWYgKHJpbmctPmFkZXYtPnZpcnQuY2hhaW5lZF9pYl9zdXBwb3J0 KSB7Cj4gLQkJY2VfcGF5bG9hZF9hZGRyID0gYW1kZ3B1X2NzYV92YWRkcihyaW5nLT5hZGV2KSAr Cj4gKwkJY2VfcGF5bG9hZF9hZGRyID0gYW1kZ3B1X2NzYV92YWRkcihyaW5nLT5hZGV2LCAxKSAr Cj4gICAJCQlvZmZzZXRvZihzdHJ1Y3QgdmlfZ2Z4X21ldGFfZGF0YV9jaGFpbmVkX2liLCBjZV9w YXlsb2FkKTsKPiAgIAkJY250X2NlID0gKHNpemVvZihjZV9wYXlsb2FkLmNoYWluZWQpID4+IDIp ICsgNCAtIDI7Cj4gICAJfSBlbHNlIHsKPiAtCQljZV9wYXlsb2FkX2FkZHIgPSBhbWRncHVfY3Nh X3ZhZGRyKHJpbmctPmFkZXYpICsKPiArCQljZV9wYXlsb2FkX2FkZHIgPSBhbWRncHVfY3NhX3Zh ZGRyKHJpbmctPmFkZXYsIDEpICsKPiAgIAkJCW9mZnNldG9mKHN0cnVjdCB2aV9nZnhfbWV0YV9k YXRhLCBjZV9wYXlsb2FkKTsKPiAgIAkJY250X2NlID0gKHNpemVvZihjZV9wYXlsb2FkLnJlZ3Vs YXIpID4+IDIpICsgNCAtIDI7Cj4gICAJfQo+IEBAIC03MjIwLDcgKzcyMjAsNyBAQCBzdGF0aWMg dm9pZCBnZnhfdjhfMF9yaW5nX2VtaXRfZGVfbWV0YShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcp Cj4gICAJCXN0cnVjdCB2aV9kZV9pYl9zdGF0ZV9jaGFpbmVkX2liIGNoYWluZWQ7Cj4gICAJfSBk ZV9wYXlsb2FkID0ge307Cj4gICAKPiAtCWNzYV9hZGRyID0gYW1kZ3B1X2NzYV92YWRkcihyaW5n LT5hZGV2KTsKPiArCWNzYV9hZGRyID0gYW1kZ3B1X2NzYV92YWRkcihyaW5nLT5hZGV2LCAxKTsK PiAgIAlnZHNfYWRkciA9IGNzYV9hZGRyICsgNDA5NjsKPiAgIAlpZiAocmluZy0+YWRldi0+dmly dC5jaGFpbmVkX2liX3N1cHBvcnQpIHsKPiAgIAkJZGVfcGF5bG9hZC5jaGFpbmVkLmdkc19iYWNr dXBfYWRkcmxvID0gbG93ZXJfMzJfYml0cyhnZHNfYWRkcik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OV8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9nZnhfdjlfMC5jCj4gaW5kZXggOTI4MDM0Yy4uODFjMTU3OCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjlfMC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvZ2Z4X3Y5XzAuYwo+IEBAIC00MzI3LDcgKzQzMjcsNyBAQCBzdGF0aWMg dm9pZCBnZnhfdjlfMF9yaW5nX2VtaXRfY2VfbWV0YShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcp Cj4gICAJaW50IGNudDsKPiAgIAo+ICAgCWNudCA9IChzaXplb2YoY2VfcGF5bG9hZCkgPj4gMikg KyA0IC0gMjsKPiAtCWNzYV9hZGRyID0gYW1kZ3B1X2NzYV92YWRkcihyaW5nLT5hZGV2KTsKPiAr CWNzYV9hZGRyID0gYW1kZ3B1X2NzYV92YWRkcihyaW5nLT5hZGV2LCAxKTsKPiAgIAo+ICAgCWFt ZGdwdV9yaW5nX3dyaXRlKHJpbmcsIFBBQ0tFVDMoUEFDS0VUM19XUklURV9EQVRBLCBjbnQpKTsK PiAgIAlhbWRncHVfcmluZ193cml0ZShyaW5nLCAoV1JJVEVfREFUQV9FTkdJTkVfU0VMKDIpIHwK PiBAQCAtNDM0NSw3ICs0MzQ1LDcgQEAgc3RhdGljIHZvaWQgZ2Z4X3Y5XzBfcmluZ19lbWl0X2Rl X21ldGEoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nKQo+ICAgCXVpbnQ2NF90IGNzYV9hZGRyLCBn ZHNfYWRkcjsKPiAgIAlpbnQgY250Owo+ICAgCj4gLQljc2FfYWRkciA9IGFtZGdwdV9jc2FfdmFk ZHIocmluZy0+YWRldik7Cj4gKwljc2FfYWRkciA9IGFtZGdwdV9jc2FfdmFkZHIocmluZy0+YWRl diwgMSk7Cj4gICAJZ2RzX2FkZHIgPSBjc2FfYWRkciArIDQwOTY7Cj4gICAJZGVfcGF5bG9hZC5n ZHNfYmFja3VwX2FkZHJsbyA9IGxvd2VyXzMyX2JpdHMoZ2RzX2FkZHIpOwo+ICAgCWRlX3BheWxv YWQuZ2RzX2JhY2t1cF9hZGRyaGkgPSB1cHBlcl8zMl9iaXRzKGdkc19hZGRyKTsKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBs aXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=