Re: [PATCH v4 0/4] Add GPU page fault query interface

["Christian König" <ckoenig.leichtzumerken@gmail.com>]

Am 28.09.23 um 22:06 schrieb Alex Deucher:
> This patch set adds support for an application to query GPU
> page faults.  It's useful for debugging and there are
> vulkan extensions that could make use of this.  Preliminary
> user space code which uses this can be found here:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23238
> https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/298
>
> Note, that I made a small change to the vmhub definition to
> decouple it from how the kernel tracks vmhubs so that we have
> a consistent user view even if we decide to add more vmhubs
> like we recently did for gfx 9.4.3.
>
> I've also pushed the changed to:
> https://gitlab.freedesktop.org/agd5f/linux/-/commits/gpu_fault_info_ioctl
>
> Open question, currently we just expose the raw GPU fault status
> register value for each GPU so UMDs need GPU specific knowlege to decode
> it, although it's largely the same across generations.  One option would be to
> translate to a generic GPU independent fault status.  Opinions?

Lot of work for not much gain. I think we should stick with this for now.

Reviewed-by: Christian König <christian.koenig@amd.com>

>
> v2:
> - Fix spelling typos noted by Guchun
> v3:
> - Add locking in IOCTL query
> - Only update cache if fault status is valid
> v4:
> - Rebase and resend
>
> Alex Deucher (4):
>    drm/amdgpu: add cached GPU fault structure to vm struct
>    drm/amdgpu: cache gpuvm fault information for gmc7+
>    drm/amdgpu: add new INFO ioctl query for the last GPU page fault
>    drm/amdgpu: refine fault cache updates
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |  3 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 20 ++++++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c  | 50 +++++++++++++++++++++++++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h  | 31 +++++++++++++--
>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c  |  3 ++
>   drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c  |  3 ++
>   drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c   |  3 ++
>   drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c   |  3 ++
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c   | 11 ++++--
>   include/uapi/drm/amdgpu_drm.h           | 16 ++++++++
>   10 files changed, 135 insertions(+), 8 deletions(-)
>