From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory Date: Thu, 11 Jul 2019 19:26:21 +0200 Message-ID: <3a2bb4ef-0fd7-3076-e6c2-39f2a3454727@suse.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1296044343==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Pietrasiewicz , dri-devel@lists.freedesktop.org Cc: Sam Ravnborg , Neil Armstrong , Maxime Ripard , Douglas Anderson , Thierry Reding , Laurent Pinchart , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , David Airlie , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , intel-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Alexios Zavras , Mamta Shukla , linux-mediatek@lists.infradead.org, Jyr List-Id: amd-gfx.lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1296044343== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M6nYUrh3oEarMl1892EPEAAzHEDzD10R3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M6nYUrh3oEarMl1892EPEAAzHEDzD10R3 Content-Type: multipart/mixed; boundary="8S0vaGiu1cLt80DL4dXMNOlmLb3f1te4c"; protected-headers="v1" From: Thomas Zimmermann To: Andrzej Pietrasiewicz , dri-devel@lists.freedesktop.org Cc: kernel@collabora.com, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Dave Airlie , Andrzej Hajda , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Sean Paul , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , CK Hu , Matthias Brugger , Rob Clark , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Benjamin Gaignard , Vincent Abriou , Chen-Yu Tsai , Thierry Reding , Jonathan Hunter , Jyri Sarha , Tomi Valkeinen , Eric Anholt , Sam Ravnborg , Huang Rui , Gerd Hoffmann , "Y.C. Chen" , Neil Armstrong , Douglas Anderson , Jonas Karlman , Thomas Gleixner , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Chris Wilson , Ramalingam C , Shashank Sharma , Alexios Zavras , Todor Tomov , Mamta Shukla , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org Message-ID: <3a2bb4ef-0fd7-3076-e6c2-39f2a3454727@suse.de> Subject: Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory References: In-Reply-To: --8S0vaGiu1cLt80DL4dXMNOlmLb3f1te4c Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Acked-by: Thomas Zimmermann Am 11.07.19 um 13:26 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. >=20 > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/m= gag200/mgag200_mode.c > index a25054015e8c..8fb9444b2142 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_mode.c > +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c > @@ -1703,6 +1703,11 @@ static struct drm_connector *mga_vga_init(struct= drm_device *dev) > return NULL; > =20 > connector =3D &mga_connector->base; > + mga_connector->i2c =3D mgag200_i2c_create(dev); > + if (!mga_connector->i2c) > + DRM_ERROR("failed to add ddc bus\n"); > + > + connector->ddc =3D &mga_connector->i2c->adapter; > =20 > drm_connector_init(dev, connector, > &mga_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA); > @@ -1711,10 +1716,6 @@ static struct drm_connector *mga_vga_init(struct= drm_device *dev) > =20 > drm_connector_register(connector); > =20 > - mga_connector->i2c =3D mgag200_i2c_create(dev); > - if (!mga_connector->i2c) > - DRM_ERROR("failed to add ddc bus\n"); > - > return connector; > } > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --8S0vaGiu1cLt80DL4dXMNOlmLb3f1te4c-- --M6nYUrh3oEarMl1892EPEAAzHEDzD10R3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl0ncUEACgkQaA3BHVML eiNDOQf/V82uMwvnLRj0DGrIvbmWkTJ1+JLlhJzekDs6PjWJPTJ9EkobcJ9GuWFV hE90Tt8U2u+MkrmeLbHiyVWYUAcWnb5F9ldlRKD+IXaeXnQoxMCuBLIbR/uVz6Mz BDUv4l0n+guDhbQZYfPhoQ3NcFnCRBshnxKq9R5F8zALotio+X7ZYvMSV+jxJhST 6xA7pyIn6qIKcqO/1Ytunpon3rxf2xlJwWLdLhA8mKho3A2JhVmZk38zAWSBZ4FJ Q9ja+BhaxP1SO1iA63QqCrrGwoZVUXTdEWAB64Yw4DQyJ+cdDtIZfJDh68uYTbs+ ggIdNPQBzpJeQHD/WpKXSKA56aYG3w== =ciQB -----END PGP SIGNATURE----- --M6nYUrh3oEarMl1892EPEAAzHEDzD10R3-- --===============1296044343== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1296044343==--