From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Felix Kuehling <felix.kuehling@amd.com>,
Alex Deucher <alexdeucher@gmail.com>,
amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH 2/2] drm/amdgpu/gmc10: print client id string for gfxhub
Date: Wed, 2 Sep 2020 09:17:50 +0200 [thread overview]
Message-ID: <3a3e5bfe-1a11-daa3-c42e-d9ede6da63b1@gmail.com> (raw)
In-Reply-To: <e6cc8a4a-90e5-fe47-cab8-15ae730212a5@amd.com>
Am 02.09.20 um 04:32 schrieb Felix Kuehling:
> Should there a corresponding change in mmhub_v2_0.c?
It would be at least nice to have.
Maybe we should put a pointer to the array and its size into the hub
structure instead?
Anyway Reviewed-by: Christian König <christian.koenig@amd.com> for now.
Christian.
>
> Other than that, the series is
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
>
> On 2020-09-01 5:51 p.m., Alex Deucher wrote:
>> Print the name of the client rather than the number. This
>> makes it easier to debug what block is causing the fault.
>>
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 30 +++++++++++++++++++++---
>> drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c | 30 +++++++++++++++++++++---
>> 2 files changed, 54 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c
>> b/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c
>> index 76acd7f7723e..b882ac59879a 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c
>> @@ -31,6 +31,27 @@
>> #include "soc15_common.h"
>> +static const char *gfxhub_client_ids[] = {
>> + "CB/DB",
>> + "Reserved",
>> + "GE1",
>> + "GE2",
>> + "CPF",
>> + "CPC",
>> + "CPG",
>> + "RLC",
>> + "TCP",
>> + "SQC (inst)",
>> + "SQC (data)",
>> + "SQG",
>> + "Reserved",
>> + "SDMA0",
>> + "SDMA1",
>> + "GCR",
>> + "SDMA2",
>> + "SDMA3",
>> +};
>> +
>> static uint32_t gfxhub_v2_0_get_invalidate_req(unsigned int vmid,
>> uint32_t flush_type)
>> {
>> @@ -55,12 +76,15 @@ static void
>> gfxhub_v2_0_print_l2_protection_fault_status(struct amdgpu_device
>> *adev,
>> uint32_t status)
>> {
>> + u32 cid = REG_GET_FIELD(status,
>> + GCVM_L2_PROTECTION_FAULT_STATUS, CID);
>> +
>> dev_err(adev->dev,
>> "GCVM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
>> status);
>> - dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
>> - REG_GET_FIELD(status,
>> - GCVM_L2_PROTECTION_FAULT_STATUS, CID));
>> + dev_err(adev->dev, "\t Faulty UTCL2 client ID: %s (0x%x)\n",
>> + cid >= ARRAY_SIZE(gfxhub_client_ids) ? "unknown" :
>> gfxhub_client_ids[cid],
>> + cid);
>> dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
>> REG_GET_FIELD(status,
>> GCVM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c
>> b/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c
>> index 80c906a0383f..237a9ff5afa0 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c
>> @@ -31,6 +31,27 @@
>> #include "soc15_common.h"
>> +static const char *gfxhub_client_ids[] = {
>> + "CB/DB",
>> + "Reserved",
>> + "GE1",
>> + "GE2",
>> + "CPF",
>> + "CPC",
>> + "CPG",
>> + "RLC",
>> + "TCP",
>> + "SQC (inst)",
>> + "SQC (data)",
>> + "SQG",
>> + "Reserved",
>> + "SDMA0",
>> + "SDMA1",
>> + "GCR",
>> + "SDMA2",
>> + "SDMA3",
>> +};
>> +
>> static uint32_t gfxhub_v2_1_get_invalidate_req(unsigned int vmid,
>> uint32_t flush_type)
>> {
>> @@ -55,12 +76,15 @@ static void
>> gfxhub_v2_1_print_l2_protection_fault_status(struct amdgpu_device
>> *adev,
>> uint32_t status)
>> {
>> + u32 cid = REG_GET_FIELD(status,
>> + GCVM_L2_PROTECTION_FAULT_STATUS, CID);
>> +
>> dev_err(adev->dev,
>> "GCVM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
>> status);
>> - dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
>> - REG_GET_FIELD(status,
>> - GCVM_L2_PROTECTION_FAULT_STATUS, CID));
>> + dev_err(adev->dev, "\t Faulty UTCL2 client ID: %s (0x%x)\n",
>> + cid >= ARRAY_SIZE(gfxhub_client_ids) ? "unknown" :
>> gfxhub_client_ids[cid],
>> + cid);
>> dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
>> REG_GET_FIELD(status,
>> GCVM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-09-02 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:51 [PATCH 1/2] drm/amdgpu/gmc9: print client id string for gfxhub Alex Deucher
2020-09-01 21:51 ` [PATCH 2/2] drm/amdgpu/gmc10: " Alex Deucher
2020-09-02 2:32 ` Felix Kuehling
2020-09-02 7:17 ` Christian König [this message]
2020-09-02 14:30 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a3e5bfe-1a11-daa3-c42e-d9ede6da63b1@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=felix.kuehling@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox