AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: "Timur Kristóf" <timur.kristof@gmail.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Natalie Vock" <natalie.vock@gmx.de>,
	"Shetaia, Amir" <Amir.Shetaia@amd.com>,
	"Marek Olšák" <maraeo@gmail.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"Tvrtko Ursulin" <tursulin@ursulin.net>,
	"Kuehling, Felix" <Felix.Kuehling@amd.com>,
	"He, Siwei" <Siwei.He@amd.com>,
	"Yang, Philip" <Philip.Yang@amd.com>,
	"Joshi, Mukul" <Mukul.Joshi@amd.com>
Subject: Re: [PATCH 11/14] drm/amdgpu/ih6.0: Use MMIO ACK for retry CAM on IH 6.0
Date: Thu, 16 Jul 2026 12:13:48 +0530	[thread overview]
Message-ID: <3b22af83-9f55-4a46-9d07-927fb90f7e02@amd.com> (raw)
In-Reply-To: <H4udL4GlQcaqUkZjX19xCw@gmail.com>



On 16-Jul-26 4:25 AM, Timur Kristóf wrote:
> On Tuesday, July 7, 2026 10:25:09 AM Central European Summer Time Lazar, Lijo
> wrote:
>> On 04-Jul-26 12:20 AM, Timur Kristóf wrote:
>>> On 2026. július 3., péntek 20:11:59 közép-európai nyári idő Joshi, Mukul
>>>
>>> wrote:
>>>>> I still haven't found any explanation why we use a doorbell for the CAM
>>>>> in
>>>>> the first
>>>>
>>>> place? Lijo, Alex, Felix does anybody know that?
>>>>
>>>>
>>>> If I remember correctly, we weren't sure if the IH_RETRY_CAM_ACK register
>>>> would be available under
>>>> virtualization. And we were sure doorbells would
>>>> work for both bare-metal and virtualization.
>>>
>>> Hi Mukul,
>>>
>>> Can you clarify that please?
>>>
>>> How are retry faults supposed to work under virtualization? Is the
>>> interrupt processed by the guest or the host? Why is the IH_RETRY_CAM_ACK
>>> register not available under virtualization?
>>
>> For clarification - CAM entries are separate for PF/VF. ACK register
>> also has PF/VF copies. However, in general host driver imposes MMIO
>> register access restrictions to VF, possibly that's the reason.
>>
>> Please note that IH_RETRY_INT_CAM_CNTL is PF only. With new versions,
>> please make sure to add a VF check for programming.
> 
> Hi Lijo,
> 
> Can you please clarify what PF and VF means here?

PF = physical function.  VF = virtual function. On virtualization 
environments amdgpu is a guest driver.

Translates to below check for cam_cntl register programming.
	if (!amdgpu_sriov_vf(adev))

Thanks,
Lijo

> I'm not familiar with those abbreviations.
> 
> Thanks,
> Timur
> 
> 


  reply	other threads:[~2026-07-16  6:44 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 16:17 [PATCH 00/14] drm/amdgpu: Improve retry fault handling (v3) Timur Kristóf
2026-07-01 16:17 ` [PATCH 01/14] drm/amdgpu: Respect noretry flag for retry faults on GFX12.1 Timur Kristóf
2026-07-02  7:58   ` Christian König
2026-07-01 16:17 ` [PATCH 02/14] drm/amdgpu/gfxhub: Enable retry fault interrupts when needed Timur Kristóf
2026-07-02  8:10   ` Christian König
2026-07-02  9:14     ` Timur Kristóf
2026-07-02 12:02       ` Christian König
2026-07-15 22:51         ` Timur Kristóf
2026-07-17 12:06           ` Christian König
2026-07-01 16:17 ` [PATCH 03/14] drm/amdgpu/ih: Don't perturb HW registers when accessing soft IH ring Timur Kristóf
2026-07-02  8:10   ` Christian König
2026-07-01 16:17 ` [PATCH 04/14] drm/amdgpu/ih: Add retry_cam_ack IH function pointer Timur Kristóf
2026-07-02  8:12   ` Christian König
2026-07-01 16:17 ` [PATCH 05/14] drm/amdgpu/ih6.1: Use IH_SW_RING_SIZE for soft IH ring instead of PAGE_SIZE Timur Kristóf
2026-07-02  8:13   ` Christian König
2026-07-01 16:17 ` [PATCH 06/14] drm/amdgpu/ih7.0: " Timur Kristóf
2026-07-02 10:15   ` Christian König
2026-07-01 16:17 ` [PATCH 07/14] drm/amdgpu/gmc11: Pass cam_index to retry fault handler Timur Kristóf
2026-07-02 10:17   ` Christian König
2026-07-01 16:17 ` [PATCH 08/14] drm/amdgpu/gmc12: " Timur Kristóf
2026-07-02 10:18   ` Christian König
2026-07-01 16:17 ` [PATCH 09/14] drm/amdgpu/gmc12: Use AMDGPU_PTE_IS_PTE flag for init_pte_flags on GFX12.0 Timur Kristóf
2026-07-02 10:19   ` Christian König
2026-07-01 16:17 ` [PATCH 10/14] drm/amdgpu/vm: Use init PTE flags and NOALLOC in amdgpu_vm_handle_fault() Timur Kristóf
2026-07-02 10:22   ` Christian König
2026-07-02 11:28     ` Timur Kristóf
2026-07-02 12:18       ` Christian König
2026-07-02 12:58         ` Timur Kristóf
2026-07-01 16:17 ` [PATCH 11/14] drm/amdgpu/ih6.0: Use MMIO ACK for retry CAM on IH 6.0 Timur Kristóf
2026-07-02 10:23   ` Christian König
2026-07-02 11:52     ` Timur Kristóf
2026-07-03 18:11     ` Joshi, Mukul
2026-07-03 18:50       ` Timur Kristóf
2026-07-07  8:25         ` Lazar, Lijo
2026-07-15 22:55           ` Timur Kristóf
2026-07-16  6:43             ` Lazar, Lijo [this message]
2026-07-03 18:45     ` Kuehling, Felix
2026-07-03 17:46   ` Joshi, Mukul
2026-07-03 18:46     ` Timur Kristóf
2026-07-06 15:28       ` Alex Deucher
2026-07-06 18:04       ` Joshi, Mukul
2026-07-06 21:27         ` Mukul Joshi
2026-07-15 22:54           ` Timur Kristóf
2026-07-01 16:17 ` [PATCH 12/14] drm/amdgpu/ih7.0: Use MMIO ACK instead of doorbell for retry CAM on IH 7.0 Timur Kristóf
2026-07-02 10:24   ` Christian König
2026-07-03 16:31   ` Joshi, Mukul
2026-07-03 18:41     ` Timur Kristóf
2026-07-06 17:48       ` Joshi, Mukul
2026-07-06 19:03         ` Mukul Joshi
2026-07-01 16:17 ` [PATCH 13/14] drm/amdgpu/ih6.0: Enable retry CAM on Navi 3 dGPUs Timur Kristóf
2026-07-02 10:35   ` Christian König
2026-07-01 16:17 ` [PATCH 14/14] drm/amdgpu/ih7.0: Enable retry CAM on Navi 4 dGPUs Timur Kristóf
2026-07-02 10:38   ` Christian König
2026-07-02 11:53     ` Timur Kristóf
2026-07-02 12:30       ` Christian König
2026-07-02 12:47         ` Timur Kristóf
2026-07-02 13:26         ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b22af83-9f55-4a46-9d07-927fb90f7e02@amd.com \
    --to=lijo.lazar@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Amir.Shetaia@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Mukul.Joshi@amd.com \
    --cc=Philip.Yang@amd.com \
    --cc=Siwei.He@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=maraeo@gmail.com \
    --cc=natalie.vock@gmx.de \
    --cc=timur.kristof@gmail.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox