amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: jiadong.zhu@amd.com, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Remove fence_process in count_emitted
Date: Mon, 26 Sep 2022 08:50:53 +0200	[thread overview]
Message-ID: <3b7980f3-9741-9166-e103-a671b562c915@gmail.com> (raw)
In-Reply-To: <20220923132724.1260802-1-jiadong.zhu@amd.com>

Am 23.09.22 um 15:27 schrieb jiadong.zhu@amd.com:
> From: "Jiadong.Zhu" <Jiadong.Zhu@amd.com>
>
> The function amdgpu_fence_count_emitted used in work_hander should not call
> amdgpu_fence_process which must be used in irq handler.
>
> Signed-off-by: Jiadong.Zhu <Jiadong.Zhu@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> index d16c8c1f72db..790f7bfdc654 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
> @@ -394,7 +394,6 @@ unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring)
>   	/* We are not protected by ring lock when reading the last sequence
>   	 * but it's ok to report slightly wrong fence count here.
>   	 */
> -	amdgpu_fence_process(ring);
>   	emitted = 0x100000000ull;
>   	emitted -= atomic_read(&ring->fence_drv.last_seq);
>   	emitted += READ_ONCE(ring->fence_drv.sync_seq);


      reply	other threads:[~2022-09-26  6:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 13:27 [PATCH] drm/amdgpu: Remove fence_process in count_emitted jiadong.zhu
2022-09-26  6:50 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b7980f3-9741-9166-e103-a671b562c915@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=jiadong.zhu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).