From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kuehling, Felix" Subject: Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3 Date: Fri, 16 Nov 2018 19:16:49 +0000 Message-ID: <3cab671b-dcea-0797-3ae6-40b118eedcd2@amd.com> References: <20181116190819.28112-1-Philip.Yang@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181116190819.28112-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US Content-ID: <9322DC207CDF144E929F62889311D5F5-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yang, Philip" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" TG9va3MgZ29vZCB0byBtZS4gUmV2aWV3ZWQtYnk6IEZlbGl4IEt1ZWhsaW5nIDxGZWxpeC5LdWVo bGluZ0BhbWQuY29tPg0KDQpJIGhvcGUgQWxleCBvciBDaHJpc3RpYW4gY2FuIGFsc28gcmV2aWV3 IHRoaXMgaW4gY2FzZSBJJ20gbWlzc2luZw0Kc29tZXRoaW5nIGFib3V0IGhvdyBkb29yYmVsbHMg YXJlIHVzZWQgaW4gYW1kZ3B1Lg0KDQpSZWdhcmRzLA0KwqAgRmVsaXgNCg0KT24gMjAxOC0xMS0x NiAyOjA4IHAubS4sIFlhbmcsIFBoaWxpcCB3cm90ZToNCj4gQmVjYXVzZSBpbmNyZWFzZSBTRE1B X0RPT1JCRUxMX1JBTkdFIHRvIGFkZCBuZXcgU0RNQSBkb29yYmVsbCBmb3IgcGFnaW5nIHF1ZXVl IHdpbGwNCj4gYnJlYWsgU1JJT1YsIGluc3RlYWQgd2UgY2FuIHJlc2VydmUgYW5kIG1hcCB0d28g ZG9vcmJlbGwgcGFnZXMgZm9yIGFtZGdwdSwgcGFnaW5nDQo+IHF1ZXVlcyBkb29yYmVsbCBpbmRl eCB1c2Ugc2FtZSBpbmRleCBhcyBTRE1BIGdmeCBxdWV1ZXMgaW5kZXggYnV0IG9uIHNlY29uZCBw YWdlLg0KPg0KPiBGb3IgVmVnYTIwLCBhZnRlciB3ZSBjaGFuZ2UgZG9vcmJlbGwgbGF5b3V0IHRv IGluY3JlYXNlIFNETUEgZG9vcmJlbGwgZm9yIDggU0RNQSBSTEMNCj4gcXVldWVzIGxhdGVyLCB3 ZSBjb3VsZCB1c2UgbmV3IGRvb3JiZWxsIGluZGV4IGZvciBwYWdpbmcgcXVldWUuDQo+DQo+IENo YW5nZS1JZDogSTlhZGI5NjVmMTZlZTQwODlkMjYxZDlhMjIyMzEzMzc3MzkxODRlNDkNCj4gU2ln bmVkLW9mZi1ieTogUGhpbGlwIFlhbmcgPFBoaWxpcC5ZYW5nQGFtZC5jb20+DQo+IC0tLQ0KPiAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jIHwgMTMgKysrKysrKysr DQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYyAgICAgfCAzMyArKysr KysrKysrKysrLS0tLS0tLS0tDQo+ICAyIGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyks IDEzIGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2RldmljZS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2RldmljZS5jDQo+IGluZGV4IDU5MDU4OGE4MjQ3MS4uN2E1NDc2MDU5MWFlIDEwMDY0NA0KPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMNCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jDQo+IEBAIC01MzQsNiAr NTM0LDE5IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2RldmljZV9kb29yYmVsbF9pbml0KHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2KQ0KPiAgCWlmIChhZGV2LT5kb29yYmVsbC5udW1fZG9vcmJlbGxz ID09IDApDQo+ICAJCXJldHVybiAtRUlOVkFMOw0KPiAgDQo+ICsJLyogRm9yIFZlZ2EsIHJlc2Vy dmUgYW5kIG1hcCB0d28gcGFnZXMgb24gZG9vcmJlbGwgQkFSIHNpbmNlIFNETUENCj4gKwkgKiBw YWdpbmcgcXVldWUgZG9vcmJlbGwgdXNlIHRoZSBzZWNvbmQgcGFnZQ0KPiArCSAqLw0KPiArCXN3 aXRjaCAoYWRldi0+YXNpY190eXBlKSB7DQo+ICsJY2FzZSBDSElQX1ZFR0ExMDoNCj4gKwljYXNl IENISVBfVkVHQTEyOg0KPiArCWNhc2UgQ0hJUF9WRUdBMjA6DQo+ICsJCWFkZXYtPmRvb3JiZWxs Lm51bV9kb29yYmVsbHMgKj0gMjsNCj4gKwkJYnJlYWs7DQo+ICsJZGVmYXVsdDoNCj4gKwkJYnJl YWs7DQo+ICsJfQ0KPiArDQo+ICAJYWRldi0+ZG9vcmJlbGwucHRyID0gaW9yZW1hcChhZGV2LT5k b29yYmVsbC5iYXNlLA0KPiAgCQkJCSAgICAgYWRldi0+ZG9vcmJlbGwubnVtX2Rvb3JiZWxscyAq DQo+ICAJCQkJICAgICBzaXplb2YodTMyKSk7DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L3Nk bWFfdjRfMC5jDQo+IGluZGV4IGY0NDkwY2RkOTgwNC4uZGI1YTcxZGI5ZjEwIDEwMDY0NA0KPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYw0KPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9zZG1hX3Y0XzAuYw0KPiBAQCAtOTI1LDExICs5MjUsOSBA QCBzdGF0aWMgdm9pZCBzZG1hX3Y0XzBfcGFnZV9yZXN1bWUoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYsIHVuc2lnbmVkIGludCBpKQ0KPiAgCQkJCQlPRkZTRVQsIHJpbmctPmRvb3JiZWxsX2lu ZGV4KTsNCj4gIAlXUkVHMzJfU0RNQShpLCBtbVNETUEwX1BBR0VfRE9PUkJFTEwsIGRvb3JiZWxs KTsNCj4gIAlXUkVHMzJfU0RNQShpLCBtbVNETUEwX1BBR0VfRE9PUkJFTExfT0ZGU0VULCBkb29y YmVsbF9vZmZzZXQpOw0KPiAtCS8qIFRPRE86IGVuYWJsZSBkb29yYmVsbCBzdXBwb3J0ICovDQo+ IC0JLyphZGV2LT5uYmlvX2Z1bmNzLT5zZG1hX2Rvb3JiZWxsX3JhbmdlKGFkZXYsIGksIHJpbmct PnVzZV9kb29yYmVsbCwNCj4gLQkJCQkJICAgICAgcmluZy0+ZG9vcmJlbGxfaW5kZXgpOyovDQo+ ICANCj4gLQlzZG1hX3Y0XzBfcmluZ19zZXRfd3B0cihyaW5nKTsNCj4gKwkvKiBwYWdpbmcgcXVl dWUgZG9vcmJlbGwgaW5kZXggaXMgYWxyZWFkeSBlbmFibGVkIGF0IHNkbWFfdjRfMF9nZnhfcmVz dW1lICovDQo+ICsJc2RtYV92NF8wX3BhZ2VfcmluZ19zZXRfd3B0cihyaW5nKTsNCj4gIA0KPiAg CS8qIHNldCBtaW5vcl9wdHJfdXBkYXRlIHRvIDAgYWZ0ZXIgd3B0ciBwcm9ncmFtZWQgKi8NCj4g IAlXUkVHMzJfU0RNQShpLCBtbVNETUEwX1BBR0VfTUlOT1JfUFRSX1VQREFURSwgMCk7DQo+IEBA IC0xNTA0LDE4ICsxNTAyLDE0IEBAIHN0YXRpYyBpbnQgc2RtYV92NF8wX3N3X2luaXQodm9pZCAq aGFuZGxlKQ0KPiAgCQlyaW5nLT5yaW5nX29iaiA9IE5VTEw7DQo+ICAJCXJpbmctPnVzZV9kb29y YmVsbCA9IHRydWU7DQo+ICANCj4gLQkJRFJNX0lORk8oInVzZV9kb29yYmVsbCBiZWluZyBzZXQg dG86IFslc11cbiIsDQo+IC0JCQkJcmluZy0+dXNlX2Rvb3JiZWxsPyJ0cnVlIjoiZmFsc2UiKTsN Cj4gLQ0KPiAgCQlpZiAoYWRldi0+YXNpY190eXBlID09IENISVBfVkVHQTEwKQ0KPiAgCQkJcmlu Zy0+ZG9vcmJlbGxfaW5kZXggPSAoaSA9PSAwKSA/DQo+IC0JCQkJKEFNREdQVV9WRUdBMTBfRE9P UkJFTEw2NF9zRE1BX0VOR0lORTAgPDwgMSkgLy9nZXQgRFdPUkQgb2Zmc2V0DQo+IC0JCQkJOiAo QU1ER1BVX1ZFR0ExMF9ET09SQkVMTDY0X3NETUFfRU5HSU5FMSA8PCAxKTsgLy8gZ2V0IERXT1JE IG9mZnNldA0KPiArCQkJCShBTURHUFVfVkVHQTEwX0RPT1JCRUxMNjRfc0RNQV9FTkdJTkUwIDw8 IDEpIC8vIGRvb3JiZWxsIHNpemUgMiBkd29yZHMNCj4gKwkJCQk6IChBTURHUFVfVkVHQTEwX0RP T1JCRUxMNjRfc0RNQV9FTkdJTkUxIDw8IDEpOyAvLyBkb29yYmVsbCBzaXplIDIgZHdvcmRzDQo+ ICAJCWVsc2UNCj4gIAkJCXJpbmctPmRvb3JiZWxsX2luZGV4ID0gKGkgPT0gMCkgPw0KPiAtCQkJ CShBTURHUFVfRE9PUkJFTEw2NF9zRE1BX0VOR0lORTAgPDwgMSkgLy9nZXQgRFdPUkQgb2Zmc2V0 DQo+IC0JCQkJOiAoQU1ER1BVX0RPT1JCRUxMNjRfc0RNQV9FTkdJTkUxIDw8IDEpOyAvLyBnZXQg RFdPUkQgb2Zmc2V0DQo+IC0NCj4gKwkJCQkoQU1ER1BVX0RPT1JCRUxMNjRfc0RNQV9FTkdJTkUw IDw8IDEpIC8vIGRvb3JiZWxsIHNpemUgMiBkd29yZHMNCj4gKwkJCQk6IChBTURHUFVfRE9PUkJF TEw2NF9zRE1BX0VOR0lORTEgPDwgMSk7IC8vIGRvb3JiZWxsIHNpemUgMiBkd29yZHMNCj4gIA0K PiAgCQlzcHJpbnRmKHJpbmctPm5hbWUsICJzZG1hJWQiLCBpKTsNCj4gIAkJciA9IGFtZGdwdV9y aW5nX2luaXQoYWRldiwgcmluZywgMTAyNCwNCj4gQEAgLTE1MjksNyArMTUyMywyMCBAQCBzdGF0 aWMgaW50IHNkbWFfdjRfMF9zd19pbml0KHZvaWQgKmhhbmRsZSkNCj4gIAkJaWYgKGFkZXYtPnNk bWEuaGFzX3BhZ2VfcXVldWUpIHsNCj4gIAkJCXJpbmcgPSAmYWRldi0+c2RtYS5pbnN0YW5jZVtp XS5wYWdlOw0KPiAgCQkJcmluZy0+cmluZ19vYmogPSBOVUxMOw0KPiAtCQkJcmluZy0+dXNlX2Rv b3JiZWxsID0gZmFsc2U7DQo+ICsJCQlyaW5nLT51c2VfZG9vcmJlbGwgPSB0cnVlOw0KPiArDQo+ ICsJCQkvKiBwYWdpbmcgcXVldWUgdXNlIHNhbWUgZG9vcmJlbGwgaW5kZXgvcm91dGluZyBhcyBn ZnggcXVldWUNCj4gKwkJCSAqIHdpdGggMHg0MDAgKDQwOTYgZHdvcmRzKSBvZmZzZXQgb24gc2Vj b25kIGRvb3JiZWxsIHBhZ2UNCj4gKwkJCSAqLw0KPiArCQkJaWYgKGFkZXYtPmFzaWNfdHlwZSA9 PSBDSElQX1ZFR0ExMCkNCj4gKwkJCQlyaW5nLT5kb29yYmVsbF9pbmRleCA9IChpID09IDApID8N Cj4gKwkJCQkJKEFNREdQVV9WRUdBMTBfRE9PUkJFTEw2NF9zRE1BX0VOR0lORTAgPDwgMSkNCj4g KwkJCQkJOiAoQU1ER1BVX1ZFR0ExMF9ET09SQkVMTDY0X3NETUFfRU5HSU5FMSA8PCAxKTsNCj4g KwkJCWVsc2UNCj4gKwkJCQlyaW5nLT5kb29yYmVsbF9pbmRleCA9IChpID09IDApID8NCj4gKwkJ CQkJKEFNREdQVV9ET09SQkVMTDY0X3NETUFfRU5HSU5FMCA8PCAxKQ0KPiArCQkJCQk6IChBTURH UFVfRE9PUkJFTEw2NF9zRE1BX0VOR0lORTEgPDwgMSk7DQo+ICsJCQlyaW5nLT5kb29yYmVsbF9p bmRleCArPSAweDQwMDsNCj4gIA0KPiAgCQkJc3ByaW50ZihyaW5nLT5uYW1lLCAicGFnZSVkIiwg aSk7DQo+ICAJCQlyID0gYW1kZ3B1X3JpbmdfaW5pdChhZGV2LCByaW5nLCAxMDI0LA0KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==