Re: Depth 30 enablement for ati-ddx + exa. Rev 3

[Mario Kleiner <mario.kleiner.de-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 01/25/2018 05:06 PM, Michel Dänzer wrote:
> On 2018-01-24 06:35 PM, Mario Kleiner wrote:
>> On 01/22/2018 07:01 PM, Michel Dänzer wrote:
>>> On 2018-01-22 03:14 AM, Mario Kleiner wrote:
...
>> Having the extension enabled in the ddx is needed for any test to work.
>> But when i set a breakpoint on EVERGREENDisplayTexturedVideo() in
>> evergreen_textured_videofuncs.c, that breakpoint is never hit, even in
>> depth 24 when XvMC tests work, so i'm not sure if i'm looking at mostly
>> unused code there?
> 
> I guess so. :)

Good, then i don't need to look at that code anymore :).

...
>>
>> It only happens if a client wants a fbconfig with alpha channel, for
>> destination alpha blending etc., as my application happens to. If you
>> only run glxgears or a desktop compositor like kde-5's, it won't happen
>> as they only use bgrx configs without alpha.
> 
> I sent out a patch which should fix this, please test.

Yes, that patch "[PATCH xf86-video-ati] Always use screen depth/bpp for 
KMS framebuffers" makes sense to me and fixes it nicely, as tested under 
dri3 and dri2 with glamor and exa:

Reviewed-and-Tested-by: Mario Kleiner <mario.kleiner.de@gmail.com>

I assume amdgpu-ddx will need the same treatment, as "Use reference 
counting for tracking KMS framebuffer lifetimes" which caused the 
problem has been ported to amdgpu-ddx.

-mario
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx