From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH v2 hmm 11/11] mm/hmm: Remove confusing comment and logic from hmm_release Date: Thu, 6 Jun 2019 20:47:28 -0700 Message-ID: <3edc47bd-e8f6-0e65-5844-d16901890637@nvidia.com> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-12-jgg@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190606184438.31646-12-jgg@ziepe.ca> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jason Gunthorpe , Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com Cc: Andrea Arcangeli , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-mm@kvack.org, Jason Gunthorpe , dri-devel@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org T24gNi82LzE5IDExOjQ0IEFNLCBKYXNvbiBHdW50aG9ycGUgd3JvdGU6Cj4gRnJvbTogSmFzb24g R3VudGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+IAo+IGhtbV9yZWxlYXNlKCkgaXMgY2FsbGVk IGV4YWN0bHkgb25jZSBwZXIgaG1tLiBvcHMtPnJlbGVhc2UoKSBjYW5ub3QKPiBhY2NpZGVudGFs bHkgdHJpZ2dlciBhbnkgYWN0aW9uIHRoYXQgd291bGQgcmVjdXJzZSBiYWNrIG9udG8KPiBobW0t Pm1pcnJvcnNfc2VtLgo+IAo+IFRoaXMgZml4ZXMgYSB1c2UgYWZ0ZXItZnJlZSByYWNlIG9mIHRo ZSBmb3JtOgo+IAo+ICAgICAgICBDUFUwICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBDUFUxCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhtbV9y ZWxlYXNlKCkKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1 cF93cml0ZSgmaG1tLT5taXJyb3JzX3NlbSk7Cj4gIGhtbV9taXJyb3JfdW5yZWdpc3RlcihtaXJy b3IpCj4gICBkb3duX3dyaXRlKCZobW0tPm1pcnJvcnNfc2VtKTsKPiAgIHVwX3dyaXRlKCZobW0t Pm1pcnJvcnNfc2VtKTsKPiAgIGtmcmVlKG1pcnJvcikKPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBtaXJyb3ItPm9wcy0+cmVsZWFzZShtaXJyb3IpCj4gCj4g VGhlIG9ubHkgdXNlciB3ZSBoYXZlIHRvZGF5IGZvciBvcHMtPnJlbGVhc2UgaXMgYW4gZW1wdHkg ZnVuY3Rpb24sIHNvIHRoaXMKPiBpcyB1bmFtYmlndW91c2x5IHNhZmUuCj4gCj4gQXMgYSBjb25z ZXF1ZW5jZSBvZiBwbHVnZ2luZyB0aGlzIHJhY2UgZHJpdmVycyBhcmUgbm90IGFsbG93ZWQgdG8K PiByZWdpc3Rlci91bnJlZ2lzdGVyIG1pcnJvcnMgZnJvbSB3aXRoaW4gYSByZWxlYXNlIG9wLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IEphc29uIEd1bnRob3JwZSA8amdnQG1lbGxhbm94LmNvbT4KPiAt LS0KPiAgbW0vaG1tLmMgfCAyOCArKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmls ZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9tbS9obW0uYyBiL21tL2htbS5jCj4gaW5kZXggNzA5ZDEzOGRkNDkwMjcuLjNhNDVkZDNk Nzc4MjQ4IDEwMDY0NAo+IC0tLSBhL21tL2htbS5jCj4gKysrIGIvbW0vaG1tLmMKPiBAQCAtMTM2 LDI2ICsxMzYsMTYgQEAgc3RhdGljIHZvaWQgaG1tX3JlbGVhc2Uoc3RydWN0IG1tdV9ub3RpZmll ciAqbW4sIHN0cnVjdCBtbV9zdHJ1Y3QgKm1tKQo+ICAJV0FSTl9PTighbGlzdF9lbXB0eSgmaG1t LT5yYW5nZXMpKTsKPiAgCW11dGV4X3VubG9jaygmaG1tLT5sb2NrKTsKPiAgCj4gLQlkb3duX3dy aXRlKCZobW0tPm1pcnJvcnNfc2VtKTsKPiAtCW1pcnJvciA9IGxpc3RfZmlyc3RfZW50cnlfb3Jf bnVsbCgmaG1tLT5taXJyb3JzLCBzdHJ1Y3QgaG1tX21pcnJvciwKPiAtCQkJCQkgIGxpc3QpOwo+ IC0Jd2hpbGUgKG1pcnJvcikgewo+IC0JCWxpc3RfZGVsX2luaXQoJm1pcnJvci0+bGlzdCk7Cj4g LQkJaWYgKG1pcnJvci0+b3BzLT5yZWxlYXNlKSB7Cj4gLQkJCS8qCj4gLQkJCSAqIERyb3AgbWly cm9yc19zZW0gc28gdGhlIHJlbGVhc2UgY2FsbGJhY2sgY2FuIHdhaXQKPiAtCQkJICogb24gYW55 IHBlbmRpbmcgd29yayB0aGF0IG1pZ2h0IGl0c2VsZiB0cmlnZ2VyIGEKPiAtCQkJICogbW11X25v dGlmaWVyIGNhbGxiYWNrIGFuZCB0aHVzIHdvdWxkIGRlYWRsb2NrIHdpdGgKPiAtCQkJICogdXMu Cj4gLQkJCSAqLwo+IC0JCQl1cF93cml0ZSgmaG1tLT5taXJyb3JzX3NlbSk7Cj4gKwlkb3duX3Jl YWQoJmhtbS0+bWlycm9yc19zZW0pOwoKVGhpcyBpcyBjbGVhbmVyIGFuZCBzaW1wbGVyLCBidXQg SSBzdXNwZWN0IGl0IGlzIGxlYWRpbmcgdG8gdGhlIGRlYWRsb2NrCnRoYXQgUmFscGggQ2FtcGJl bGwgaXMgc2VlaW5nIGluIGhpcyBkcml2ZXIgdGVzdGluZy4gKEFuZCBpbiBnZW5lcmFsLCBob2xk aW5nCmEgbG9jayBkdXJpbmcgYSBkcml2ZXIgY2FsbGJhY2sgdXN1YWxseSBsZWFkcyB0byBkZWFk bG9ja3MuKQoKUmFscGgsIGlzIHRoaXMgdGhlIG9uZT8gSXQncyB0aGUgb25seSBwbGFjZSBpbiB0 aGlzIHBhdGNoc2V0IHdoZXJlIEkgY2FuCnNlZSBhIGxvY2sgYXJvdW5kIGEgY2FsbGJhY2sgdG8g ZHJpdmVyIGNvZGUsIHRoYXQgd2Fzbid0IHRoZXJlIGJlZm9yZS4gU28KSSdtIHByZXR0eSBzdXJl IGl0IGlzIHRoZSBvbmUuLi4KCgp0aGFua3MsCi0tIApKb2huIEh1YmJhcmQKTlZJRElBCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==