From: "Christian König" <christian.koenig@amd.com>
To: Nirmoy Das <nirmoy.das@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/amdgpu: remove unnecessary checks
Date: Tue, 2 Nov 2021 08:36:46 +0100 [thread overview]
Message-ID: <3ef7b422-80f6-354d-7cba-cab59de8ca57@amd.com> (raw)
In-Reply-To: <20211022110311.128971-1-nirmoy.das@amd.com>
Am 22.10.21 um 13:03 schrieb Nirmoy Das:
> amdgpu_ttm_backend_bind() only needed for TTM_PL_TT
> and AMDGPU_PL_PREEMPT.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index d784f8d3a834..eb872fc4ad92 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -914,11 +914,6 @@ static int amdgpu_ttm_backend_bind(struct ttm_device *bdev,
> ttm->num_pages, bo_mem, ttm);
> }
>
> - if (bo_mem->mem_type == AMDGPU_PL_GDS ||
> - bo_mem->mem_type == AMDGPU_PL_GWS ||
> - bo_mem->mem_type == AMDGPU_PL_OA)
> - return -EINVAL;
> -
> if (bo_mem->mem_type != TTM_PL_TT ||
> !amdgpu_gtt_mgr_has_gart_addr(bo_mem)) {
> gtt->offset = AMDGPU_BO_INVALID_OFFSET;
prev parent reply other threads:[~2021-11-02 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 11:03 [PATCH 1/1] drm/amdgpu: remove unnecessary checks Nirmoy Das
2021-10-29 15:12 ` Das, Nirmoy
2021-11-02 7:36 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ef7b422-80f6-354d-7cba-cab59de8ca57@amd.com \
--to=christian.koenig@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox