From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harry Wentland <harry.wentland@amd.com>
Subject: Re: [PATCH] drm/amd/display: Fix potential NULL pointer dereferences
 in amdgpu_dm_atomic_commit_tail
Date: Mon, 27 Nov 2017 14:23:12 -0500
Message-ID: <3ff97f37-946a-a795-e57c-6d835e93be21@amd.com>
References: <20171127145700.GA18395@embeddedor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20171127145700.GA18395@embeddedor.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>, Alex Deucher <alexander.deucher@amd.com>, =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>, David Airlie <airlied@linux.ie>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: amd-gfx.lists.freedesktop.org

T24gMjAxNy0xMS0yNyAwOTo1NyBBTSwgR3VzdGF2byBBLiBSLiBTaWx2YSB3cm90ZToKPiBkbV9u
ZXdfY3J0Y19zdGF0ZS0+c3RyZWFtIGFuZCBkaXNjb25uZWN0ZWRfYWNydGMgYXJlIGJlaW5nIGRl
cmVmZXJlbmNlZAo+IGJlZm9yZSB0aGV5IGFyZSBudWxsIGNoZWNrZWQsIGhlbmNlIHRoZXJlIGlz
IGEgcG90ZW50aWFsIG51bGwgcG9pbnRlcgo+IGRlcmVmZXJlbmNlLgo+IAo+IEZpeCB0aGlzIGJ5
IG51bGwgY2hlY2tpbmcgc3VjaCBwb2ludGVycyBiZWZvcmUgdGhleSBhcmUgZGVyZWZlcmVuY2Vk
Lgo+IAo+IEFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQyMzc0NSAoIkRlcmVmZXJlbmNlIGJlZm9y
ZSBudWxsIGNoZWNrIikKPiBBZGRyZXNzZXMtQ292ZXJpdHktSUQ6IDE0MjM4MzMgKCJEZXJlZmVy
ZW5jZSBiZWZvcmUgbnVsbCBjaGVjayIpCj4gRml4ZXM6IGU3YjA3Y2VlZjJhNiAoImRybS9hbWQv
ZGlzcGxheTogTWVyZ2UgYW1kZ3B1X2RtX3R5cGVzIGFuZCBhbWRncHVfZG0iKQo+IEZpeGVzOiA1
NGQ3NjU3NTI0NjcgKCJkcm0vYW1kL2Rpc3BsYXk6IFVuaWZ5IGFtZGdwdV9kbSBzdGF0ZSB2YXJp
YWJsZSBuYW1pbmdzLiIpCj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBBLiBSLiBTaWx2YSA8Z2Fy
c2lsdmFAZW1iZWRkZWRvci5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxh
eS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMgfCAxMiArKysrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5n
ZWQsIDcgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYyBiL2RyaXZlcnMv
Z3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPiBpbmRleCA4ODllZDI0
Li4zYmRkMTM3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRn
cHVfZG0vYW1kZ3B1X2RtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1k
Z3B1X2RtL2FtZGdwdV9kbS5jCj4gQEAgLTQxOTAsNiArNDE5MCw5IEBAIHN0YXRpYyB2b2lkIGFt
ZGdwdV9kbV9hdG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRl
KQo+ICAKPiAgCQlkbV9uZXdfY3J0Y19zdGF0ZSA9IHRvX2RtX2NydGNfc3RhdGUobmV3X2NydGNf
c3RhdGUpOwo+ICAKPiArCQlpZiAoIWRtX25ld19jcnRjX3N0YXRlLT5zdHJlYW0pCj4gKwkJCWNv
bnRpbnVlOwo+ICsKPiAgCQl1cGRhdGVfc3RyZWFtX3NjYWxpbmdfc2V0dGluZ3MoJmRtX25ld19j
b25fc3RhdGUtPmJhc2UuY3J0Yy0+bW9kZSwKPiAgCQkJCWRtX25ld19jb25fc3RhdGUsIChzdHJ1
Y3QgZGNfc3RyZWFtX3N0YXRlICopZG1fbmV3X2NydGNfc3RhdGUtPnN0cmVhbSk7Cj4gIAo+IEBA
IC00MTk3LDkgKzQyMDAsNiBAQCBzdGF0aWMgdm9pZCBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90
YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCQlXQVJOX09OKCFzdGF0dXMp
Owo+ICAJCVdBUk5fT04oIXN0YXR1cy0+cGxhbmVfY291bnQpOwo+ICAKPiAtCQlpZiAoIWRtX25l
d19jcnRjX3N0YXRlLT5zdHJlYW0pCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAgCQkvKlRPRE8gSG93
IGl0IHdvcmtzIHdpdGggTVBPID8qLwo+ICAJCWlmICghZGNfY29tbWl0X3BsYW5lc190b19zdHJl
YW0oCj4gIAkJCQlkbS0+ZGMsCj4gQEAgLTQzMzIsOSArNDMzMiwxMSBAQCB2b2lkIGRtX3Jlc3Rv
cmVfZHJtX2Nvbm5lY3Rvcl9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCXJldHVy
bjsKPiAgCj4gIAlkaXNjb25uZWN0ZWRfYWNydGMgPSB0b19hbWRncHVfY3J0Yyhjb25uZWN0b3It
PmVuY29kZXItPmNydGMpOwo+IC0JYWNydGNfc3RhdGUgPSB0b19kbV9jcnRjX3N0YXRlKGRpc2Nv
bm5lY3RlZF9hY3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gKwlpZiAoIWRpc2Nvbm5lY3RlZF9hY3J0YykK
PiArCQlyZXR1cm47Cj4gIAo+IC0JaWYgKCFkaXNjb25uZWN0ZWRfYWNydGMgfHwgIWFjcnRjX3N0
YXRlLT5zdHJlYW0pCj4gKwlhY3J0Y19zdGF0ZSA9IHRvX2RtX2NydGNfc3RhdGUoZGlzY29ubmVj
dGVkX2FjcnRjLT5iYXNlLnN0YXRlKTsKPiArCWlmICghYWNydGNfc3RhdGUtPnN0cmVhbSkKPiAg
CQlyZXR1cm47CgpUaGlzIHBhcnQgaXMgYWxyZWFkeSBpbiBodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9hcmNoaXZlcy9hbWQtZ2Z4LzIwMTctTm92ZW1iZXIvMDE2Mzg5Lmh0bWwgb24gaXRz
IHdheSB0byBiZSBtZXJnZWQuCgpUaGUgcmVzdCBvZiB0aGUgcGF0Y2ggaXMKUmV2aWV3ZWQtYnk6
IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29tPgoKSGFycnkKCj4gIAo+ICAJ
LyoKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp
LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==