From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/6] drm/ttm: rework BO delayed delete.
Date: Tue, 11 Feb 2020 14:41:53 +0100 [thread overview]
Message-ID: <40bbab73-7258-0d89-cf41-5a57fba6015f@gmail.com> (raw)
In-Reply-To: <4C763419-ABC5-4890-BFE4-02DDAD89C0BA@amd.com>
[SNIP]
>>> + /*
>>> + * Make NO_EVICT bos immediately available to
>>> + * shrinkers, now that they are queued for
>>> + * destruction.
>>> + */
>>> + if (bo->mem.placement & TTM_PL_FLAG_NO_EVICT) {
>>> + bo->mem.placement &= ~TTM_PL_FLAG_NO_EVICT;
>>> + ttm_bo_move_to_lru_tail(bo, NULL);
>> [xh] this should be under lru lock.
Ah, yes good point.
>>
>>> + BUG_ON(bo->mem.mm_node != NULL);
>>> + ttm_tt_destroy(bo->ttm);
>> [xh] already destroy it in ttm_bo_cleanup_memtype_use.
Fixed as well.
Going to send that out with those two fixed in a minute.
Thanks,
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-02-11 13:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 15:09 Cleanup TTMs delayed delete handling Christian König
2020-02-10 15:09 ` [PATCH 1/6] drm/ttm: refine ghost BO resv criteria Christian König
2020-02-10 15:09 ` [PATCH 2/6] drm/ttm: cleanup ttm_buffer_object_transfer Christian König
2020-02-10 15:09 ` [PATCH 3/6] drm/ttm: use RCU in ttm_bo_flush_all_fences Christian König
2020-02-10 15:09 ` [PATCH 4/6] drm/ttm: rework BO delayed delete Christian König
2020-02-11 5:26 ` Pan, Xinhui
2020-02-11 5:43 ` Pan, Xinhui
2020-02-11 13:41 ` Christian König [this message]
2020-02-10 15:09 ` [PATCH 5/6] drm/ttm: replace dma_resv object on deleted BOs v2 Christian König
2020-02-11 14:14 ` Daniel Vetter
2020-02-11 15:02 ` Pan, Xinhui
2020-02-11 15:23 ` Christian König
2020-02-11 15:36 ` Daniel Vetter
2020-02-11 15:15 ` Christian König
2020-02-10 15:09 ` [PATCH 6/6] drm/ttm: individualize resv objects before calling release_notify Christian König
2020-02-11 11:06 ` Cleanup TTMs delayed delete handling Pan, Xinhui
2020-02-11 11:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40bbab73-7258-0d89-cf41-5a57fba6015f@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Xinhui.Pan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox