From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Andi Kleen <andi@firstfloor.org>, alexander.deucher@amd.com
Cc: Andi Kleen <ak@linux.intel.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] radeon: Use only a single work queue thread for crt
Date: Sun, 6 Sep 2020 10:53:52 +0200 [thread overview]
Message-ID: <47558836-612d-75e3-c4a8-7b8baf53036d@gmail.com> (raw)
In-Reply-To: <20190803000908.5310-1-andi@firstfloor.org>
Am 03.08.19 um 02:09 schrieb Andi Kleen:
> From: Andi Kleen <ak@linux.intel.com>
>
> I got tired of seeing a lot of radeon-crt kernel threads in ps on my
> workstation, one for each CPU and one for each display, which never use any CPU time.
> Surely a single kernel thread is enough to handle the display.
NAK, radeon blocks inside the kernel thread and those need to run in
parallel or otherwise the hardware can hang.
Christian.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index bd52f15e6330..fb0ca688f6fe 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -682,7 +682,7 @@ static void radeon_crtc_init(struct drm_device *dev, int index)
>
> drm_mode_crtc_set_gamma_size(&radeon_crtc->base, 256);
> radeon_crtc->crtc_id = index;
> - radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0);
> + radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI|WQ_UNBOUND, 0);
> rdev->mode_info.crtcs[index] = radeon_crtc;
>
> if (rdev->family >= CHIP_BONAIRE) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-09-06 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 0:09 [PATCH] radeon: Use only a single work queue thread for crt Andi Kleen
2020-09-05 21:56 ` Paul Menzel
2020-09-06 8:53 ` Christian König [this message]
2020-09-06 16:02 ` Jan Vesely
2020-09-07 8:25 ` Christian König
2020-09-06 23:47 ` Dave Airlie
2020-09-07 8:24 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47558836-612d-75e3-c4a8-7b8baf53036d@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=ak@linux.intel.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andi@firstfloor.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox