From: "Zhang, Jerry(Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
<ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: fix AGP location with VRAM at 0x0
Date: Tue, 9 Oct 2018 14:45:09 +0800 [thread overview]
Message-ID: <4ae2fc7e-e1f8-19df-4c48-b182e671cad5@amd.com> (raw)
In-Reply-To: <20181004090210.1904-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
On 10/04/2018 05:02 PM, Christian König wrote:
> That also simplifies handling quite a bit.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index 9a5b252784a1..999e15945355 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -200,16 +200,13 @@ void amdgpu_gmc_agp_location(struct amdgpu_device *adev, struct amdgpu_gmc *mc)
> }
>
> if (size_bf > size_af) {
> - mc->agp_start = mc->fb_start > mc->gart_start ?
> - mc->gart_end + 1 : 0;
> + mc->agp_start = (mc->fb_start - size_bf) & sixteen_gb_mask;
> mc->agp_size = size_bf;
> } else {
> - mc->agp_start = (mc->fb_start > mc->gart_start ?
> - mc->fb_end : mc->gart_end) + 1,
> + mc->agp_start = ALIGN(mc->fb_end + 1, sixteen_gb);
> mc->agp_size = size_af;
> }
>
> - mc->agp_start = ALIGN(mc->agp_start, sixteen_gb);
> mc->agp_end = mc->agp_start + mc->agp_size - 1;
> dev_info(adev->dev, "AGP: %lluM 0x%016llX - 0x%016llX\n",
> mc->agp_size >> 20, mc->agp_start, mc->agp_end);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-10-09 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 9:02 [PATCH] drm/amdgpu: fix AGP location with VRAM at 0x0 Christian König
[not found] ` <20181004090210.1904-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-10-08 11:35 ` Christian König
2018-10-09 6:45 ` Zhang, Jerry(Junwei) [this message]
2018-10-09 10:47 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae2fc7e-e1f8-19df-4c48-b182e671cad5@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox