AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Grodzovsky, Andrey" <Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org>
To: "Lou, Wentao" <Wentao.Lou-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Liu, Monk" <Monk.Liu-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov
Date: Thu, 24 Jan 2019 15:48:10 +0000	[thread overview]
Message-ID: <4b40d29e-6ab1-18b9-aa87-eec7abc89029@amd.com> (raw)
In-Reply-To: <BYAPR12MB2742ED87810B57383393AACF839A0-ZGDeBxoHBPmbrehcvEBedAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>



On 01/24/2019 02:18 AM, Lou, Wentao wrote:
> ++Monk
>
> Yes amdgpu_lockup_timeout was forced to 10000 in current code, that means amdgpu_device_gpu_recover was not triggered inside xgpu_ai_mailbox_flr_work.
> For sriov, amdgpu_device_gpu_recover was already called by amdgpu_job_timedout, unexpected amdgpu_device_gpu_recover called by xgpu_ai_mailbox_flr_work would make vk-cts failed.

So if I understand correctly your goal is to avoid the gpu recover 
triggered from xgpu_ai_mailbox_flr_work, bot I don't understand how 
adding 'amdgpu_lockup_timeout == 0' achieves that ?

Andrey

>
> -----Original Message-----
> From: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>
> Sent: Thursday, January 24, 2019 12:27 AM
> To: Lou, Wentao <Wentao.Lou@amd.com>; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov
>
>
>
> On 01/23/2019 04:50 AM, wentalou wrote:
>> sriov's gpu_recover inside xgpu_ai_mailbox_flr_work would cause duplicate recover in TDR.
>> TDR's gpu_recover would be triggered by amdgpu_job_timedout, that
>> could avoid vk-cts failure by unexpected recover.
>>
>> Change-Id: Ifcba4ac43a0229ae19061aad3b0ddc96957ff9c6
>> Signed-off-by: wentalou <Wentao.Lou@amd.com>
>> ---
>>    drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
>> b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
>> index b11a1c17..f227633 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
>> @@ -266,7 +266,7 @@ static void xgpu_ai_mailbox_flr_work(struct work_struct *work)
>>    	}
>>    
>>    	/* Trigger recovery for world switch failure if no TDR */
>> -	if (amdgpu_device_should_recover_gpu(adev))
>> +	if (amdgpu_device_should_recover_gpu(adev) && amdgpu_lockup_timeout
>> +== 0)
> Not sure I fully understand the intent here but amdgpu_lockup_timeout == 0 is forced to 10000 in amdgpu_device_check_arguments and hence not an indication of disabled gpu recover - it will still happen.
>
> Andrey
>
>>    		amdgpu_device_gpu_recover(adev, NULL);
>>    }
>>    
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-01-24 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23  9:50 [PATCH] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov wentalou
     [not found] ` <1548237051-31881-1-git-send-email-Wentao.Lou-5C7GfCeVMHo@public.gmane.org>
2019-01-23 16:26   ` Grodzovsky, Andrey
     [not found]     ` <609eec03-4d51-c2e2-8e1f-aefb996c5efa-5C7GfCeVMHo@public.gmane.org>
2019-01-24  7:18       ` Lou, Wentao
     [not found]         ` <BYAPR12MB2742ED87810B57383393AACF839A0-ZGDeBxoHBPmbrehcvEBedAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-01-24 15:48           ` Grodzovsky, Andrey [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-30  3:16 wentalou
     [not found] ` <1548818214-18078-1-git-send-email-Wentao.Lou-5C7GfCeVMHo@public.gmane.org>
2019-01-30 15:19   ` Grodzovsky, Andrey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b40d29e-6ab1-18b9-aa87-eec7abc89029@amd.com \
    --to=andrey.grodzovsky-5c7gfcevmho@public.gmane.org \
    --cc=Monk.Liu-5C7GfCeVMHo@public.gmane.org \
    --cc=Wentao.Lou-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox