Re: [v4 0/6] Fix several bugs in error handling during device probe

[Mario Limonciello <mario.limonciello@amd.com>]

Just a minor nit on this cover letter; you have it listed as [v4 0/6] 
but there are only 5 patches in the series in this version so the cover 
letter title should be updated too.

On 1/9/2025 20:08, Jiang Liu wrote:
> This patchset tries to fix several memory leakages/invalid memory
> accesses on error handling path during GPU driver loading/unloading.
> They applies to:
> https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
> 
> v4:
> 1) drop patch 1 in v3
> 2) split out amdxcp related change into a dedicated patch
> 3) use `guard(mutex)` instead of mutex_lock/unlock().
> 4) move patch 6 in v3 to next patch set
> 
> v3:
> 1) drop first patch of v2
> 2) rework the 0003/0004 patches of v2 according to review comments
> 3) add patch 0004 to fix possible resource leakage in amdgpu_pci_probe()
> 
> v2:
> 1) rebased to https://gitlab.freedesktop.org/agd5f/linux.git branch
>     amd-staging-drm-next.
> 2) removed the first patch, which is unnecessary.
> 3) add amdgpu_xcp_drm_dev_free() in patch 0003 to enhance amdxcp
>     driver to better support device remove and error handling.
> 4) reworked patch 0005 to fix it in amdgpu instead of drm core.
> 
> Jiang Liu (5):
>    drm/amdgpu: clear adev->in_suspend flag when fails to suspend
>    drm/amdxcp: introduce new API amdgpu_xcp_drm_dev_free()
>    drm/amdgpu: fix use after free bug related to
>      amdgpu_driver_release_kms()
>    drm/amdgpu: enhance error handling in function amdgpu_pci_probe()
>    drm/amdgpu: fix invalid memory access in amdgpu_fence_driver_sw_fini()
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c  | 18 ++++--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c     | 14 +++--
>   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c   |  4 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c     | 70 +++++++++++++++++----
>   drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.h     |  4 +-
>   drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c | 65 ++++++++++++++++---
>   drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.h |  1 +
>   7 files changed, 142 insertions(+), 34 deletions(-)
>