From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH v3 hmm 05/11] mm/hmm: Remove duplicate condition test before wait_event_timeout Date: Fri, 7 Jun 2019 18:32:38 -0700 Message-ID: <4c1a18b7-6dcb-7ce3-c178-9efd255e8056@nvidia.com> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190606184438.31646-6-jgg@ziepe.ca> <86962e22-88b1-c1bf-d704-d5a5053fa100@nvidia.com> <20190607133107.GF14802@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190607133107.GF14802@ziepe.ca> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jason Gunthorpe Cc: Andrea Arcangeli , Ralph Campbell , linux-rdma@vger.kernel.org, Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , amd-gfx@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org T24gNi83LzE5IDY6MzEgQU0sIEphc29uIEd1bnRob3JwZSB3cm90ZToKPiBUaGUgd2FpdF9ldmVu dF90aW1lb3V0IG1hY3JvIGFscmVhZHkgdGVzdHMgdGhlIGNvbmRpdGlvbiBhcyBpdHMgZmlyc3QK PiBhY3Rpb24sIHNvIHRoZXJlIGlzIG5vIHJlYXNvbiB0byBvcGVuIGNvZGUgYW5vdGhlciB2ZXJz aW9uIG9mIHRoaXMsIGFsbAo+IHRoYXQgZG9lcyBpcyBza2lwIHRoZSBtaWdodF9zbGVlcCgpIGRl YnVnZ2luZyBpbiBjb21tb24gY2FzZXMsIHdoaWNoIGlzCj4gbm90IGhlbHBmdWwuCj4gCj4gRnVy dGhlciwgYmFzZWQgb24gcHJpb3IgcGF0Y2hlcywgd2UgY2FuIG5vdyBzaW1wbGlmeSB0aGUgcmVx dWlyZWQgY29uZGl0aW9uCj4gdGVzdDoKPiAgLSBJZiByYW5nZSBpcyB2YWxpZCBtZW1vcnkgdGhl biBzbyBpcyByYW5nZS0+aG1tCj4gIC0gSWYgaG1tX3JlbGVhc2UoKSBoYXMgcnVuIHRoZW4gcmFu Z2UtPnZhbGlkIGlzIHNldCB0byBmYWxzZQo+ICAgIGF0IHRoZSBzYW1lIHRpbWUgYXMgZGVhZCwg c28gbm8gcmVhc29uIHRvIGNoZWNrIGJvdGguCj4gIC0gQSB2YWxpZCBobW0gaGFzIGEgdmFsaWQg aG1tLT5tbS4KPiAKPiBBbGxvd2luZyB0aGUgcmV0dXJuIHZhbHVlIG9mIHdhaXRfZXZlbnRfdGlt ZW91dCgpIChhbG9uZyB3aXRoIGl0cyBpbnRlcm5hbAo+IGJhcnJpZXJzKSB0byBjb21wdXRlIHRo ZSByZXN1bHQgb2YgdGhlIGZ1bmN0aW9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphc29uIEd1bnRo b3JwZSA8amdnQG1lbGxhbm94LmNvbT4KPiAtLS0KCgogICAgUmV2aWV3ZWQtYnk6IEpvaG4gSHVi YmFyZCA8amh1YmJhcmRAbnZpZGlhLmNvbT4KCgp0aGFua3MsCi0tIApKb2huIEh1YmJhcmQKTlZJ RElBCgoKCj4gdjMKPiAtIFNpbXBsaWZ5IHRoZSB3YWl0X2V2ZW50X3RpbWVvdXQgdG8gbm90IGNo ZWNrIHZhbGlkCj4gLS0tCj4gIGluY2x1ZGUvbGludXgvaG1tLmggfCAxMyArKy0tLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2htbS5oIGIvaW5jbHVkZS9saW51eC9obW0uaAo+ IGluZGV4IDFkOTdiNmQ2MmM1YmNmLi4yNmU3YzQ3NzQ5MGM0ZSAxMDA2NDQKPiAtLS0gYS9pbmNs dWRlL2xpbnV4L2htbS5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9obW0uaAo+IEBAIC0yMDksMTcg KzIwOSw4IEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyBobW1fcmFuZ2VfcGFnZV9zaXpl KGNvbnN0IHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlKQo+ICBzdGF0aWMgaW5saW5lIGJvb2wgaG1t X3JhbmdlX3dhaXRfdW50aWxfdmFsaWQoc3RydWN0IGhtbV9yYW5nZSAqcmFuZ2UsCj4gIAkJCQkJ ICAgICAgdW5zaWduZWQgbG9uZyB0aW1lb3V0KQo+ICB7Cj4gLQkvKiBDaGVjayBpZiBtbSBpcyBk ZWFkID8gKi8KPiAtCWlmIChyYW5nZS0+aG1tID09IE5VTEwgfHwgcmFuZ2UtPmhtbS0+ZGVhZCB8 fCByYW5nZS0+aG1tLT5tbSA9PSBOVUxMKSB7Cj4gLQkJcmFuZ2UtPnZhbGlkID0gZmFsc2U7Cj4g LQkJcmV0dXJuIGZhbHNlOwo+IC0JfQo+IC0JaWYgKHJhbmdlLT52YWxpZCkKPiAtCQlyZXR1cm4g dHJ1ZTsKPiAtCXdhaXRfZXZlbnRfdGltZW91dChyYW5nZS0+aG1tLT53cSwgcmFuZ2UtPnZhbGlk IHx8IHJhbmdlLT5obW0tPmRlYWQsCj4gLQkJCSAgIG1zZWNzX3RvX2ppZmZpZXModGltZW91dCkp Owo+IC0JLyogUmV0dXJuIGN1cnJlbnQgdmFsaWQgc3RhdHVzIGp1c3QgaW4gY2FzZSB3ZSBnZXQg bHVja3kgKi8KPiAtCXJldHVybiByYW5nZS0+dmFsaWQ7Cj4gKwlyZXR1cm4gd2FpdF9ldmVudF90 aW1lb3V0KHJhbmdlLT5obW0tPndxLCByYW5nZS0+dmFsaWQsCj4gKwkJCQkgIG1zZWNzX3RvX2pp ZmZpZXModGltZW91dCkpICE9IDA7Cj4gIH0KPiAgCj4gIC8qCj4gCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=