AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Mangesh Gadre <Mangesh.Gadre@amd.com>,
	amd-gfx@lists.freedesktop.org, Hawking.Zhang@amd.com
Cc: Le Ma <le.ma@amd.com>
Subject: Re: [PATCH] drm/amdgpu: enable gfx clock gating for gfx950
Date: Thu, 30 Jan 2025 15:09:19 +0530	[thread overview]
Message-ID: <4c335137-d809-454f-b2fe-e849ae6cdca4@amd.com> (raw)
In-Reply-To: <20250130073141.2219121-1-Mangesh.Gadre@amd.com>



On 1/30/2025 1:01 PM, Mangesh Gadre wrote:
> From: Le Ma <le.ma@amd.com>
> 
> The CGCG residency can be observed with the change.
> 
> Signed-off-by: Le Ma <le.ma@amd.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>

This can be dropped, no longer needed after -

"drm/amdgpu: Clean up GFX v9.4.3 IP version checks"

Thanks,
Lijo

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index 2ba185875baa..28a2310a049e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -2798,6 +2798,7 @@ static int gfx_v9_4_3_set_clockgating_state(struct amdgpu_ip_block *ip_block,
>  	switch (amdgpu_ip_version(adev, GC_HWIP, 0)) {
>  	case IP_VERSION(9, 4, 3):
>  	case IP_VERSION(9, 4, 4):
> +	case IP_VERSION(9, 5, 0):
>  		for (i = 0; i < num_xcc; i++)
>  			gfx_v9_4_3_xcc_update_gfx_clock_gating(
>  				adev, state == AMD_CG_STATE_GATE, i);


      reply	other threads:[~2025-01-30  9:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  7:31 [PATCH] drm/amdgpu: enable gfx clock gating for gfx950 Mangesh Gadre
2025-01-30  9:39 ` Lazar, Lijo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c335137-d809-454f-b2fe-e849ae6cdca4@amd.com \
    --to=lijo.lazar@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Mangesh.Gadre@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=le.ma@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox