AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: dri-devel@lists.freedesktop.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	kernel@collabora.com, Anthony Koo <Anthony.Koo@amd.com>,
	linux-samsung-soc@vger.kernel.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	David Francis <David.Francis@amd.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-rockchip@lists.infradead.org, Kukjin Kim <kgene@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Uma Shankar <uma.shankar@intel.com>,
	freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	Jonas Karlman <jonas@kwiboo.se>, Leo Li <sunpeng.li@amd.com>,
	linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	Alexios Zavras <alexios.zavras@intel.com>,
	Mamta Shukla <mamtashukla555@gmail.com>,
	linux-me
Subject: [PATCH RESEND 10/14] drm/vc4: Provide ddc symlink in connector sysfs directory
Date: Mon, 26 Aug 2019 21:25:52 +0200	[thread overview]
Message-ID: <4e2c062c45c4bb63a6baaeef0ef229f85abd400b.1566845537.git.andrzej.p@collabora.com> (raw)
In-Reply-To: <cover.1566845537.git.andrzej.p@collabora.com>
In-Reply-To: <cover.1566845537.git.andrzej.p@collabora.com>

Use the ddc pointer provided by the generic connector.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index ee7d4e7b0ee3..eb57c907a256 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -267,7 +267,8 @@ static const struct drm_connector_helper_funcs vc4_hdmi_connector_helper_funcs =
 };
 
 static struct drm_connector *vc4_hdmi_connector_init(struct drm_device *dev,
-						     struct drm_encoder *encoder)
+						     struct drm_encoder *encoder,
+						     struct i2c_adapter *ddc)
 {
 	struct drm_connector *connector;
 	struct vc4_hdmi_connector *hdmi_connector;
@@ -281,8 +282,10 @@ static struct drm_connector *vc4_hdmi_connector_init(struct drm_device *dev,
 
 	hdmi_connector->encoder = encoder;
 
-	drm_connector_init(dev, connector, &vc4_hdmi_connector_funcs,
-			   DRM_MODE_CONNECTOR_HDMIA);
+	drm_connector_init_with_ddc(dev, connector,
+				    &vc4_hdmi_connector_funcs,
+				    DRM_MODE_CONNECTOR_HDMIA,
+				    ddc);
 	drm_connector_helper_add(connector, &vc4_hdmi_connector_helper_funcs);
 
 	/* Create and attach TV margin props to this connector. */
@@ -1395,7 +1398,8 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
 			 DRM_MODE_ENCODER_TMDS, NULL);
 	drm_encoder_helper_add(hdmi->encoder, &vc4_hdmi_encoder_helper_funcs);
 
-	hdmi->connector = vc4_hdmi_connector_init(drm, hdmi->encoder);
+	hdmi->connector =
+		vc4_hdmi_connector_init(drm, hdmi->encoder, hdmi->ddc);
 	if (IS_ERR(hdmi->connector)) {
 		ret = PTR_ERR(hdmi->connector);
 		goto err_destroy_encoder;
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-08-26 19:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 19:25 [PATCH RESEND 00/14] Next round of associating ddc adapters with connectors Andrzej Pietrasiewicz
2019-08-26 19:25 ` [PATCH RESEND 01/14] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message Andrzej Pietrasiewicz
2019-08-26 19:25 ` [PATCH RESEND 02/14] drm/radeon: Provide ddc symlink in connector sysfs directory Andrzej Pietrasiewicz
2019-08-27 14:12   ` Alex Deucher
2019-08-26 19:25 ` [PATCH RESEND 04/14] drm/exynos: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
2019-08-26 19:25 ` [PATCH RESEND 05/14] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory Andrzej Pietrasiewicz
     [not found]   ` <4cad24dde4508cec17483f983da08226ba7e48b0.1566845537.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-08-26 22:15     ` Heiko Stuebner
     [not found] ` <cover.1566845537.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-08-26 19:25   ` [PATCH RESEND 03/14] drm/amdgpu: Provide ddc symlink in dm connector's " Andrzej Pietrasiewicz
     [not found]     ` <40293fa4e619d1d1af213a076b1d03440e50c56c.1566845537.git.andrzej.p-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-08-27 14:06       ` Harry Wentland
2019-08-26 19:25   ` [PATCH RESEND 06/14] drm: rockchip: Provide ddc symlink in inno_hdmi " Andrzej Pietrasiewicz
2019-08-26 19:25   ` [PATCH RESEND 07/14] drm/msm/hdmi: Provide ddc symlink in hdmi connector " Andrzej Pietrasiewicz
2019-11-06 15:58     ` Sean Paul
2019-11-06 15:58       ` Sean Paul
2019-08-26 19:25   ` [PATCH RESEND 14/14] drm/i915: " Andrzej Pietrasiewicz
2019-08-26 19:25 ` [PATCH RESEND 08/14] drm/mediatek: " Andrzej Pietrasiewicz
2019-08-26 19:25 ` [PATCH RESEND 09/14] drm/tegra: Provide ddc symlink in output " Andrzej Pietrasiewicz
2019-08-26 19:25 ` Andrzej Pietrasiewicz [this message]
2019-08-26 19:25 ` [PATCH RESEND 11/14] drm: zte: Provide ddc symlink in hdmi " Andrzej Pietrasiewicz
2019-08-26 19:25 ` [PATCH RESEND 12/14] drm: zte: Provide ddc symlink in vga " Andrzej Pietrasiewicz
2019-08-26 19:25 ` [PATCH RESEND 13/14] drm/tilcdc: Provide ddc symlink in " Andrzej Pietrasiewicz
2019-09-18 14:01 ` [PATCH RESEND 00/14] Next round of associating ddc adapters with connectors Andrzej Pietrasiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e2c062c45c4bb63a6baaeef0ef229f85abd400b.1566845537.git.andrzej.p@collabora.com \
    --to=andrzej.p@collabora.com \
    --cc=Anthony.Koo@amd.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=David.Francis@amd.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=alexios.zavras@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonas@kwiboo.se \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@collabora.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mamtashukla555@gmail.com \
    --cc=narmstrong@baylibre.com \
    --cc=sunpeng.li@amd.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox