From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34881CD4F52 for ; Mon, 18 May 2026 11:07:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5325810E7AC; Mon, 18 May 2026 11:07:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="n8mZFo3O"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA8CE10E4B9; Mon, 18 May 2026 11:07:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Cc:To:From:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HGWfEP/Ao03fUy086zoke2HPPDQ8UgWiCz5qzSZN+vI=; b=n8mZFo3OEqk9W3nskKrFueSUXU TBUQwCqWE58bFYXR4g+5wcTYc3DU9HSg6KrGVzQbVkU/kPFXEpsrt5rBDlY3dfG9tOGeD2rppkKay 23v+NQDO2ddBdlORkKWqSEyi0RxwBU+58ngOel1Auf3jZJ/1Y2ZnuMgzkGhg1zpEkx/EuTemJPMnA Yb4sAbelJN0e5yisf7jsZtWx89HYXfz2fdPiHFPbTTyrwD29hFSCFfoMsP6xxATwFqKUKRBvjX9a7 WKXDGAJxJSOAY4lmQFAf53OwVWjL6OBIuBSvqONs33ut2BmBwPCdO+Uqig92XAgRQGbo5apddS1GO WQvKxDzA==; Received: from [79.117.146.159] (helo=[192.168.1.135]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1wOvoE-002aO7-T9; Mon, 18 May 2026 13:06:54 +0200 Message-ID: <4fba5085-07b4-4ccd-b2d3-256b65bef159@igalia.com> Date: Mon, 18 May 2026 13:06:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/6] drm/atomic: track individual colorop updates From: Melissa Wen To: airlied@gmail.com, alexander.deucher@amd.com, christian.koenig@amd.com, harry.wentland@amd.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, simona@ffwll.ch, siqueira@igalia.com, sunpeng.li@amd.com, tzimmermann@suse.de Cc: Alex Hung , Simon Ser , Uma Shankar , Chaitanya Kumar Borah , Xaver Hugl , Pekka Paalanen , Louis Chauvet , Matthew Schwartz , amd-gfx@lists.freedesktop.org, kernel-dev@igalia.com, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20260506192633.16066-1-mwen@igalia.com> Content-Language: en-US In-Reply-To: <20260506192633.16066-1-mwen@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 06/05/2026 21:23, Melissa Wen wrote: > This series aims to track updates for each individual color operation, > allowing the driver to react accordingly. > > - Patches 1 and 2 make colorop update process more consistent and > optimized by only keeping colorop states from active color pipelines. > > - Patches 3 and 4 make lut1d_interpolation and lut3d_interpolation > colorops correctly behave as mutable, handling their changes via > drm_colorop_state. > > - Finally, patches 5 and 6 track colorop updates of a given plane color > pipeline by setting plane `color_mgmt_changed` flag, similar to what > is done for tracking CRTC color mgmt property changes with CRTC > `color_mgmt_changed` flag. The flag also tracks when a different color > pipeline is set to a given plane. That way, the driver can react > accordingly and update their color blocks. > > It also fixes shaper/3D LUT updates when changing night mode settings on > gamescope with a custom branch that supports `COLOR_PIPELINE`: > - https://github.com/ValveSoftware/gamescope/pull/2113 Hey, Chaitanya, Alex H. and Harry, Would you have some time to review this series? I kept r-b from Harry in the last two patches that fix night mode persistence on AMD, but they depend on the first four patches that address Chaitanya's suggestions for optimizing colorop updates by active pipeline and also make LUT interpolation properties correctly behave as mutable. Thanks in advance, Melissa > > v1: https://lore.kernel.org/dri-devel/20260318162348.299807-1-mwen@igalia.com/ > Changes: > - include linux types for function's bool return type (kernel bot on MSM > driver) > - add Harry's r-b tags > > v2: https://lore.kernel.org/dri-devel/20260323131942.494217-1-mwen@igalia.com/ > Changes: > - [NEW] two patches to only consider colorop updates from active color > pipelines (Chaitanya) > - [NEW] make lut interpolation properties mutable + Alex H patch for > kernel docs > - track lut(1/3)d_interpolation updates (Chaitanya) > - rebase changes according to new patches > > v3: https://lore.kernel.org/dri-devel/20260403135909.214378-1-mwen@igalia.com/ > Changes: rebase on drm-misc-next > > v4: https://lore.kernel.org/dri-devel/20260501132527.522320-1-mwen@igalia.com/ > Changes: fix kernel doc (kernel bot) > > Melissa Wen > > Alex Hung (1): > drm/colorop: Remove read-only comments from interpolation fields > > Melissa Wen (5): > drm/atomic: only add colorop state from active color pipeline > drm/atomic: don't set colorop properties of inactive color pipelines > drm/colorop: make lut(1/3)d_interpolation mutable > drm/atomic: track individual colorop updates > drm/amd/display: use plane color_mgmt_changed to track colorop changes > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- > drivers/gpu/drm/drm_atomic.c | 43 +++++---- > drivers/gpu/drm/drm_atomic_helper.c | 9 +- > drivers/gpu/drm/drm_atomic_uapi.c | 93 +++++++++++++++---- > drivers/gpu/drm/drm_colorop.c | 16 +++- > include/drm/drm_atomic.h | 2 +- > include/drm/drm_atomic_uapi.h | 4 +- > include/drm/drm_colorop.h | 34 ++++--- > 8 files changed, 136 insertions(+), 71 deletions(-) >