AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: amd-gfx@lists.freedesktop.org, Alexander.Deucher@amd.com,
	Mario Limonciello <mario.limonciello@amd.com>,
	Ivan Lipski <ivan.lipski@amd.com>,
	Harry Wentland <harry.wentland@amd.com>
Cc: Matthew Schwartz <matthew.schwartz@linux.dev>
Subject: Re: [PATCH] drm/amd/display: Only poll analog connectors
Date: Mon, 19 Jan 2026 20:06:12 +0100	[thread overview]
Message-ID: <5021716.OV4Wx5bFTl@timur-hyperion> (raw)
In-Reply-To: <47aaaa83-012c-45bb-8f51-8f09c0ad20ce@amd.com>

On Monday, January 19, 2026 6:21:40 PM Central European Standard Time Harry 
Wentland wrote:
> On 2026-01-18 08:03, Timur Kristóf wrote:
> > Analog connectors may be hot-plugged unlike other connector
> > types that don't support HPD.
> > 
> > Stop DRM from polling other connector types that don't
> > support HPD, such as eDP, LVDS, etc. These were wrongly
> > polled when analog connector support was added,
> > causing issues with the seamless boot process.
> > 
> > Fixes: c4f3f114e73c ("drm/amd/display: Poll analog connectors (v3)")
> > Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
> > Reported-by: Matthew Schwartz <matthew.schwartz@linux.dev>
> > ---
> > 
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c index
> > 0a2a3f233a0e..e7b0928bd3db 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> > @@ -915,13 +915,19 @@ void amdgpu_dm_hpd_init(struct amdgpu_device *adev)
> > 
> >  		struct amdgpu_dm_connector *amdgpu_dm_connector;
> >  		const struct dc_link *dc_link;
> > 
> > -		use_polling |= connector->polled != 
DRM_CONNECTOR_POLL_HPD;
> > -
> > 
> >  		if (connector->connector_type == 
DRM_MODE_CONNECTOR_WRITEBACK)
> >  		
> >  			continue;
> >  		
> >  		amdgpu_dm_connector = 
to_amdgpu_dm_connector(connector);
> > 
> > +		/*
> > +		 * Analog connectors may be hot-plugged unlike other 
connector
> > +		 * types that don't support HPD. Only poll analog 
connectors.
> > +		 */
> > +		use_polling |=
> > +			amdgpu_dm_connector->dc_link &&
> > +			
dc_connector_supports_analog(amdgpu_dm_connector->dc_link->link_id.id)
> > ;
> 
> Why isn't the aconnector->base.polled assignment in
> amdgpu_dm_connector_init_helper doing the trick?
> 
> Harry

Hi Harry,

The issue is that checking "connector->polled != DRM_CONNECTOR_POLL_HPD" will 
also match connectors that don't support hotplugging, such as eDP, LVDS etc.

amdgpu_dm_connector_init_helper is working correctly, it doesn't set the 
DRM_CONNECTOR_POLL_HPD flag for neither analog connectors, nor eDP, LVDS, etc. 
which is correct. The problem is with this check in amdgpu_dm_hpd_init.

Best regards,
Timur

> 
> > +
> > 
> >  		dc_link = amdgpu_dm_connector->dc_link;
> >  		
> >  		/*





  reply	other threads:[~2026-01-19 19:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-18 13:03 [PATCH] drm/amd/display: Only poll analog connectors Timur Kristóf
2026-01-19 16:46 ` Mario Limonciello (AMD) (kernel.org)
2026-01-19 17:21 ` Harry Wentland
2026-01-19 19:06   ` Timur Kristóf [this message]
2026-01-19 19:23     ` Harry Wentland
2026-01-19 19:48       ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5021716.OV4Wx5bFTl@timur-hyperion \
    --to=timur.kristof@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=ivan.lipski@amd.com \
    --cc=mario.limonciello@amd.com \
    --cc=matthew.schwartz@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox