AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"Chen, Jiqian" <Jiqian.Chen@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	Samuel Pitoiset <samuel.pitoiset@gmail.com>,
	Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
	"Huang, Ray" <Ray.Huang@amd.com>,
	 "Huang, Trigger" <Trigger.Huang@amd.com>
Subject: Re: [PATCH v2 1/1] drm/amdgpu/gfx9: Fix Ring and IB test fail after mode2
Date: Fri, 12 Jun 2026 13:19:45 +0200	[thread overview]
Message-ID: <5074099.OV4Wx5bFTl@timur-hyperion> (raw)
In-Reply-To: <BL1PR12MB584907E9C1F69772EA27AE91E7182@BL1PR12MB5849.namprd12.prod.outlook.com>

Hi,

> > Yes, I think the checks may not be needed or need to be adjusted.
> 
> I am not sure if removing the checks can cause new issues in other APUs or
> dGPUs that don't have this issue. Per our tests, GPUs that use Mode1 don't
> have this issue.
> Is disabling HQD harmless even for GPUs that are not experiencing this
> issue?

It's OK if your patch only addresses the issue on the APU.
We can always revisit it later if/when someone needs this for other GPUs.

I suspect that if anyone were interested in using IP block soft reset on a 
Vega dGPU, then probably they'd find the exact same issue.

Best regards,
Timur



      reply	other threads:[~2026-06-12 11:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11  5:57 [PATCH v2 1/1] drm/amdgpu/gfx9: Fix Ring and IB test fail after mode2 Jiqian Chen
2026-06-11  6:26 ` Huang Rui
2026-06-11  7:09   ` Lazar, Lijo
2026-06-11  7:42     ` Huang Rui
2026-06-11 20:26 ` Timur Kristóf
2026-06-12  6:56   ` Chen, Jiqian
2026-06-12  7:48     ` Timur Kristóf
2026-06-12  8:22       ` Chen, Jiqian
2026-06-12 11:19         ` Timur Kristóf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5074099.OV4Wx5bFTl@timur-hyperion \
    --to=timur.kristof@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=Jiqian.Chen@amd.com \
    --cc=Ray.Huang@amd.com \
    --cc=Trigger.Huang@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=samuel.pitoiset@gmail.com \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox