Re: [PATCH libdrm 1/3] amdgpu: remove invalid check in amdgpu_bo_alloc

["Zhang, Jerry(Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>]

On 09/14/2018 09:09 PM, Christian König wrote:
> The heap is checked by the kernel and not libdrm, to make it even worse
> it prevented allocating resources other than VRAM and GTT.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>

> ---
>   amdgpu/amdgpu_bo.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index 6a95929c..34904e38 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -74,19 +74,14 @@ int amdgpu_bo_alloc(amdgpu_device_handle dev,
>   		    amdgpu_bo_handle *buf_handle)
>   {
>   	union drm_amdgpu_gem_create args;
> -	unsigned heap = alloc_buffer->preferred_heap;
> -	int r = 0;
> -
> -	/* It's an error if the heap is not specified */
> -	if (!(heap & (AMDGPU_GEM_DOMAIN_GTT | AMDGPU_GEM_DOMAIN_VRAM)))
> -		return -EINVAL;
> +	int r;
>   
>   	memset(&args, 0, sizeof(args));
>   	args.in.bo_size = alloc_buffer->alloc_size;
>   	args.in.alignment = alloc_buffer->phys_alignment;
>   
>   	/* Set the placement. */
> -	args.in.domains = heap;
> +	args.in.domains = alloc_buffer->preferred_heap;
>   	args.in.domain_flags = alloc_buffer->flags;
>   
>   	/* Allocate the buffer with the preferred heap. */

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx