From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFC7C433FE for ; Wed, 3 Nov 2021 19:25:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0270A60041 for ; Wed, 3 Nov 2021 19:25:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0270A60041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D097A2BF; Wed, 3 Nov 2021 19:25:25 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 364FA7A2B6; Wed, 3 Nov 2021 19:25:24 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="231825312" X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="231825312" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 12:25:23 -0700 X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="729748847" Received: from badunne-mobl5.ger.corp.intel.com (HELO [10.252.16.100]) ([10.252.16.100]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 12:25:21 -0700 Message-ID: <55adb714-45f9-5af5-33df-ce4f4526a8c8@intel.com> Date: Wed, 3 Nov 2021 19:25:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 8/8] drm/amdgpu: add drm buddy support to amdgpu Content-Language: en-GB To: Arunpravin , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org References: <20211025130033.1547667-1-Arunpravin.PaneerSelvam@amd.com> <20211025130033.1547667-6-Arunpravin.PaneerSelvam@amd.com> From: Matthew Auld In-Reply-To: <20211025130033.1547667-6-Arunpravin.PaneerSelvam@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.deucher@amd.com, tzimmermann@suse.de, jani.nikula@linux.intel.com, christian.koenig@amd.com, daniel@ffwll.ch Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 25/10/2021 14:00, Arunpravin wrote: > - Remove drm_mm references and replace with drm buddy functionalities > - Add res cursor support for drm buddy > > Signed-off-by: Arunpravin > + spin_lock(&mgr->lock); > + r = drm_buddy_alloc(mm, (uint64_t)place->fpfn << PAGE_SHIFT, > + (uint64_t)lpfn << PAGE_SHIFT, > + (uint64_t)n_pages << PAGE_SHIFT, > + min_page_size, &node->blocks, > + node->flags); Is spinlock + GFP_KERNEL allowed? > + spin_unlock(&mgr->lock); > + > + if (unlikely(r)) > + goto error_free_blocks; > + > pages_left -= pages; > ++i; > > if (pages > pages_left) > pages = pages_left; > } > - spin_unlock(&mgr->lock); > + > + /* Free unused pages for contiguous allocation */ > + if (place->flags & TTM_PL_FLAG_CONTIGUOUS) { > + uint64_t actual_size = (uint64_t)node->base.num_pages << PAGE_SHIFT; > + > + r = drm_buddy_free_unused_pages(mm, > + actual_size, > + &node->blocks); Needs some locking.