From: Andy Furniss <adf.lists-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 3/3] drm/amdgpu: add vce bypass mode for tonga.
Date: Tue, 13 Sep 2016 00:43:50 +0100 [thread overview]
Message-ID: <57D73DB6.2000709@gmail.com> (raw)
In-Reply-To: <1471866091-28963-3-git-send-email-user@rexzhu>
This regresses vce perf badly on tonga
https://bugs.freedesktop.org/show_bug.cgi?id=97494
Maybe I need a better test case or faster cpu or something,
but vce powerplay encode issues disappeared for me with the latest
firmware.
root wrote:
> From: Rex Zhu <Rex.Zhu@amd.com>
>
> fix issue that encode test failed on the second time when
> vce dpm enabled on tonga.
>
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
>
> Change-Id: I9c77b631b977ab5cc14dc553b6e6beb502e4bd0e
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> index df66abe..168b0db 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> @@ -704,7 +704,8 @@ static int vce_v3_0_set_clockgating_state(void *handle,
> bool enable = (state == AMD_CG_STATE_GATE) ? true : false;
> int i;
>
> - if (adev->asic_type == CHIP_POLARIS10)
> + if ((adev->asic_type == CHIP_POLARIS10) ||
> + (adev->asic_type == CHIP_TONGA))
> vce_v3_0_set_bypass_mode(adev, enable);
>
> if (!(adev->cg_flags & AMD_CG_SUPPORT_VCE_MGCG))
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-09-12 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 11:41 [PATCH 1/3] drm/amdgpu: refine function name for consistency root
2016-08-22 11:41 ` [PATCH 2/3] drm/amd/powerplay: add bypass mode for vce 2.0 root
2016-08-22 11:41 ` [PATCH 3/3] drm/amdgpu: add vce bypass mode for tonga root
2016-09-12 23:43 ` Andy Furniss [this message]
[not found] ` <57D73DB6.2000709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-23 20:55 ` Andy Furniss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D73DB6.2000709@gmail.com \
--to=adf.lists-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Rex.Zhu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox