From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 1/1] drm/amdgpu: remove unnecessary smc sk firmware for polaris12
Date: Fri, 23 Dec 2016 10:12:25 +0800 [thread overview]
Message-ID: <585C8809.5020803@amd.com> (raw)
In-Reply-To: <1482457719-31191-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
On 2016年12月23日 09:48, Junwei Zhang wrote:
> Change-Id: I8b08dcb352f20f277cbad1ffdad900118ec8a384
> Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 5 +----
> drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 1 -
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> index f13497a..d0e8710 100755
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -845,10 +845,7 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device,
> strcpy(fw_name, "amdgpu/polaris10_smc_sk.bin");
> break;
> case CHIP_POLARIS12:
> - if (type == CGS_UCODE_ID_SMU)
> - strcpy(fw_name, "amdgpu/polaris12_smc.bin");
> - else if (type == CGS_UCODE_ID_SMU_SK)
> - strcpy(fw_name, "amdgpu/polaris12_smc_sk.bin");
> + strcpy(fw_name, "amdgpu/polaris12_smc.bin");
> break;
> default:
> DRM_ERROR("SMC firmware not supported\n");
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c
> index 1412f30..45737cd 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c
> @@ -40,7 +40,6 @@ MODULE_FIRMWARE("amdgpu/polaris10_smc_sk.bin");
> MODULE_FIRMWARE("amdgpu/polaris11_smc.bin");
> MODULE_FIRMWARE("amdgpu/polaris11_smc_sk.bin");
> MODULE_FIRMWARE("amdgpu/polaris12_smc.bin");
> -MODULE_FIRMWARE("amdgpu/polaris12_smc_sk.bin");
>
> int smum_init(struct amd_pp_init *pp_init, struct pp_instance *handle)
> {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-12-23 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 1:48 [PATCH 1/1] drm/amdgpu: remove unnecessary smc sk firmware for polaris12 Junwei Zhang
[not found] ` <1482457719-31191-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
2016-12-23 2:12 ` zhoucm1 [this message]
2016-12-23 2:27 ` Huang Rui
2016-12-29 14:37 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585C8809.5020803@amd.com \
--to=david1.zhou-5c7gfcevmho@public.gmane.org \
--cc=Jerry.Zhang-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox