From: Alex Hung <alex.hung@amd.com>
To: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: amd-gfx@lists.freedesktop.org,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
Dillon Varone <Dillon.Varone@amd.com>,
Chuanyu Tseng <chuanyu.tseng@amd.com>,
Roman Li <roman.li@amd.com>, Tom Chung <chiahsuan.chung@amd.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH v2] drm/amd/display: Add update_descriptor param info in 'update_planes_and_stream_state'
Date: Thu, 26 Mar 2026 19:04:45 -0600 [thread overview]
Message-ID: <589bb7c5-3efa-4e37-99db-685fbf1b8d12@amd.com> (raw)
In-Reply-To: <20260323043857.2043958-1-srinivasan.shanmugam@amd.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 3/22/26 22:38, Srinivasan Shanmugam wrote:
> Add missing info for the update_descriptor parameter in
> update_planes_and_stream_state().
>
> Fixes the below with gcc W=1:
> ../display/dc/core/dc.c:3630 function parameter 'update_descriptor' not described in 'update_planes_and_stream_state'
>
> Fixes: 90fe5f44136d ("drm/amd/display: Refactor DC update checks")
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> Cc: Dillon Varone <Dillon.Varone@amd.com>
> Cc: Chuanyu Tseng <chuanyu.tseng@amd.com>
> Cc: Roman Li <roman.li@amd.com>
> Cc: Alex Hung <alex.hung@amd.com>
> Cc: Tom Chung <chiahsuan.chung@amd.com>
> Cc: Dan Carpenter <dan.carpenter@linaro.org>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 8b21816cf7c8..e3992ca43c8d 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3615,6 +3615,7 @@ static void restore_minimal_pipe_split_policy(struct dc *dc,
> * @surface_count: surface update count
> * @stream: Corresponding stream to be updated
> * @stream_update: stream update
> + * @update_descriptor: describes what plane and stream changes to apply
> * @new_update_type: [out] determined update type by the function
> * @new_context: [out] new context allocated and validated if update type is
> * FULL, reference to current context if update type is less than FULL.
prev parent reply other threads:[~2026-03-27 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 4:38 [PATCH v2] drm/amd/display: Add update_descriptor param info in 'update_planes_and_stream_state' Srinivasan Shanmugam
2026-03-27 1:04 ` Alex Hung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589bb7c5-3efa-4e37-99db-685fbf1b8d12@amd.com \
--to=alex.hung@amd.com \
--cc=Dillon.Varone@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=chuanyu.tseng@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=roman.li@amd.com \
--cc=srinivasan.shanmugam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox