From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>,
Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/soc15: Fix static checker warnings
Date: Wed, 5 Apr 2017 09:41:21 +0800 [thread overview]
Message-ID: <58E44B41.3010406@amd.com> (raw)
In-Reply-To: <48fb0a7d-9349-f9ae-d281-50ff3015e834-5C7GfCeVMHo@public.gmane.org>
On 04/04/2017 07:02 AM, Harry Wentland wrote:
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
>
> On 2017-04-03 04:58 PM, Alex Deucher wrote:
>> vega10 is the only soc15 asic at the moment so these
>> warnings are invalid, but add a default case to silence
>> the warnings.
>>
>> Fixes: 220ab9bd1ccf: "drm/amdgpu: soc15 enable (v3)"
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/soc15.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
>> b/drivers/gpu/drm/amd/amdgpu/soc15.c
>> index bb14a45..758facd 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
>> @@ -106,6 +106,8 @@ static u32 soc15_pcie_rreg(struct amdgpu_device *adev,
>> u32 reg)
>> if (adev->asic_type == CHIP_VEGA10)
>> nbio_pcie_id = &nbio_v6_1_pcie_index_data;
>> + else
>> + BUG();
>> address = nbio_pcie_id->index_offset;
>> data = nbio_pcie_id->data_offset;
>> @@ -125,6 +127,8 @@ static void soc15_pcie_wreg(struct amdgpu_device *adev,
>> u32 reg, u32 v)
>> if (adev->asic_type == CHIP_VEGA10)
>> nbio_pcie_id = &nbio_v6_1_pcie_index_data;
>> + else
>> + BUG();
>> address = nbio_pcie_id->index_offset;
>> data = nbio_pcie_id->data_offset;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-04-05 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 20:58 [PATCH] drm/amdgpu/soc15: Fix static checker warnings Alex Deucher
[not found] ` <1491253121-28851-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-04-03 23:02 ` Harry Wentland
[not found] ` <48fb0a7d-9349-f9ae-d281-50ff3015e834-5C7GfCeVMHo@public.gmane.org>
2017-04-05 1:41 ` Zhang, Jerry (Junwei) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58E44B41.3010406@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=harry.wentland-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox