From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: Alex Xie <AlexBin.Xie-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 2/3] drm/amdgpu: Remove two ! operations in an if condition
Date: Wed, 31 May 2017 10:59:24 +0800 [thread overview]
Message-ID: <592E318C.3010807@amd.com> (raw)
In-Reply-To: <1496180868-2617-2-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org>
On 2017年05月31日 05:47, Alex Xie wrote:
> Make the code easier to understand.
>
> Signed-off-by: Alex Xie <AlexBin.Xie@amd.com>
ok to me, Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 7a323f9..9fdeb82 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -680,9 +680,11 @@ bool amdgpu_vm_need_pipeline_sync(struct amdgpu_ring *ring,
>
> if (amdgpu_vm_had_gpu_reset(adev, id))
> return true;
> - if (!vm_flush_needed && !gds_switch_needed)
> +
> + if (vm_flush_needed || gds_switch_needed)
> + return true;
> + else
> return false;
> - return true;
> }
>
> /**
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-05-31 2:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 21:47 [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling Alex Xie
[not found] ` <1496180868-2617-1-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org>
2017-05-30 21:47 ` [PATCH 2/3] drm/amdgpu: Remove two ! operations in an if condition Alex Xie
[not found] ` <1496180868-2617-2-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org>
2017-05-31 2:59 ` zhoucm1 [this message]
2017-05-31 3:09 ` Michel Dänzer
2017-05-31 6:59 ` Christian König
2017-05-30 21:47 ` [PATCH 3/3] drm/amdgpu: clean up code to make it easier to understand Alex Xie
[not found] ` <1496180868-2617-3-git-send-email-AlexBin.Xie-5C7GfCeVMHo@public.gmane.org>
2017-05-31 3:11 ` zhoucm1
2017-05-31 2:58 ` [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling zhoucm1
2017-05-31 6:57 ` Christian König
[not found] ` <966bbfa3-488d-2a12-7ebd-cf59812928d6-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-31 12:53 ` Xie, AlexBin
[not found] ` <MWHPR1201MB0045FC6C00CA6008273C385BF2F10-3iK1xFAIwjq45V35fqe+hGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-05-31 13:07 ` Christian König
[not found] ` <c856088d-e779-4f5f-6252-d7f547124861-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-31 18:28 ` Xie, AlexBin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592E318C.3010807@amd.com \
--to=david1.zhou-5c7gfcevmho@public.gmane.org \
--cc=AlexBin.Xie-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox