From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: wentalou <Wentao.Lou-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: sriov restrict max_pfn below AMDGPU_GMC_HOLE
Date: Mon, 28 Jan 2019 09:55:07 +0100 [thread overview]
Message-ID: <597d1ee6-e3b5-1db9-eebd-498c7cf0dea8@gmail.com> (raw)
In-Reply-To: <1548301091-26581-1-git-send-email-Wentao.Lou-5C7GfCeVMHo@public.gmane.org>
Am 24.01.19 um 04:38 schrieb wentalou:
> sriov need to restrict max_pfn below AMDGPU_GMC_HOLE.
> access the hole results in a range fault interrupt IIRC.
>
> Change-Id: I0add197a24a54388a128a545056e9a9f0330abfb
> Signed-off-by: Wentao Lou <Wentao.Lou@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 3 +--
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 6 +++++-
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c
> index dd3bd01..7e22be7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c
> @@ -26,8 +26,7 @@
>
> uint64_t amdgpu_csa_vaddr(struct amdgpu_device *adev)
> {
> - uint64_t addr = min(adev->vm_manager.max_pfn << AMDGPU_GPU_PAGE_SHIFT,
> - AMDGPU_GMC_HOLE_START);
> + uint64_t addr = adev->vm_manager.max_pfn << AMDGPU_GPU_PAGE_SHIFT;
>
> addr -= AMDGPU_VA_RESERVED_SIZE;
> addr = amdgpu_gmc_sign_extend(addr);
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 9c082f9..600259b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -965,7 +965,11 @@ static int gmc_v9_0_sw_init(void *handle)
> * vm size is 256TB (48bit), maximum size of Vega10,
> * block size 512 (9bit)
> */
> - amdgpu_vm_adjust_size(adev, 256 * 1024, 9, 3, 48);
> + /* sriov restrict max_pfn below AMDGPU_GMC_HOLE */
> + if (amdgpu_sriov_vf(adev))
> + amdgpu_vm_adjust_size(adev, 256 * 1024, 9, 3, 47);
> + else
> + amdgpu_vm_adjust_size(adev, 256 * 1024, 9, 3, 48);
> break;
> default:
> break;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-01-28 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 3:38 [PATCH] drm/amdgpu: sriov restrict max_pfn below AMDGPU_GMC_HOLE wentalou
[not found] ` <1548301091-26581-1-git-send-email-Wentao.Lou-5C7GfCeVMHo@public.gmane.org>
2019-01-28 8:55 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=597d1ee6-e3b5-1db9-eebd-498c7cf0dea8@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Wentao.Lou-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox