Re: [PATCH] drm/amdgpu: fix swapped emit_ib_size in vce3

["Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>]

On 06/29/2018 02:37 AM, Alex Deucher wrote:
> The phys and vm versions had the values swapped.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Nice catch.
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> index 23927cdfbc23..99604d0262ad 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> @@ -900,7 +900,7 @@ static const struct amdgpu_ring_funcs vce_v3_0_ring_phys_funcs = {
>   	.emit_frame_size =
>   		4 + /* vce_v3_0_emit_pipeline_sync */
>   		6, /* amdgpu_vce_ring_emit_fence x1 no user fence */
> -	.emit_ib_size = 5, /* vce_v3_0_ring_emit_ib */
> +	.emit_ib_size = 4, /* amdgpu_vce_ring_emit_ib */
>   	.emit_ib = amdgpu_vce_ring_emit_ib,
>   	.emit_fence = amdgpu_vce_ring_emit_fence,
>   	.test_ring = amdgpu_vce_ring_test_ring,
> @@ -924,7 +924,7 @@ static const struct amdgpu_ring_funcs vce_v3_0_ring_vm_funcs = {
>   		6 + /* vce_v3_0_emit_vm_flush */
>   		4 + /* vce_v3_0_emit_pipeline_sync */
>   		6 + 6, /* amdgpu_vce_ring_emit_fence x2 vm fence */
> -	.emit_ib_size = 4, /* amdgpu_vce_ring_emit_ib */
> +	.emit_ib_size = 5, /* vce_v3_0_ring_emit_ib */
>   	.emit_ib = vce_v3_0_ring_emit_ib,
>   	.emit_vm_flush = vce_v3_0_emit_vm_flush,
>   	.emit_pipeline_sync = vce_v3_0_emit_pipeline_sync,
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx